Re: [PATCH] config: adding dts tag for dts path patches

[Patrick Robb <probb@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]

Good catch Aaron, sorry that I missed this in my review.

We will accept your offer to amend the commit on apply. :)

On Mon, Oct 7, 2024 at 11:53 AM Aaron Conole <aconole@redhat.com> wrote:

> Manit Mahajan <mmahajan@iol.unh.edu> writes:
>
> > DTS provides a check-format script which runs a series of code quality
> > checks including formatting, linting, and type-checking using the
> > following tools: black, isort, pylama, and mypy. Developers are supposed
> > to run this script before submitting their patch series. In CI testing,
> > we want to run this formatting script on all patches which modify
> > dpdk/dts/* going forward, and submit a new patchwork check named
> > dts-check-format. In order to do this, we need to be able to set a tag
> > in the patch parser script for all patch series which meet this
> > condition. This series adds the dts tag and path assignment to
> > config/patch_parser.cfg.
> >
> > Signed-off-by: Manit Mahajan
> > ---
>
> Hi Manit,
>
> FYI, your signed-off-by line is incorrect.  It is missing the email
> address.  I can add it on apply if you are okay with that, but in the
> future, it should look like::
>
>   Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
>
> Thanks!
>
> >  config/patch_parser.cfg | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/config/patch_parser.cfg b/config/patch_parser.cfg
> > index 5757f9a..dac3b23 100644
> > --- a/config/patch_parser.cfg
> > +++ b/config/patch_parser.cfg
> > @@ -13,6 +13,7 @@ app = application
> >  license = documentation
> >  VERSION = documentation
> >  build = core
> > +dts = dts
> >
> >  # This is an ordered list of the importance of each patch
> classification.
> >  # It should be used to determine which classification to use on tools
> which
> > @@ -22,4 +23,5 @@ priority_list =
> >      core,
> >      driver,
> >      application,
> > -    documentation
> > +    documentation,
> > +    dts
>
>

[-- Attachment #2: Type: text/html, Size: 2657 bytes --]