From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01CDE45AD6; Mon, 7 Oct 2024 17:55:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2694427E8; Mon, 7 Oct 2024 17:55:20 +0200 (CEST) Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) by mails.dpdk.org (Postfix) with ESMTP id C14294026C for ; Mon, 7 Oct 2024 17:55:19 +0200 (CEST) Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-84eb1deaf03so1113091241.3 for ; Mon, 07 Oct 2024 08:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1728316519; x=1728921319; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xF7bIQDnOJZzEXK/qFumL2rhD8+SShjfPdZPUMLmY8U=; b=cQtzud3JdSwyvwiPfksJ5emOVIlgoeP2Iqg//MI75zsulWLc0h/Veuls3iU+9EtgDb uCezd3toSCvKoM5fcyAH8kF1kQSjl5FR8R05f1/uUHiJ/BrC9qYI+3S+qcRvPrg/7rld GNU1TZoOxIUlit2yEYVjs2Pm2Daw+BCNl+P98= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728316519; x=1728921319; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xF7bIQDnOJZzEXK/qFumL2rhD8+SShjfPdZPUMLmY8U=; b=oDYXsAox3ETV6S3mwTbOjDBiszWHYA7DRN/B3ETIImsSWWAYIOqFnHewCEenVIlnla 9npL30CyZxiILBIeVvb6c9D+K1rRfQGM1l56+cu7alv1EnvF/5Xn50fyreUUHYIGh/kw 8dw21WZz+LAXObN7y2UrhZIaTdC/gFmGU41bk9EyPYz3o4sn/iQh4NhYrUkc/js0+tfc 2tofxCdoKVy/2kfn6uKDvp3NO1zqAkXaZS3Qs/EeQxTjEwHRTibhT0nMonjlpcIFDVRQ YcPhRRmssU1F7vDktqgs+kb7TKAt3S6/FEKcA1Kis4k93On38su9JBwsTk+0f8FLNO0K Y4Og== X-Forwarded-Encrypted: i=1; AJvYcCUWNukbTeG8aOOWQPAZ6LcUIWjaRJbUJu7xBJJtvySQF6Q+MUf8K01+aAyJl8eArpqhMg==@dpdk.org X-Gm-Message-State: AOJu0YyyA/qGlnrylQoyfHioV/UlOYsE2wtswlp06mowsQq6gVPz0f/Z eiWhcBcPAJ8xBHihQEW4bkjoKLOs/qzFlXmLG7Ja09CslauXluW2RBlmkf03bURrdIZ98YjR8eV Q26Juc6qwhu35QN7AdQQkUk8cVPwmXkpRwB9M8w== X-Google-Smtp-Source: AGHT+IG42ux82jEJUXZCdNUEJxAOe6JukHj+oROsbQvEgvZ6zEP4lBhKXlmkurJE+iDCxjD0YMlscTNEt6ocQii1pqw= X-Received: by 2002:a05:6102:54a9:b0:493:e643:bed with SMTP id ada2fe7eead31-4a40579c851mr7858852137.13.1728316519142; Mon, 07 Oct 2024 08:55:19 -0700 (PDT) MIME-Version: 1.0 References: <20241001170703.30348-1-mmahajan@iol.unh.edu> In-Reply-To: From: Patrick Robb Date: Mon, 7 Oct 2024 11:54:02 -0400 Message-ID: Subject: Re: [PATCH] config: adding dts tag for dts path patches To: Aaron Conole Cc: Manit Mahajan , ci@dpdk.org, alialnu@nvidia.com, Luca Vizzarro Content-Type: multipart/alternative; boundary="0000000000002ef1a30623e50c28" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --0000000000002ef1a30623e50c28 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Good catch Aaron, sorry that I missed this in my review. We will accept your offer to amend the commit on apply. :) On Mon, Oct 7, 2024 at 11:53=E2=80=AFAM Aaron Conole w= rote: > Manit Mahajan writes: > > > DTS provides a check-format script which runs a series of code quality > > checks including formatting, linting, and type-checking using the > > following tools: black, isort, pylama, and mypy. Developers are suppose= d > > to run this script before submitting their patch series. In CI testing, > > we want to run this formatting script on all patches which modify > > dpdk/dts/* going forward, and submit a new patchwork check named > > dts-check-format. In order to do this, we need to be able to set a tag > > in the patch parser script for all patch series which meet this > > condition. This series adds the dts tag and path assignment to > > config/patch_parser.cfg. > > > > Signed-off-by: Manit Mahajan > > --- > > Hi Manit, > > FYI, your signed-off-by line is incorrect. It is missing the email > address. I can add it on apply if you are okay with that, but in the > future, it should look like:: > > Signed-off-by: Manit Mahajan > > Thanks! > > > config/patch_parser.cfg | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/config/patch_parser.cfg b/config/patch_parser.cfg > > index 5757f9a..dac3b23 100644 > > --- a/config/patch_parser.cfg > > +++ b/config/patch_parser.cfg > > @@ -13,6 +13,7 @@ app =3D application > > license =3D documentation > > VERSION =3D documentation > > build =3D core > > +dts =3D dts > > > > # This is an ordered list of the importance of each patch > classification. > > # It should be used to determine which classification to use on tools > which > > @@ -22,4 +23,5 @@ priority_list =3D > > core, > > driver, > > application, > > - documentation > > + documentation, > > + dts > > --0000000000002ef1a30623e50c28 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Good catch Aaron, sorry that I missed this in my review.= =C2=A0

We will accept your offer to amend the commit on = apply. :)

On Mon, Oct 7, 2024 at 11:53=E2=80=AFAM Aaron Conole <aconole@redhat.com> wrote:
Manit Mahajan <mmahajan@iol.unh.edu= > writes:

> DTS provides a check-format script which runs a series of code quality=
> checks including formatting, linting, and type-checking using the
> following tools: black, isort, pylama, and mypy. Developers are suppos= ed
> to run this script before submitting their patch series. In CI testing= ,
> we want to run this formatting script on all patches which modify
> dpdk/dts/* going forward, and submit a new patchwork check named
> dts-check-format. In order to do this, we need to be able to set a tag=
> in the patch parser script for all patch series which meet this
> condition. This series adds the dts tag and path assignment to
> config/patch_parser.cfg.
>
> Signed-off-by: Manit Mahajan
> ---

Hi Manit,

FYI, your signed-off-by line is incorrect.=C2=A0 It is missing the email address.=C2=A0 I can add it on apply if you are okay with that, but in the<= br> future, it should look like::

=C2=A0 Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>

Thanks!

>=C2=A0 config/patch_parser.cfg | 4 +++-
>=C2=A0 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/config/patch_parser.cfg b/config/patch_parser.cfg
> index 5757f9a..dac3b23 100644
> --- a/config/patch_parser.cfg
> +++ b/config/patch_parser.cfg
> @@ -13,6 +13,7 @@ app =3D application
>=C2=A0 license =3D documentation
>=C2=A0 VERSION =3D documentation
>=C2=A0 build =3D core
> +dts =3D dts
>=C2=A0
>=C2=A0 # This is an ordered list of the importance of each patch classi= fication.
>=C2=A0 # It should be used to determine which classification to use on = tools which
> @@ -22,4 +23,5 @@ priority_list =3D
>=C2=A0 =C2=A0 =C2=A0 core,
>=C2=A0 =C2=A0 =C2=A0 driver,
>=C2=A0 =C2=A0 =C2=A0 application,
> -=C2=A0 =C2=A0 documentation
> +=C2=A0 =C2=A0 documentation,
> +=C2=A0 =C2=A0 dts

--0000000000002ef1a30623e50c28--