From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FA2B4290B for ; Mon, 10 Apr 2023 16:56:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CF3D40DDC; Mon, 10 Apr 2023 16:56:16 +0200 (CEST) Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by mails.dpdk.org (Postfix) with ESMTP id 6637C40A81 for ; Mon, 10 Apr 2023 16:56:15 +0200 (CEST) Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-1842d8976d9so6299093fac.9 for ; Mon, 10 Apr 2023 07:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1681138574; x=1683730574; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jCJcMCxaXo9XUw3gYxTveCo45jzpMlx3ns0rpGZHxPo=; b=DtHVMrAUZBjSsXsKKIS/EmEMOMXyum5MXlA0yRT2mvWIuB+06LpGoS88pCb8GZLgsH V8qas1Kkzae8MJ/om9BtEnQmEhTMuqtsC8yevY0Q8Qq0lKWd+37TPs/DsMAVFYmWgOrI MuDu2CXSj5/rp6Ek8rkfAXu5vAs/LizXMc2SA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681138574; x=1683730574; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jCJcMCxaXo9XUw3gYxTveCo45jzpMlx3ns0rpGZHxPo=; b=lTzebwaGb4fIGxlJLnCACt3yX3UmALEKtiHfgZoHBKq1xD3FxRkkpgmbMPV7O++fgf 8eg7tgvVAYwc9kPkXh9gBS8qZGXuQ0gn/sEnMIQwws9KT2BBmmeF1/QtdlYkUGr8CYMg tpVGXw1yL9HmVvBTBgzD2xR7eCuGvCMI220CbB/EMxxvc8fRN4Igc0hXfyNTSgfbKIOt fYR2b8Ih/E0FxpYNpwsX8h9p3weVbLkED9FI+qq5Rh7ZKLd/L+pxJbWKUhM/Y3rJXYLh vX9DosnSaZmCyvjFRFL4V77zzV2Nrp2OYZj+RzilX12OlqQsrTIaU5Otf9dkWmbB2U2P xA+Q== X-Gm-Message-State: AAQBX9eMAeclsMpQmZtQxCUmyW7fIk8MGx+EiCm8dpR/m/F3ZawWN7MV Snc7Wmu7qsligYstHhx7BLqhch/V+46b/YsZ0R0DpQ== X-Google-Smtp-Source: AKy350YVomz7Ljv9QPZSahG8Fda3m/X2iFgY0bw3uVxuPZHORZTV4m2FGCu1D8uWtpKlmqN0vZ+iIOPa9WuPrCJ41NU= X-Received: by 2002:a05:6870:d62b:b0:17a:b31c:9e1e with SMTP id a43-20020a056870d62b00b0017ab31c9e1emr3594768oaq.1.1681138574436; Mon, 10 Apr 2023 07:56:14 -0700 (PDT) MIME-Version: 1.0 References: <20230403183930.12001-2-jspewock@iol.unh.edu> In-Reply-To: From: Patrick Robb Date: Mon, 10 Apr 2023 10:56:03 -0400 Message-ID: Subject: Re: [PATCH v7 0/4] Add ACVP Tool To: Ali Alnubani Cc: "jspewock@iol.unh.edu" , "ci@dpdk.org" Content-Type: multipart/alternative; boundary="0000000000008c45a405f8fc933c" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --0000000000008c45a405f8fc933c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ali, Is this good to be merged since it's been acked by a maintainer with no more discussion afterwards? Or is there something more to be done here? Thanks, Patrick On Tue, Apr 4, 2023 at 9:20=E2=80=AFAM Ali Alnubani wr= ote: > > -----Original Message----- > > From: jspewock@iol.unh.edu > > Sent: Monday, April 3, 2023 9:39 PM > > To: ci@dpdk.org > > Cc: Jeremy Spewock > > Subject: [PATCH v7 0/4] Add ACVP Tool > > > > From: Jeremy Spewock > > > > v1: https://mails.dpdk.org/archives/ci/2022-January/001599.html > > v2: https://mails.dpdk.org/archives/ci/2022-January/001611.html > > v3: https://mails.dpdk.org/archives/ci/2022-February/001636.html > > v4: https://mails.dpdk.org/archives/ci/2022-April/001702.html > > v5: https://mails.dpdk.org/archives/ci/2023-March/002112.html > > v6: https://mails.dpdk.org/archives/ci/2023-March/002147.html > > v7: > > * fix commit messages > > * fix whitespace errors > > > > Brandon Lo (4): > > tools: add acvp_tool > > tools: add default config file for acvp_tool > > tools: add requirements file for acvp_tool > > doc: add readme file for acvp_tool > > > > tools/acvp/README | 118 +++++++++++++ > > tools/acvp/__init__.py | 0 > > tools/acvp/acvp_config.json | 52 ++++++ > > tools/acvp/acvp_tool.py | 319 > > ++++++++++++++++++++++++++++++++++++ > > tools/acvp/requirements.txt | 7 + > > 5 files changed, 496 insertions(+) > > create mode 100644 tools/acvp/README > > create mode 100644 tools/acvp/__init__.py > > create mode 100644 tools/acvp/acvp_config.json > > create mode 100755 tools/acvp/acvp_tool.py > > create mode 100644 tools/acvp/requirements.txt > > > > -- > > 2.40.0 > > Thank you for addressing comments. > > Acked-by: Ali Alnubani > --=20 Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --0000000000008c45a405f8fc933c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ali,

Is this good to be merged since= it's been acked=C2=A0by a maintainer with no more discussion afterward= s? Or is there something more to be done here?=C2=A0

Thanks,
Patrick

On Tue, Apr 4, 2023 at 9:20=E2=80=AFAM Al= i Alnubani <alialnu@nvidia.com= > wrote:
>= -----Original Message-----
> From: jspewo= ck@iol.unh.edu <jspewock@iol.unh.edu>
> Sent: Monday, April 3, 2023 9:39 PM
> To: ci@dpdk.org > Cc: Jeremy Spewock <jspewock@iol.unh.edu>
> Subject: [PATCH v7 0/4] Add ACVP Tool
>
> From: Jeremy Spewock <jspewock@iol.unh.edu>
>
> v1: https://mails.dpdk.org/archives/= ci/2022-January/001599.html
> v2: https://mails.dpdk.org/archives/= ci/2022-January/001611.html
> v3: https://mails.dpdk.org/archives= /ci/2022-February/001636.html
> v4: https://mails.dpdk.org/archives/ci= /2022-April/001702.html
> v5: https://mails.dpdk.org/archives/ci= /2023-March/002112.html
> v6: https://mails.dpdk.org/archives/ci= /2023-March/002147.html
> v7:
>=C2=A0 =C2=A0* fix commit messages
>=C2=A0 =C2=A0* fix whitespace errors
>
> Brandon Lo (4):
>=C2=A0 =C2=A0tools: add acvp_tool
>=C2=A0 =C2=A0tools: add default config file for acvp_tool
>=C2=A0 =C2=A0tools: add requirements file for acvp_tool
>=C2=A0 =C2=A0doc: add readme file for acvp_tool
>
>=C2=A0 tools/acvp/README=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 118 = +++++++++++++
>=C2=A0 tools/acvp/__init__.py=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A00
>=C2=A0 tools/acvp/acvp_config.json |=C2=A0 52 ++++++
>=C2=A0 tools/acvp/acvp_tool.py=C2=A0 =C2=A0 =C2=A0| 319
> ++++++++++++++++++++++++++++++++++++
>=C2=A0 tools/acvp/requirements.txt |=C2=A0 =C2=A07 +
>=C2=A0 5 files changed, 496 insertions(+)
>=C2=A0 create mode 100644 tools/acvp/README
>=C2=A0 create mode 100644 tools/acvp/__init__.py
>=C2=A0 create mode 100644 tools/acvp/acvp_config.json
>=C2=A0 create mode 100755 tools/acvp/acvp_tool.py
>=C2=A0 create mode 100644 tools/acvp/requirements.txt
>
> --
> 2.40.0

Thank you for addressing comments.

Acked-by: Ali Alnubani <alialnu@nvidia.com>


--

Patrick Robb

<= span style=3D"font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-= color:transparent;vertical-align:baseline;white-space:pre-wrap">Technical S= ervice Manager

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

www.iol.unh.edu


--0000000000008c45a405f8fc933c--