From: Patrick Robb <probb@iol.unh.edu>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: David Marchand <david.marchand@redhat.com>,
"ci@dpdk.org" <ci@dpdk.org>, Aaron Conole <aconole@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: Meson buildtype for ci jobs?
Date: Wed, 15 Mar 2023 15:13:30 -0400 [thread overview]
Message-ID: <CAJvnSUB+JH1UW8bUe0Nv5w-7eTnmDtb7anrSFLmXsgHFGYbFWQ@mail.gmail.com> (raw)
In-Reply-To: <DS0PR11MB730955EC70691C25045A839397BF9@DS0PR11MB7309.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 3691 bytes --]
>
> Would passing "-Ddebug=true" be better than changing the default buildtype?
> It's possible to have a release build (i.e. O3 optimized) with debug info.
>
Strangely, even with -Ddebug true if I'm running buildtype "release" it
returns the same warnings. I'm inferring from your comment that release
optimization == debugoptimized optimization and debug behavior from
-Ddebug=true == debug behavior from debugoptimized, so release buildtype +
debug "should" have the same behavior as just setting buildtype
debugoptimized, and yet...
I'll have to look into this a little more. Hopefully by the end I'll be
like David and understand the relations between these flags better, hah.
On Wed, Mar 15, 2023 at 1:02 PM Richardson, Bruce <
bruce.richardson@intel.com> wrote:
>
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Wednesday, March 15, 2023 4:08 PM
> > To: Patrick Robb <probb@iol.unh.edu>
> > Cc: ci@dpdk.org; Aaron Conole <aconole@redhat.com>; Richardson, Bruce
> > <bruce.richardson@intel.com>; Thomas Monjalon <thomas@monjalon.net>
> > Subject: Re: Meson buildtype for ci jobs?
> >
> > On Wed, Mar 15, 2023 at 4:52 PM Patrick Robb <probb@iol.unh.edu> wrote:
> > >
> > > Hello all,
> > >
> > > The lab recently received a request to re-enable Alpine compile jobs,
> > which have been disabled for almost a year. In dry running the compile
> > job, I noticed that it was failing. At the same time, David Marchand did
> > an Alpine compile with Github Actions which was successful. It seems the
> > source of the different behavior is the meson buildtype being used - the
> > build script used by GHA sets meson buildtype to debugoptimized, whereas
> > the script used by the community lab runs with buildtype debug (the meson
> > default). I did my own Github Actions runs (with both buildtype options)
> > to sanity check:
> >
> https://github.com/PatrickRobbIOL/dpdk/actions/runs/4427160204/jobs/776436
> > 8640
> >
> > Are you sure about the default value?
> >
> > Afaics, meson selects by default a "release" buildtype (and I think I
> > always saw this value in the past).
> > I have this with meson 1.0.
> >
> > $ meson setup qsdlgfh
> > ...
> > $ meson configure qsdlgfh | grep buildtype
> > buildtype release
> > [plain, debug, debugoptimized, Build type to use
> >
> > >
> > > The reason I'm writing this email is that I'm wondering whether the
> > buildtype decision made by those who wrote .ci/linux-build.sh for GHA was
> > intentional and important. I know many of the people who have commits on
> > that script follow this mailing list. Obviously if it's in some way more
> > appropriate for CI purposes to run meson setup in this way, I'm happy to
> > make that change at the lab and in the process that would free up
> bringing
> > Alpine compile testing online. But, if not, then I think it's most
> > appropriate to consider compile on Alpine as broken and avoid bringing
> > coverage for Alpine online until that issue is resolved.
> >
> > The reason why we went with debugoptimized was primarly for the ABI
> > checks, as by default, the debug symbols were missing (which would
> > match with a "release" default buildtype).
> > See 777014e56d07 ("devtools: add ABI checks").
> >
>
> Would passing "-Ddebug=true" be better than changing the default buildtype?
> It's possible to have a release build (i.e. O3 optimized) with debug info.
>
> /Bruce
>
--
Patrick Robb
Technical Service Manager
UNH InterOperability Laboratory
21 Madbury Rd, Suite 100, Durham, NH 03824
www.iol.unh.edu
[-- Attachment #2: Type: text/html, Size: 7020 bytes --]
next prev parent reply other threads:[~2023-03-15 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 15:52 Patrick Robb
2023-03-15 16:07 ` David Marchand
2023-03-15 16:43 ` Patrick Robb
2023-03-15 17:01 ` Richardson, Bruce
2023-03-15 17:09 ` David Marchand
2023-03-15 17:11 ` Richardson, Bruce
2023-03-15 19:13 ` Patrick Robb [this message]
2023-03-16 8:49 ` David Marchand
2023-03-16 9:08 ` David Marchand
2023-03-16 10:06 ` Bruce Richardson
2023-03-16 9:03 ` Richardson, Bruce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUB+JH1UW8bUe0Nv5w-7eTnmDtb7anrSFLmXsgHFGYbFWQ@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ci@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).