From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 226DB41EA3 for ; Wed, 15 Mar 2023 20:13:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D4A540EE4; Wed, 15 Mar 2023 20:13:44 +0100 (CET) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by mails.dpdk.org (Postfix) with ESMTP id 3261040141 for ; Wed, 15 Mar 2023 20:13:42 +0100 (CET) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-17ac5ee3f9cso3322393fac.12 for ; Wed, 15 Mar 2023 12:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1678907621; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=o2vvuKdrAdXp+gajox/gt3z2jdSyI7VaN2kE9Je49nw=; b=ZTuNP7zd5I3u7yZpejyz7Hb/+1MpRbdOJzUfk9zbbnYMn2+lloloXjKbKzngQh1//F LsiTFPVdfSaxkkPkx4ejTKmBbYT8oSea++3CTJCwLfuiiF2931Xoe65PQFoLwQQyFemd ow5SprJDucD8/tpam+S4O3255WllfhvGNEHxQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678907621; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o2vvuKdrAdXp+gajox/gt3z2jdSyI7VaN2kE9Je49nw=; b=Lx49GVpIIhOp9OLHkvOzzit2AZ4mdSk0+zxzPwu2AAEvQRrHGEbVwjOWkVjj/Vs762 LRzRqF/JCxqPmFdrfGz7H6NPwhypAZUV7OGILmdSA8kDtM7WIWou3XJdib+ftJYrDsu/ nGAhxXQ5FvixWGr2ZjaGHve27C+FDzzfF8dhcpyrzi+hpI2w7PNd16eKxhc1E4uGwwWz 8Dt8xX8AMsNlBd9R4ElJbYEd4QZqzKKppi+jM/ttdlxByFFNr49JoIZlRwyN/Fzdr9Rq G7j4smUnQ3UrPqTVDOJluRDMXG+vec0OLqwQvimptAsjbUlqQMv7cIgshMo+hkqc8HsO m1Ew== X-Gm-Message-State: AO0yUKXWXgkJuXgB48yf5Xrpy8WRypPRvTQPVNdKEEa6c3HVOqjQS1J/ Q1Dt50Hc0jFNDuQqmmvHJKj5nN3XPqqwAqjOLMJiIA== X-Google-Smtp-Source: AK7set8SeAr+jOS9mCNDS1eOHPEhCl73l4UClaFc5oBCTvM/0ESzekDNsn9lqCUiDhCzml1MgPRswwhysy+Ye/MsHBE= X-Received: by 2002:a05:6870:4986:b0:177:af9a:eb5d with SMTP id ho6-20020a056870498600b00177af9aeb5dmr4628946oab.1.1678907621469; Wed, 15 Mar 2023 12:13:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Patrick Robb Date: Wed, 15 Mar 2023 15:13:30 -0400 Message-ID: Subject: Re: Meson buildtype for ci jobs? To: "Richardson, Bruce" Cc: David Marchand , "ci@dpdk.org" , Aaron Conole , Thomas Monjalon Content-Type: multipart/alternative; boundary="0000000000006383b205f6f524e5" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --0000000000006383b205f6f524e5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > Would passing "-Ddebug=3Dtrue" be better than changing the default buildt= ype? > It's possible to have a release build (i.e. O3 optimized) with debug info= . > Strangely, even with -Ddebug true if I'm running buildtype "release" it returns the same warnings. I'm inferring from your comment that release optimization =3D=3D debugoptimized optimization and debug behavior from -Ddebug=3Dtrue =3D=3D debug behavior from debugoptimized, so release buildt= ype + debug "should" have the same behavior as just setting buildtype debugoptimized, and yet... I'll have to look into this a little more. Hopefully by the end I'll be like David and understand the relations between these flags better, hah. On Wed, Mar 15, 2023 at 1:02=E2=80=AFPM Richardson, Bruce < bruce.richardson@intel.com> wrote: > > > > -----Original Message----- > > From: David Marchand > > Sent: Wednesday, March 15, 2023 4:08 PM > > To: Patrick Robb > > Cc: ci@dpdk.org; Aaron Conole ; Richardson, Bruce > > ; Thomas Monjalon > > Subject: Re: Meson buildtype for ci jobs? > > > > On Wed, Mar 15, 2023 at 4:52=E2=80=AFPM Patrick Robb wrote: > > > > > > Hello all, > > > > > > The lab recently received a request to re-enable Alpine compile jobs, > > which have been disabled for almost a year. In dry running the compile > > job, I noticed that it was failing. At the same time, David Marchand di= d > > an Alpine compile with Github Actions which was successful. It seems th= e > > source of the different behavior is the meson buildtype being used - th= e > > build script used by GHA sets meson buildtype to debugoptimized, wherea= s > > the script used by the community lab runs with buildtype debug (the mes= on > > default). I did my own Github Actions runs (with both buildtype options= ) > > to sanity check: > > > https://github.com/PatrickRobbIOL/dpdk/actions/runs/4427160204/jobs/77643= 6 > > 8640 > > > > Are you sure about the default value? > > > > Afaics, meson selects by default a "release" buildtype (and I think I > > always saw this value in the past). > > I have this with meson 1.0. > > > > $ meson setup qsdlgfh > > ... > > $ meson configure qsdlgfh | grep buildtype > > buildtype release > > [plain, debug, debugoptimized, Build type to use > > > > > > > > The reason I'm writing this email is that I'm wondering whether the > > buildtype decision made by those who wrote .ci/linux-build.sh for GHA w= as > > intentional and important. I know many of the people who have commits o= n > > that script follow this mailing list. Obviously if it's in some way mor= e > > appropriate for CI purposes to run meson setup in this way, I'm happy t= o > > make that change at the lab and in the process that would free up > bringing > > Alpine compile testing online. But, if not, then I think it's most > > appropriate to consider compile on Alpine as broken and avoid bringing > > coverage for Alpine online until that issue is resolved. > > > > The reason why we went with debugoptimized was primarly for the ABI > > checks, as by default, the debug symbols were missing (which would > > match with a "release" default buildtype). > > See 777014e56d07 ("devtools: add ABI checks"). > > > > Would passing "-Ddebug=3Dtrue" be better than changing the default buildt= ype? > It's possible to have a release build (i.e. O3 optimized) with debug info= . > > /Bruce > --=20 Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --0000000000006383b205f6f524e5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Would pa= ssing "-Ddebug=3Dtrue" be better than changing the default buildt= ype?
It's possible to have a release build (i.e. O3 optimized) with = debug info.

Strangely, even with -Ddebu= g true if I'm running buildtype "release" it returns the same= warnings. I'm inferring from your comment that release optimization = =3D=3D debugoptimized=C2=A0optimization and debug behavior from -Ddebug=3Dt= rue =3D=3D debug behavior from debugoptimized, so release buildtype=C2=A0+ = debug "should"=C2=A0have the same behavior as just setting buildt= ype debugoptimized, and yet...

I'll have to lo= ok into this a little more. Hopefully by the end I'll be like David and= understand the relations between these flags better, hah.

<= div class=3D"gmail_quote">
On Wed, Mar= 15, 2023 at 1:02=E2=80=AFPM Richardson, Bruce <bruce.richardson@intel.com> wrote:


> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, March 15, 2023 4:08 PM
> To: Patrick Robb <probb@iol.unh.edu>
> Cc: ci@dpdk.org; = Aaron Conole <ac= onole@redhat.com>; Richardson, Bruce
> <br= uce.richardson@intel.com>; Thomas Monjalon <thomas@monjalon.net>
> Subject: Re: Meson buildtype for ci jobs?
>
> On Wed, Mar 15, 2023 at 4:52=E2=80=AFPM Patrick Robb <probb@iol.unh.edu> wrote:<= br> > >
> > Hello all,
> >
> > The lab recently received a request to re-enable Alpine compile j= obs,
> which have been disabled for almost a year. In dry running the compile=
> job, I noticed that it was failing. At the same time, David Marchand d= id
> an Alpine compile with Github Actions which was successful. It seems t= he
> source of the different behavior is the meson buildtype being used - t= he
> build script used by GHA sets meson buildtype to debugoptimized, where= as
> the script used by the community lab runs with buildtype debug (the me= son
> default). I did my own Github Actions runs (with both buildtype option= s)
> to sanity check:
> https://github.com/Pa= trickRobbIOL/dpdk/actions/runs/4427160204/jobs/776436
> 8640
>
> Are you sure about the default value?
>
> Afaics, meson selects by default a "release" buildtype (and = I think I
> always saw this value in the past).
> I have this with meson 1.0.
>
> $ meson setup qsdlgfh
> ...
> $ meson configure qsdlgfh | grep buildtype
>=C2=A0 =C2=A0buildtype=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 release
> [plain, debug, debugoptimized,=C2=A0 =C2=A0Build type to use
>
> >
> > The reason I'm writing this email is that I'm wondering w= hether the
> buildtype decision made by those who wrote .ci/linux-build.sh for GHA = was
> intentional and important. I know many of the people who have commits = on
> that script follow this mailing list. Obviously if it's in some wa= y more
> appropriate for CI purposes to run meson setup in this way, I'm ha= ppy to
> make that change at the lab and in the process that would free up brin= ging
> Alpine compile testing online. But, if not, then I think it's most=
> appropriate to consider compile on Alpine as broken and avoid bringing=
> coverage for Alpine online until that issue is resolved.
>
> The reason why we went with debugoptimized was primarly for the ABI > checks, as by default, the debug symbols were missing (which would
> match with a "release" default buildtype).
> See 777014e56d07 ("devtools: add ABI checks").
>

Would passing "-Ddebug=3Dtrue" be better than changing the defaul= t buildtype?
It's possible to have a release build (i.e. O3 optimized) with debug in= fo.

/Bruce


--

Patrick Robb

<= span style=3D"font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-= color:transparent;vertical-align:baseline;white-space:pre-wrap">Technical S= ervice Manager

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

www.iol.unh.edu


--0000000000006383b205f6f524e5--