From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ci-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E920E45695; Tue, 23 Jul 2024 17:37:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E145E42EE9; Tue, 23 Jul 2024 17:37:01 +0200 (CEST) Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) by mails.dpdk.org (Postfix) with ESMTP id 81F9E427D9 for <ci@dpdk.org>; Tue, 23 Jul 2024 17:36:57 +0200 (CEST) Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5c6661bca43so2886384eaf.0 for <ci@dpdk.org>; Tue, 23 Jul 2024 08:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1721749017; x=1722353817; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=X7+N+Q4Qw90QMrGWwECYNk1PQkNid4KBK/4mYF0ODkg=; b=TxKaWrnfvUvrUMBJubQ8qwzTXCka7wOm8a2e60GgJDXHIWw7uSCPI7u0mq/L7QuPIV KcG/ZQc6111OqAqYY7E6/c0DD6aI2CgsV03oWHRb99+3Xb53fTKK/nFYCRvqhHRlvFfk pjURHea0eM+mtfVT4sXcxTWBua6i8TLB8dExc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721749017; x=1722353817; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X7+N+Q4Qw90QMrGWwECYNk1PQkNid4KBK/4mYF0ODkg=; b=Q/LVQ1+dvxJnF6MNWLe11Nj3FiDSifORF+K678A37UZJ3KQ7uKNE03K7wPGzIhZ6AE 2zn47l2MOkjUMjlkzu5HB4oWPHUqH5W4NcY5Lxc5CbLdB3p0Bhwbtw2oSqF7+97bjJS0 +gt7EMA9ZGvTzZZkgC9D4PpMT2Jo5YTqlV0ag1rWL2GBpeD9svttNMMoR622lZCWitQX 476GUBQQmRcbQieEOdM5PIXbb0sctVHimPvIS+ShhIUrnrTVnzPCoQAlEvBaOBlr3mN+ WEOxIIplQdLcd4GmAEcvTgEO1sRQ8ZXZe+6ZbZ6NaQy/lsOqCRz31NToJuWXFL7IQJe3 ER5A== X-Forwarded-Encrypted: i=1; AJvYcCUi+1OTFCUdwAyz+z4tML9DcZ9Ox4g65S9+IT41TbHNGIbeGIesrqpKtAfo0eKEGq+ytVX5U46pJeooHA== X-Gm-Message-State: AOJu0YyKbkvggFhkbsdAHZQiXEAf46mJEh9u5U8h02Cz8YXr7ve3fxO3 JDI+ZQcn+ooC62alhbeOytI+9L045FKRgnoAHN9R0VxSPzn8i2G18RFVhhUUeN2HnijeHD3P1Ln 17X3zx42svLEMOhx+c1WSRVoIlcnyI97nmfZgkQ== X-Google-Smtp-Source: AGHT+IGjPdiyk6a1CKjuWJgZ5dfyCfUB++Jg8g56Wmfk1esAJvgUSw9Ys7GQE31uus2QY1BqH7+l03xflFQuENNa9rw= X-Received: by 2002:a05:6820:1e01:b0:5c4:2497:c92d with SMTP id 006d021491bc7-5d564e497femr13619664eaf.2.1721749016723; Tue, 23 Jul 2024 08:36:56 -0700 (PDT) MIME-Version: 1.0 References: <CAC-YWqhFpn5zrZsJ_R6sUehH1FzSWpuRFpgQ-CRaG5p8NrHAbQ@mail.gmail.com> <CAJvnSUAi0SbZ_LRyX3R+i=RL4QBK0jQYJtrW2yHEQ+pLJ0ggxQ@mail.gmail.com> <4881077.GXAFRqVoOG@thomas> <f7t1q7c7zko.fsf@redhat.com> <CAJvnSUBfTTk8mvLHcZLyVjTebS+8M+u=Vb24=2r_SBVyD-KDnw@mail.gmail.com> <CAC-YWqhOsjumfsmvuCv=HbA0MrpoKfpj-K7L6fQKUV_tWwPzMg@mail.gmail.com> <76332523-96ac-407d-b937-c1f8a99808fa@amd.com> <CAC-YWqgS-tDrY8Q90uexPkvJiGttNW+FOBeedNi1MRT4Wu7vLQ@mail.gmail.com> <CAJvnSUCcCM1WYuyoArYAEyUFtL5O4BKKcndRN-yNC_tJvwTzVg@mail.gmail.com> <6b425d90-78b2-497b-958c-9d36e2ba6e3b@amd.com> In-Reply-To: <6b425d90-78b2-497b-958c-9d36e2ba6e3b@amd.com> From: Patrick Robb <probb@iol.unh.edu> Date: Tue, 23 Jul 2024 11:36:45 -0400 Message-ID: <CAJvnSUB6MzBQ=bdzjZRYpwjt2nAewYvdptcpyy_u1k2K=sA-Zw@mail.gmail.com> Subject: Re: Adding Series Dependency to Patchwork To: Ferruh Yigit <ferruh.yigit@amd.com> Cc: Adam Hassick <ahassick@iol.unh.edu>, ci@dpdk.org, Aaron Conole <aconole@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions <ci.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/ci>, <mailto:ci-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/ci/> List-Post: <mailto:ci@dpdk.org> List-Help: <mailto:ci-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/ci>, <mailto:ci-request@dpdk.org?subject=subscribe> Errors-To: ci-bounces@dpdk.org On Tue, Jul 23, 2024 at 11:31=E2=80=AFAM Ferruh Yigit <ferruh.yigit@amd.com= > wrote: > > On 7/22/2024 5:28 PM, Patrick Robb wrote: > > On Mon, Jul 22, 2024 at 12:15=E2=80=AFPM Adam Hassick <ahassick@iol.unh= .edu> wrote: > > > >>> If we go with the URL option, does is still required to differentiate= as > >>> "patch-xxx" or "series-yyy", previously they were different IDs, but > >>> with URL can patchwork deduce if it is series or patch? If so this ca= n > >>> bring a simplification. > >> > >> No, you can just paste the URL and the Django URL resolver will figure > >> out whether it points at a patch or a series. No need to differentiate > >> with the URLs. > >> > >> That's also true of the message ID option too. There isn't much of a > >> point in differentiating patch/series message IDs because series do > >> not reliably have an email associated with them. > > > > Sounds good. I want to highlight again for the ci group that all > > dependencies will be series dependencies, regardless of whether > > "patch-xxx" or "series-yyy" is used. If a patch message id or url is > > submitted, it will be mapped to its series url for the dependency. > > > > Are you planning to keep the 'patch' or 'series' part, why not change > the syntax as: > > Depends-on: <message-ID> > or > Depends-on: <patchwork URL> > Good point. Yes, there is no reason to keep the "patch" or "series" prefix to the value. > > And is there a benefit to support both "message-ID" and "patchwork URL", > so why not just: > Depends-on: <patchwork URL> > Maybe Adam can answer, but I think his intention was to support both formats, to provide more flexibility for users.