> > Patrick, are [1/3] and [2/3] still needed as well? > Yes please on both. We are currently using 1/3 in our Jenkins process for including tag arguments in creating the execution file. Thanks for raising this. On Wed, Jun 21, 2023 at 11:19 AM Ali Alnubani wrote: > > -----Original Message----- > > From: Ali Alnubani > > Sent: Monday, February 7, 2022 5:56 PM > > To: ohilyard@iol.unh.edu; ci@dpdk.org > > Subject: RE: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by > empty diff > > > > > -----Original Message----- > > > From: ohilyard@iol.unh.edu > > > Sent: Monday, February 7, 2022 5:08 PM > > > To: ci@dpdk.org; Ali Alnubani > > > Cc: Owen Hilyard > > > Subject: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty > diff > > > > > > From: Owen Hilyard > > > > > > A sanity check has been added to find_filenames. Occasionally, due to > > > how the community lab internally handles getting patches from > > > patchworks, a patch will result in no diff. This patch adds handling > for > > > this case. > > > > > > Signed-off-by: Owen Hilyard > > > --- > > > > Thanks Owen. > > > > Tested-by: Ali Alnubani > > Acked-by: Ali Alnubani > > Hi Thomas and Aaron, > > Can we merge this patch? Pull requests can still cause the script to crash > because they have an empty diff. > > Patrick, are [1/3] and [2/3] still needed as well? > > Thanks, > Ali > -- Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu