From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F67C42D15 for ; Wed, 21 Jun 2023 17:40:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3736B4068E; Wed, 21 Jun 2023 17:40:05 +0200 (CEST) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by mails.dpdk.org (Postfix) with ESMTP id B4C354003C for ; Wed, 21 Jun 2023 17:40:04 +0200 (CEST) Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-3a034e628fcso1707782b6e.1 for ; Wed, 21 Jun 2023 08:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1687362004; x=1689954004; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lCy9go7Uchdok5ri/2LqTaoo6Q6ynUKkzHTPbX/GpnA=; b=LcWMWdff6tbrH0Bai69+VDg0wP3PzBgwBd38j7LA/RZ6+taMgsHDMWpARn3n3BLFCb Ve7KFb4rrasAKeJmub5pPDzerwRatXeEOWwQF5+r0CyYyWjRRd8vJRC9MOG8J9AMunU8 dM3UtaZOCEEvVPq3pt9nAOOdjVLQZjuL+/5lw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687362004; x=1689954004; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lCy9go7Uchdok5ri/2LqTaoo6Q6ynUKkzHTPbX/GpnA=; b=eNGMr74tgPyjRBxFazRNfH9p/31HcXGMFmbSqyH2EeuG9HhIp/Ac8yIbajv/6sWyaP EDPowDz09TAn2Iha6cBxwDgbrv1Igp77RjJS8wAi7iM6q3LkVSZUGVo7Ux+cptM3GlZR gr0ncQmgsfuf0L4btbPPza56VRR4uiwyopVNkSHaomAsuJgPMCCgs4BtsqR4GsWKKsnA LmbgJZO0QIrErbw0JlD0BrOAlEzWWPOdvdCGCoWeDzjbBqis3s+2KAPyPpzFoFSgy+Pp cySJAEbQcM4J6+G3h/Dau+I4OchNUUqblhcR/hvuPzg5tbjmlChyxraN32IRG32qT7qQ 8iRg== X-Gm-Message-State: AC+VfDzhFpK3jPqR+301Cws0V4loVU9Msi3a8KtU2/FS46LxPop0Yv/d AFDPTHF4v59eoChNZ4ZmsKP8noiRNWkPFg4m4XXOKA== X-Google-Smtp-Source: ACHHUZ45/N76XKAymyLdnreDXUVDSabaX9e4I+wfwH4BZs6UrVPzZknODQUdnv51e0D7RpOGgoty5kJXEhj+6Mw3zmM= X-Received: by 2002:aca:bc55:0:b0:39c:bfd0:76cb with SMTP id m82-20020acabc55000000b0039cbfd076cbmr10942733oif.9.1687362004038; Wed, 21 Jun 2023 08:40:04 -0700 (PDT) MIME-Version: 1.0 References: <20220207150826.18950-1-ohilyard@iol.unh.edu> <20220207150826.18950-3-ohilyard@iol.unh.edu> In-Reply-To: From: Patrick Robb Date: Wed, 21 Jun 2023 11:39:53 -0400 Message-ID: Subject: Re: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff To: Ali Alnubani Cc: "ci@dpdk.org" , Aaron Conole , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "ohilyard@iol.unh.edu" Content-Type: multipart/alternative; boundary="000000000000dbd19905fea59486" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --000000000000dbd19905fea59486 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > Patrick, are [1/3] and [2/3] still needed as well? > Yes please on both. We are currently using 1/3 in our Jenkins process for including tag arguments in creating the execution file. Thanks for raising this. On Wed, Jun 21, 2023 at 11:19=E2=80=AFAM Ali Alnubani = wrote: > > -----Original Message----- > > From: Ali Alnubani > > Sent: Monday, February 7, 2022 5:56 PM > > To: ohilyard@iol.unh.edu; ci@dpdk.org > > Subject: RE: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by > empty diff > > > > > -----Original Message----- > > > From: ohilyard@iol.unh.edu > > > Sent: Monday, February 7, 2022 5:08 PM > > > To: ci@dpdk.org; Ali Alnubani > > > Cc: Owen Hilyard > > > Subject: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty > diff > > > > > > From: Owen Hilyard > > > > > > A sanity check has been added to find_filenames. Occasionally, due to > > > how the community lab internally handles getting patches from > > > patchworks, a patch will result in no diff. This patch adds handling > for > > > this case. > > > > > > Signed-off-by: Owen Hilyard > > > --- > > > > Thanks Owen. > > > > Tested-by: Ali Alnubani > > Acked-by: Ali Alnubani > > Hi Thomas and Aaron, > > Can we merge this patch? Pull requests can still cause the script to cras= h > because they have an empty diff. > > Patrick, are [1/3] and [2/3] still needed as well? > > Thanks, > Ali > --=20 Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --000000000000dbd19905fea59486 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Patrick,= are [1/3] and [2/3] still needed as well?
Yes please = on both. We are currently using 1/3 in our Jenkins process for including=C2= =A0tag arguments in creating the execution file. Thanks for raising this.

=C2=A0

On Wed, Jun 21, 2023 at 11:19=E2=80= =AFAM Ali Alnubani <alialnu@nvidia= .com> wrote:
> -----Original Message-----
> From: Ali Alnubani <alialnu@nvidia.com>
> Sent: Monday, February 7, 2022 5:56 PM
> To: ohilyard= @iol.unh.edu; ci@dpdk.= org
> Subject: RE: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by em= pty diff
>
> > -----Original Message-----
> > From: o= hilyard@iol.unh.edu <ohilyard@iol.unh.edu>
> > Sent: Monday, February 7, 2022 5:08 PM
> > To: ci@dpdk.org<= /a>; Ali Alnubani <alialnu@nvidia.com>
> > Cc: Owen Hilyard <ohilyard@iol.unh.edu>
> > Subject: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by e= mpty diff
> >
> > From: Owen Hilyard <ohilyard@iol.unh.edu>
> >
> > A sanity check has been added to find_filenames. Occasionally, du= e to
> > how the community lab internally handles getting patches from
> > patchworks, a patch will result in no diff. This patch adds handl= ing for
> > this case.
> >
> > Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> > ---
>
> Thanks Owen.
>
> Tested-by: Ali Alnubani <alialnu@nvidia.com>
> Acked-by: Ali Alnubani <alialnu@nvidia.com>

Hi Thomas and Aaron,

Can we merge this patch? Pull requests can still cause the script to crash = because they have an empty diff.

Patrick, are [1/3] and [2/3] still needed as well?

Thanks,
Ali


--

Patrick Robb

<= span style=3D"font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-= color:transparent;vertical-align:baseline;white-space:pre-wrap">Technical S= ervice Manager

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

www.iol.unh.edu


--000000000000dbd19905fea59486--