From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFD0B42E63; Thu, 13 Jul 2023 17:30:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAE234114A; Thu, 13 Jul 2023 17:30:19 +0200 (CEST) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by mails.dpdk.org (Postfix) with ESMTP id 6DF0640DDA for ; Thu, 13 Jul 2023 17:30:18 +0200 (CEST) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1b06777596cso716786fac.2 for ; Thu, 13 Jul 2023 08:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1689262217; x=1691854217; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JlVTR7NnDitoEJOCRNaUQl0bImVvgeblsNGv95M7CX4=; b=LibF497pHjHcrpb97YEbx/give3RWILW2r1yB1AJn/lFxdK6UHfykLAtMOkvDI1om7 nPuauG+2sARtO7EUt0UEq6Uf/wZOXR62Bc9dllTLS5L3KvgeRu0MJmnfC/iYkkwilKyS yGyIy8lUKipOGfDx5qbuuuRPsDfa0YjHbeOlY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689262217; x=1691854217; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JlVTR7NnDitoEJOCRNaUQl0bImVvgeblsNGv95M7CX4=; b=bssizOas6UDwkbBnzEEG51hQDwFl4BurvLLwFBJCTeXLbv7bHHUNdV3dhoYwq4+Pfz 3AhNcCrlKrqhkUXe6/jpn+0NldCeHjdS9zqLS7bhTaux4ivpZKakxQqMQKcwJPHMdwPc jdLwAuR1JmazxN7sxssabdOeEhpwhpSe7HQTf/DGQ4FObeDUfOz194/uGqq8yrlm/6Dv Xnc7vm18CLN5wNawS7Zlu1qPWerhnmaTQxXoC1iM5eKzKcvUIlFko12h9dl4naLUbpWB vpcDNM6gHqjmNahEjLyIoND2TrK8T35J/8X9u/o0KispI80gfhKU8nAY0JQcQaMUKPd5 S0zg== X-Gm-Message-State: ABy/qLahVj+ulD4O0+0FExXECybUwYmxAOLxXUvQpsc8c0KmuLumSVRd d1g40hBQDi8BDxnXZcFI1SuHL/fFQ05676Ng/QBIPQ== X-Google-Smtp-Source: APBJJlFPUnE94oVwUN7djdBcbHiGXs++VaUizCbDhAV70k6oqv/TJADNMBH9SEmcT2evS7zoSw9FxyIcgYFyGKjXKJY= X-Received: by 2002:a05:6870:8903:b0:1b0:1a03:b345 with SMTP id i3-20020a056870890300b001b01a03b345mr2724499oao.4.1689262217658; Thu, 13 Jul 2023 08:30:17 -0700 (PDT) MIME-Version: 1.0 References: <4eb5d073-929f-e5f0-c490-763d3aacf196@amd.com> <722271b4-169d-f828-dd84-39af6ae377aa@amd.com> In-Reply-To: <722271b4-169d-f828-dd84-39af6ae377aa@amd.com> From: Patrick Robb Date: Thu, 13 Jul 2023 11:30:06 -0400 Message-ID: Subject: Re: Failing kernel module tests and test frequency question To: Ferruh Yigit Cc: David Marchand , Thomas Monjalon , ci@dpdk.org Content-Type: multipart/alternative; boundary="0000000000006a972f0600600208" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --0000000000006a972f0600600208 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello I see the test is passing now. Thank you Ferruh! On Thu, Jul 13, 2023 at 4:56=E2=80=AFAM Ferruh Yigit = wrote: > On 7/11/2023 11:12 AM, Ferruh Yigit wrote: > > On 7/6/2023 8:42 PM, Ferruh Yigit wrote: > >> On 7/6/2023 6:50 PM, Patrick Robb wrote: > >>> Hello, > >>> > >>> I am seeing our kmods testcase fail on the daily periodic run since > June > >>> 29: > https://dpdkdashboard.iol.unh.edu/results/dashboard/tarballs/25226/ > >>> > >>> > >>> It does coincide with a slew of patches being merged for rc2. But, I > >>> haven't looked at those patches individually, and I also don't know > >>> whether we generally expect breakages for this kernel module compile > job > >>> to come from dpdk patches or from patches on the linux kernel project= . > >>> > >>> I understand that the original/current plan was for running the kerne= l > >>> module test 1x/day. The question this raises for me is, if we were ab= le > >>> to afford expending the needed compute resources for kmod compile > >>> testing on all incoming patchseries, would that be a valuable additio= n, > >>> or not? > >>> > >>> Thanks, > >>> Patrick > >>> > >> > >> Hi Patrick, > >> > >> It is KNI build failure with latest kernel because of an kernel API > >> change, I am aware of it an have a local patch to fix. > >> > >> But fix requires kernel version check (to detect correct API) and sinc= e > >> kernel is in the 6.5 merge window and -rc1 is not out, current version > >> is still 6.4 and version control is not working as expected. > >> In my local patch I am using 6.4 for version check but that is wrong a= nd > >> not suitable for an upstream patch. > >> > >> That is why can you pause the 'dpdk_kmod_compile_torvalds_linux' test > >> until v6.5-rc1 is out, it shouldn't take long. > >> > > > > I have sent following patch, can you please test: > > > https://patches.dpdk.org/project/dpdk/patch/20230711100941.2082191-1-ferr= uh.yigit@amd.com/ > > > > You can enable test and use patch locally until it is merged to main > repo. > > > > Fix merged for -rc3, so test should be OK now. > > --=20 Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu --0000000000006a972f0600600208 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello I see the test is passing now. Thank you Ferruh!
On T= hu, Jul 13, 2023 at 4:56=E2=80=AFAM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
On 7/11/2023 11:12 AM, Ferruh Yigit w= rote:
> On 7/6/2023 8:42 PM, Ferruh Yigit wrote:
>> On 7/6/2023 6:50 PM, Patrick Robb wrote:
>>> Hello,
>>>
>>> I am seeing our kmods testcase fail on the daily periodic run = since June
>>> 29:=C2=A0https://dpd= kdashboard.iol.unh.edu/results/dashboard/tarballs/25226/
>>> <https://dpdkdash= board.iol.unh.edu/results/dashboard/tarballs/25226/>
>>>
>>> It does coincide with a slew of patches being merged for rc2. = But, I
>>> haven't looked at those patches individually, and I also d= on't know
>>> whether we generally expect breakages for this kernel module c= ompile job
>>> to come from dpdk patches or from patches on the linux kernel = project.
>>>
>>> I understand that the original/current plan was for running th= e kernel
>>> module test 1x/day. The question this raises for me is, if we = were able
>>> to afford expending the needed compute resources for kmod comp= ile
>>> testing on all incoming patchseries, would that be a valuable = addition,
>>> or not?=C2=A0
>>>
>>> Thanks,
>>> Patrick
>>>
>>
>> Hi Patrick,
>>
>> It is KNI build failure with latest kernel because of an kernel AP= I
>> change, I am aware of it an have a local patch to fix.
>>
>> But fix requires kernel version check (to detect correct API) and = since
>> kernel is in the 6.5 merge window and -rc1 is not out, current ver= sion
>> is still 6.4 and version control is not working as expected.
>> In my local patch I am using 6.4 for version check but that is wro= ng and
>> not suitable for an upstream patch.
>>
>> That is why can you pause the 'dpdk_kmod_compile_torvalds_linu= x' test
>> until v6.5-rc1 is out, it shouldn't take long.
>>
>
> I have sent following patch, can you please test:
> https= ://patches.dpdk.org/project/dpdk/patch/20230711100941.2082191-1-ferruh.yigi= t@amd.com/
>
> You can enable test and use patch locally until it is merged to main r= epo.
>

Fix merged for -rc3, so test should be OK now.



--

Patrick Robb

<= span style=3D"font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-= color:transparent;vertical-align:baseline;white-space:pre-wrap">Technical S= ervice Manager

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

www.iol.unh.edu


--0000000000006a972f0600600208--