From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9776643885; Wed, 10 Jan 2024 19:56:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91B254025E; Wed, 10 Jan 2024 19:56:30 +0100 (CET) Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by mails.dpdk.org (Postfix) with ESMTP id 851124021E for ; Wed, 10 Jan 2024 19:56:29 +0100 (CET) Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3bbd1fab171so3265996b6e.1 for ; Wed, 10 Jan 2024 10:56:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1704912989; x=1705517789; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=onZ2bWA0QcrvKi8qABXkJKCzuMM8n7wA4v17EuEnjTQ=; b=XX3dUmA2bd7WQfIR6i05LZbm5aj7NIjYL4WyBiNM1HmsPn/wR59d8mlG2juZjWMJvm pHpj0FvR7wgvKIQGeAPW+G8bLWEZgvJ9BPQDpyi/RkHr3T9YKwcUn8f9YMvYoxVBkVqR Yk+q1XNxMuKVfjxFp5N4DwsCkGGNKkrXaVsOI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704912989; x=1705517789; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=onZ2bWA0QcrvKi8qABXkJKCzuMM8n7wA4v17EuEnjTQ=; b=UjZBKH+OuSH15VD3ca39+YtrweAoQuOO3/F0o5HIQA05LndgWjxa3v+jxOzFbJGzEt 1RYElnJADu9zh4RJ7XydleS935r3xclm4Cvwo39KhWoNCx+ujhuNvS0pbB3gPEX4UtED LBE2R9wftobamVz0KN8xdd5GKTUGgKgprCaDYVJXUCAX9dfgWb9g14Wo5y1PG0bloS/S t152QaFQxl1hXSH0vkQJZLHLNwWMDM0YacYJiD+JS6RzktZyzzzCXvSN3oXVUPfY2SPG 2v7rpxi6I29HdWYZfSfKhVFNh+01FyhPwxRRZauB9kS+YG96BsUdqD+VtpjwKNFS83DM vUVw== X-Gm-Message-State: AOJu0Ywuf2iG3s/nOUN+PDRipjf6iRodrEmrJf0OVzEZLQgTgyb0ltgu m3XfTF6mV/3ue1tm5NIXHZNPyknHtOYc+qJXMIGBQoxtcIwIjQ== X-Google-Smtp-Source: AGHT+IGdAqTj4G2xS4uAZXm3DuCt0j5sdz/e++0X+9vmFSa1BOI65Q0MNDbdSGFC6Bub9pSN3ecsJ8VK2GGPRo/B06E= X-Received: by 2002:a05:6808:1295:b0:3bb:bc6c:23d2 with SMTP id a21-20020a056808129500b003bbbc6c23d2mr52897oiw.111.1704912988826; Wed, 10 Jan 2024 10:56:28 -0800 (PST) MIME-Version: 1.0 References: <20240110145715.28157-1-ahassick@iol.unh.edu> <20240110145715.28157-2-ahassick@iol.unh.edu> In-Reply-To: From: Patrick Robb Date: Wed, 10 Jan 2024 13:56:17 -0500 Message-ID: Subject: Re: [PATCH 1/2] tools: Add script to create artifacts To: Aaron Conole Cc: Adam Hassick , ci@dpdk.org, alialnu@nvidia.com Content-Type: multipart/alternative; boundary="0000000000001284a0060e9bfd73" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --0000000000001284a0060e9bfd73 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 10, 2024 at 11:54=E2=80=AFAM Aaron Conole = wrote: > Adam Hassick writes: > > > This script takes in a URL to a series on Patchwork and emits a > > tarball which may be used for running tests. > > > > Signed-off-by: Adam Hassick > > --- > > Just a quick glance. > > Is it possible to include a doc on how it is expected to run this > script? Maybe that could help to also evaluate it as well. > I was thinking along similar lines when I ran the script, but to a certain extent it seemed like having helpful examples in the config file would clear up confusion. Nevertheless, I think it's certainly worth writing the process down a little more. I wonder should we instead follow the example of pw_maintainers_cli.py and have the example usage, how to run, etc. written as a string at the top of the file? Then we are consistent with how other scripts in the repo are operating. --0000000000001284a0060e9bfd73 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jan 10, 2024 at 11:54=E2=80= =AFAM Aaron Conole <aconole@redhat= .com> wrote:
Adam Hassick <ahassick@iol.unh.edu> writes:

> This script takes in a URL to a series on Patchwork and emits a
> tarball which may be used for running tests.
>
> Signed-off-by: Adam Hassick <ahassick@iol.unh.edu>
> ---

Just a quick glance.

Is it possible to include a doc on how it is expected to run this
script?=C2=A0 Maybe that could help to also evaluate it as well.

I was thinking along similar lines when I ran the= script, but to a certain extent it seemed like having helpful examples in = the config file would clear up confusion. Nevertheless, I think it's ce= rtainly worth writing the process down a little more. I wonder should we in= stead follow the example of pw_maintainers_cli.py and have the example usag= e, how to run, etc. written as a string at the top of the file? Then we are= consistent with how other scripts in the repo are operating.
--0000000000001284a0060e9bfd73--