DPDK CI discussions
 help / color / mirror / Atom feed
From: Patrick Robb <probb@iol.unh.edu>
To: ci@dpdk.org
Subject: Apply Patchseries Script
Date: Wed, 27 Sep 2023 12:31:22 -0400	[thread overview]
Message-ID: <CAJvnSUCrsimWMy-nDpycc_me65RGFH9v4HS-VotoMtqhcvzSkA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2050 bytes --]

Hello all,

The Community Lab is reviewing and rewriting some parts of our (currently
internal) apply patchseries script. The reasons are:

1. We want to remove any dependency the apply script has on our internal
infrastructure, so that it can be upstreamed and utilized by others in the
community.

2. We want to add in new features like “depends-on patch” applying (like
ovsrobot is doing currently)

3. Some DPDK project processes have changed (like moving next branches from
the main repo to being their own distinct repos). We have added on
workarounds along the way to account for this, but an overall rework is now
in order to clean up our process.

Before we do the work and attempt to upstream the script, I want to verify
with the community that our current assumptions regarding the apply
patchseries process are appropriate and should not be tweaked. Assumptions:

1. There are two inputs, A. The pw series url and B. The branch output of
pw_maintainers_cli.py

2. Do not apply and run if the series is an RFC series

3. Always check out to the current head of tree when applying a patch,
regardless of whether the tree state has changed between patch submission
and patch application in CI.

4. If the cover letter contains “depends-on,” extract the dependency series
id(s), apply those, then attempt to apply the patch

5. If patch does not cleanly apply to the branch supplied by
pw_maintainers_cli.py, attempt to apply on dpdk main. If this also fails,
report an apply failure.

6. If apply is successful, attempt a sanity build, and report a build
failure if that fails. If it succeeds, proceed with all CI testing.

Note: The Community Lab does not currently use pw-client. If it is better
for the CI community, we could stop maintaining a dedicated script for the
apply process, try moving the pw-client, and direct our efforts at patching
pw-client with the goal of adding support for features like depends-on. Are
other labs using pw-client right now and do you recommend it?

[-- Attachment #2: Type: text/html, Size: 8994 bytes --]

             reply	other threads:[~2023-09-27 16:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27 16:31 Patrick Robb [this message]
2023-09-27 20:22 ` Thomas Monjalon
2023-09-28  0:16   ` Patrick Robb
2023-09-28 12:05     ` Aaron Conole
2023-09-28 12:31       ` David Marchand
2023-09-28 12:06   ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJvnSUCrsimWMy-nDpycc_me65RGFH9v4HS-VotoMtqhcvzSkA@mail.gmail.com \
    --to=probb@iol.unh.edu \
    --cc=ci@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).