From: Patrick Robb <probb@iol.unh.edu>
To: Manit Mahajan <mmahajan@iol.unh.edu>
Cc: ci@dpdk.org, thomas@monjalon.net, aconole@redhat.com,
bruce.richardson@intel.com
Subject: Re: [PATCH] tools: run check-meson.py in create_series_artifact
Date: Tue, 15 Oct 2024 18:26:33 -0400 [thread overview]
Message-ID: <CAJvnSUCzxLLt_nP3g6cAqQvO8mCS2JVuG+AFiF0XPmEFMMbGtQ@mail.gmail.com> (raw)
In-Reply-To: <20241015213211.587-1-mmahajan@iol.unh.edu>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
Looks good, thanks Manit.
I know we have discussed this in person, but I'll just flag here that
obviously in building our check-meson CI testing usage around parsing the
human readable stdout, we expose ourselves to a slight risk in that someone
could change what the script prints without realizing it is being read in
CI. But, this is unlikely to happen - there are not so many devtools
scripts and I think developers understand these are in use in CI testing.
If we want, we can offer to add a flag for the script which would produce a
standard output (some json perhaps). But, we don't need to do this now.
Aaron (the ci project maintainer) is out of office this week, but we can
touch base with him next week to get this merged. And I'll add it to the CI
minutes for Thursday.
[-- Attachment #2: Type: text/html, Size: 876 bytes --]
next prev parent reply other threads:[~2024-10-15 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 21:32 Manit Mahajan
2024-10-15 22:26 ` Patrick Robb [this message]
2024-10-15 22:27 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJvnSUCzxLLt_nP3g6cAqQvO8mCS2JVuG+AFiF0XPmEFMMbGtQ@mail.gmail.com \
--to=probb@iol.unh.edu \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ci@dpdk.org \
--cc=mmahajan@iol.unh.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).