From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB1B245B44; Wed, 16 Oct 2024 00:28:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CABD40144; Wed, 16 Oct 2024 00:28:01 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 6B6FE400D7 for ; Wed, 16 Oct 2024 00:28:00 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20c8c50fdd9so2199255ad.0 for ; Tue, 15 Oct 2024 15:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1729031279; x=1729636079; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZIccsMiw6t/mFGXPtJTjAufaYeOP/xNQ+YSe7nvPAKo=; b=dOnQn1uRIn8u89zPMm9JuzFpHCo2W3mAL1xQKZwsFw0vjGv5qIBm2n6xuGA+0jdDh2 RPaGjOftUPoeudRylD9TZaMaFIGEZv3rT5/BtlzAkMljCAHclzw8EtvG4pcRjZVaU5J1 jP3G/iHhOXFRnPh7kzrss0ahHxa+a9hKMle+0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729031279; x=1729636079; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZIccsMiw6t/mFGXPtJTjAufaYeOP/xNQ+YSe7nvPAKo=; b=bwNpONNjGWmGN1H8zFg9nvKdoV1Ure0HGLbe8eO1QPgtfG8KWykTvh8in6DAsVHc44 7tKtnakVAk8i0oDQ7dW4mvTh/A3y7smZrOTfydkiYIbHFXZnYxkkcYtpZCG/9diaMrJV fDEZCYVhcOXJdoeH47IfDhv8LDAl/jMbIPVoKALrMr6vW83VCyVonZJdJOGXX3vXQkKk MsRmK66deh7TjW8dRq/UkG/JSezduLPKBiT3u4GuruRMV/JY895e4s90/1lDngkqFPfb 6qALJ3XuRmAPBcHvcNgNB7gT2ZvgSaCvLxV7SSTBoXmOVmnph/fwGrb9VI8si9S7nOWm w3vA== X-Gm-Message-State: AOJu0Yy+aorviY8d1sycrk6/znJzcRg+6pS+SredytlZJt7qGK2PU0ws iwqSTYsybIbepBkuWtD7hoZNHg/tNhhaGzlDka0r78mKC4NiMaQzQ0HnTyLqS/uQxVTs7r5Ep3u FMufiRcPMHgJdCIBEZFuMO/5pbO1rmun3o4tXIQ== X-Google-Smtp-Source: AGHT+IEc4/6jLKh+eEXnPHTYxgHMQEf3J65MBEfbXvjRyx22SZaiDHnI1xQQyZEjx+wMEMuktjALE3XnD4XxKQRGUkM= X-Received: by 2002:a17:90a:8a0a:b0:2e2:bdaa:baad with SMTP id 98e67ed59e1d1-2e2f0aa8b5dmr23307402a91.7.1729031279343; Tue, 15 Oct 2024 15:27:59 -0700 (PDT) MIME-Version: 1.0 References: <20241015213211.587-1-mmahajan@iol.unh.edu> In-Reply-To: <20241015213211.587-1-mmahajan@iol.unh.edu> From: Patrick Robb Date: Tue, 15 Oct 2024 18:26:33 -0400 Message-ID: Subject: Re: [PATCH] tools: run check-meson.py in create_series_artifact To: Manit Mahajan Cc: ci@dpdk.org, thomas@monjalon.net, aconole@redhat.com, bruce.richardson@intel.com Content-Type: multipart/alternative; boundary="00000000000036161006248b7777" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --00000000000036161006248b7777 Content-Type: text/plain; charset="UTF-8" Looks good, thanks Manit. I know we have discussed this in person, but I'll just flag here that obviously in building our check-meson CI testing usage around parsing the human readable stdout, we expose ourselves to a slight risk in that someone could change what the script prints without realizing it is being read in CI. But, this is unlikely to happen - there are not so many devtools scripts and I think developers understand these are in use in CI testing. If we want, we can offer to add a flag for the script which would produce a standard output (some json perhaps). But, we don't need to do this now. Aaron (the ci project maintainer) is out of office this week, but we can touch base with him next week to get this merged. And I'll add it to the CI minutes for Thursday. --00000000000036161006248b7777 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Looks good,=C2=A0thanks Manit.=C2=A0

I = know we have discussed this in person, but I'll just flag here that obv= iously in building our check-meson CI testing usage around parsing the huma= n readable stdout, we expose ourselves to a slight risk in that someone cou= ld change what the script prints without realizing it is being read in CI. = But, this is unlikely to happen=C2=A0- there are not so many devtools scrip= ts and I think developers understand these are in use in CI testing. If we = want, we can offer to add a flag for the script which would produce a stand= ard output (some json perhaps). But, we don't need to do this now.=C2= =A0

Aaron (the ci project maintainer) is out of of= fice this week, but we can touch base with him next week to get this merged= . And I'll add it to the CI minutes for Thursday.=C2=A0=C2=A0
--00000000000036161006248b7777--