From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4D8E440F9; Wed, 29 May 2024 19:30:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF2AC40273; Wed, 29 May 2024 19:30:52 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 788364026F for ; Wed, 29 May 2024 19:30:50 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52ae14e78e5so8408e87.3 for ; Wed, 29 May 2024 10:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1717003850; x=1717608650; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DdLVUNW3TG7dAH0+Jq626zSjwlGiQuH8V86noVUD68I=; b=BbNupLK+CRO7zM5umSeX2uFot4ky8cjrWzM5HVLWalzSpR2gzxmdsOX36ggj4pdUw0 ueb2OM4OeTIUyDAlstkFymo9NJTQkG12fwl7Ehwqe7/q5JuS8/zKEN1l78vOdiZj5sd7 uFp/HJu30xaYEJUIF+6frctOvN4vzcrr6MVmQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717003850; x=1717608650; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DdLVUNW3TG7dAH0+Jq626zSjwlGiQuH8V86noVUD68I=; b=T3ww9Xng24TP0iHlILBGPF5whA8CTvJx+1qDmTAKWBcURhUEW+Mj/qq4RRhuTZ9WSO /2t8Zer7wOOHt3z54aXBtveLFQuSNlbHdhSLDOWJ2BZbw9UOgsGMgREfIOfLDOaqR6E3 1d7bTDmGC4uTihZY6ce7ob+fzbWDCNvOpv9jA7RMJTZ5pGJ9SIRumD7G1BpQoFmz3iu3 0wmL1X1SPV41A8WwGB7/Md1BFEXfFW3kdBiyMegjufFDm3J0CH45ukCQSM+2GRsTfxl6 ReeiuMs9EexV6KENHLwwbLdw5aJXcLOfoHr32o5RmMbYz9N96ju3S9BiAFp0wDbsG5JN KgwA== X-Gm-Message-State: AOJu0YxEROQri07ZuwOTyLtC/bdulFdJ+dO0nAoP5XD/woqKWCog5fSX 5OTM/mzf+2NaSjVcghGlTXdzv/wGjf6eClu3dD+jHnxrZ0aO1do3jsClVzgcfuaX/tFsjtXohdj 6deFNr8W0P6cYYuazTUnbgn+eXj8CA2iCcabwrQ== X-Google-Smtp-Source: AGHT+IFxSfGVuB8bYiyQn//8GxfWfPTl53axYlrgU2mECX71cfZot7Nyj5cD8v58z1EprxULLmvzlaXVinmF0CDdrc0= X-Received: by 2002:a05:6512:3d29:b0:523:70db:7a0f with SMTP id 2adb3069b0e04-529644ec14dmr14095440e87.8.1717003849610; Wed, 29 May 2024 10:30:49 -0700 (PDT) MIME-Version: 1.0 References: <3118540.U7HbjWM52l@thomas> In-Reply-To: <3118540.U7HbjWM52l@thomas> From: Cody Cheng Date: Wed, 29 May 2024 13:30:38 -0400 Message-ID: Subject: Re: Ubuntu 24.04 rte_pcapng.c warning To: Thomas Monjalon Cc: ci@dpdk.org Content-Type: multipart/alternative; boundary="00000000000088cfba06199b1c5f" X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org --00000000000088cfba06199b1c5f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Got it! I've re-enabled Werror now that the patch has been merged. Thanks, Cody On Tue, May 28, 2024 at 5:41=E2=80=AFPM Thomas Monjalon wrote: > Hello, > > There was a patch pending for this issue. > It has been merged quickly because it looks urgent, > but I would have preferred a test of the patch from you. > Next time ;) > > Thanks > > > 28/05/2024 20:28, Cody Cheng: > > Here is the warning: > > > > FAILED: lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o > > ccache cc -Ilib/76b5a35@@rte_pcapng@sta -Ilib -I../lib -Ilib/pcapng > > -I../lib/pcapng -I. -I../ -Iconfig -I../config -Ilib/eal/include > > -I../lib/eal/include -Ilib/eal/linux/include > > -I../lib/eal/linux/include -Ilib/eal/x86/include > > -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common > > -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log > > -I../lib/log -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics > > -Ilib/telemetry -I../lib/telemetry -Ilib/ethdev -I../lib/ethdev > > -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool > > -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter > > -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall > > -Winvalid-pch -Wextra -Werror -std=3Dc11 -O3 -include rte_config.h > > -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral > > -Wformat-security -Wmissing-declarations -Wmissing-prototypes > > -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare > > -Wstrict-prototypes -Wundef -Wwrite-strings > > -Wno-address-of-packed-member -Wno-packed-not-aligned > > -Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE > > -fPIC -march=3Dnative -mrtm -DALLOW_EXPERIMENTAL_API > > -DALLOW_INTERNAL_API -Wno-format-truncation > > -DRTE_LOG_DEFAULT_LOGTYPE=3Dlib.pcapng -MD -MQ > > 'lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o' -MF > > 'lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o.d' -o > > 'lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o' -c > > ../lib/pcapng/rte_pcapng.c > > In file included from /usr/include/string.h:548, > > from ../lib/pcapng/rte_pcapng.c:9: > > In function =E2=80=98memcpy=E2=80=99, > > inlined from =E2=80=98pcapng_add_option=E2=80=99 at ../lib/pcapng/r= te_pcapng.c:131:2, > > inlined from =E2=80=98pcapng_section_block=E2=80=99 at > ../lib/pcapng/rte_pcapng.c:192:8: > > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: > > argument 2 null where non-null expected [-Werror=3Dnonnull] > > 29 | return __builtin___memcpy_chk (__dest, __src, __len, > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 30 | __glibc_objsize0 (__dest)); > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in > > a call to built-in function =E2=80=98__builtin___memcpy_chk=E2=80=99 > > In function =E2=80=98memcpy=E2=80=99, > > inlined from =E2=80=98pcapng_add_option=E2=80=99 at ../lib/pcapng/r= te_pcapng.c:131:2, > > inlined from =E2=80=98rte_pcapng_add_interface=E2=80=99 at > ../lib/pcapng/rte_pcapng.c:308:8: > > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: > > argument 2 null where non-null expected [-Werror=3Dnonnull] > > 29 | return __builtin___memcpy_chk (__dest, __src, __len, > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 30 | __glibc_objsize0 (__dest)); > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in > > a call to built-in function =E2=80=98__builtin___memcpy_chk=E2=80=99 > > In function =E2=80=98memcpy=E2=80=99, > > inlined from =E2=80=98pcapng_add_option=E2=80=99 at ../lib/pcapng/r= te_pcapng.c:131:2, > > inlined from =E2=80=98rte_pcapng_write_stats=E2=80=99 at > ../lib/pcapng/rte_pcapng.c:371:9: > > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: > > argument 2 null where non-null expected [-Werror=3Dnonnull] > > 29 | return __builtin___memcpy_chk (__dest, __src, __len, > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 30 | __glibc_objsize0 (__dest)); > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in > > a call to built-in function =E2=80=98__builtin___memcpy_chk=E2=80=99 > > cc1: all warnings being treated as errors > > > > > > On Tue, May 28, 2024 at 12:32=E2=80=AFPM Cody Cheng wrote: > > > > > Hi, > > > > > > We have added the Ubuntu 24.04 environment to the Community Lab! Due > to a > > > warning in rte_pcapng.c, we have temporarily disabled Werror. Once th= is > > > warning has been fixed, we will re-enable Werror. I have attached the > logs > > > for the warning error below. > > > > > > log.txt > > > < > https://drive.google.com/file/d/1qnBcQWg9AHG8RksjGjv8QaqTqw6yC3Gc/view?us= p=3Ddrive_web > > > > > > > > Thanks, > > > Cody > > > > > > > > > > > --00000000000088cfba06199b1c5f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Got it!

I've re-enabled Werror now that the pat= ch has been merged.

Thanks,
Cody

On Tue, May 28,= 2024 at 5:41=E2=80=AFPM Thomas Monjalon <thomas@monjalon.net> wrote:
Hello,

There was a patch pending for this issue.
It has been merged quickly because it looks urgent,
but I would have preferred a test of the patch from you.
Next time ;)

Thanks


28/05/2024 20:28, Cody Cheng:
> Here is the warning:
>
> FAILED: lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o
> ccache cc -Ilib/76b5a35@@rte_pcapng@sta -Ilib -I../lib -Ilib/pcapng > -I../lib/pcapng -I. -I../ -Iconfig -I../config -Ilib/eal/include
> -I../lib/eal/include -Ilib/eal/linux/include
> -I../lib/eal/linux/include -Ilib/eal/x86/include
> -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common
> -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log
> -I../lib/log -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics<= br> > -Ilib/telemetry -I../lib/telemetry -Ilib/ethdev -I../lib/ethdev
> -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool
> -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter > -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall
> -Winvalid-pch -Wextra -Werror -std=3Dc11 -O3 -include rte_config.h
> -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral
> -Wformat-security -Wmissing-declarations -Wmissing-prototypes
> -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare=
> -Wstrict-prototypes -Wundef -Wwrite-strings
> -Wno-address-of-packed-member -Wno-packed-not-aligned
> -Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE<= br> > -fPIC -march=3Dnative -mrtm -DALLOW_EXPERIMENTAL_API
> -DALLOW_INTERNAL_API -Wno-format-truncation
> -DRTE_LOG_DEFAULT_LOGTYPE=3Dlib.pcapng -MD -MQ
> 'lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o' -MF
> 'lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o.d' -o
> 'lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o' -c
> ../lib/pcapng/rte_pcapng.c
> In file included from /usr/include/string.h:548,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 from ../= lib/pcapng/rte_pcapng.c:9:
> In function =E2=80=98memcpy=E2=80=99,
>=C2=A0 =C2=A0 =C2=A0inlined from =E2=80=98pcapng_add_option=E2=80=99 at= ../lib/pcapng/rte_pcapng.c:131:2,
>=C2=A0 =C2=A0 =C2=A0inlined from =E2=80=98pcapng_section_block=E2=80=99= at ../lib/pcapng/rte_pcapng.c:192:8:
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: > argument 2 null where non-null expected [-Werror=3Dnonnull]
>=C2=A0 =C2=A0 29 |=C2=A0 =C2=A0return __builtin___memcpy_chk (__dest, _= _src, __len,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~= ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>=C2=A0 =C2=A0 30 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 __glibc_= objsize0 (__dest));
>=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in<= br> > a call to built-in function =E2=80=98__builtin___memcpy_chk=E2=80=99 > In function =E2=80=98memcpy=E2=80=99,
>=C2=A0 =C2=A0 =C2=A0inlined from =E2=80=98pcapng_add_option=E2=80=99 at= ../lib/pcapng/rte_pcapng.c:131:2,
>=C2=A0 =C2=A0 =C2=A0inlined from =E2=80=98rte_pcapng_add_interface=E2= =80=99 at ../lib/pcapng/rte_pcapng.c:308:8:
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: > argument 2 null where non-null expected [-Werror=3Dnonnull]
>=C2=A0 =C2=A0 29 |=C2=A0 =C2=A0return __builtin___memcpy_chk (__dest, _= _src, __len,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~= ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>=C2=A0 =C2=A0 30 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 __glibc_= objsize0 (__dest));
>=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in<= br> > a call to built-in function =E2=80=98__builtin___memcpy_chk=E2=80=99 > In function =E2=80=98memcpy=E2=80=99,
>=C2=A0 =C2=A0 =C2=A0inlined from =E2=80=98pcapng_add_option=E2=80=99 at= ../lib/pcapng/rte_pcapng.c:131:2,
>=C2=A0 =C2=A0 =C2=A0inlined from =E2=80=98rte_pcapng_write_stats=E2=80= =99 at ../lib/pcapng/rte_pcapng.c:371:9:
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: > argument 2 null where non-null expected [-Werror=3Dnonnull]
>=C2=A0 =C2=A0 29 |=C2=A0 =C2=A0return __builtin___memcpy_chk (__dest, _= _src, __len,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~= ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>=C2=A0 =C2=A0 30 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 __glibc_= objsize0 (__dest));
>=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 ~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in<= br> > a call to built-in function =E2=80=98__builtin___memcpy_chk=E2=80=99 > cc1: all warnings being treated as errors
>
>
> On Tue, May 28, 2024 at 12:32=E2=80=AFPM Cody Cheng <ccheng@iol.unh.edu> wrote:=
>
> > Hi,
> >
> > We have added the Ubuntu 24.04 environment to the Community Lab! = Due to a
> > warning in rte_pcapng.c, we have temporarily disabled Werror. Onc= e this
> > warning has been fixed, we will re-enable Werror. I have attached= the logs
> > for the warning error below.
> >
> >=C2=A0 log.txt
> > <= https://drive.google.com/file/d/1qnBcQWg9AHG8RksjGjv8QaqTqw6yC3Gc/view?usp= =3Ddrive_web>
> >
> > Thanks,
> > Cody
> >
>





--00000000000088cfba06199b1c5f--