From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E9D9A0C53 for ; Wed, 3 Nov 2021 15:39:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84BAE42728; Wed, 3 Nov 2021 15:39:13 +0100 (CET) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by mails.dpdk.org (Postfix) with ESMTP id 8A94D42728 for ; Wed, 3 Nov 2021 15:39:11 +0100 (CET) Received: by mail-ed1-f46.google.com with SMTP id 5so9828769edw.7 for ; Wed, 03 Nov 2021 07:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CFp8sJ8lzAq7yssiHYorT7ctNKydw8EXrYAajffY5k0=; b=LwlqKQcAuZwsgMo0zKDSB2UqtqK8VmSXnL/Yo3Yzm3Viksm41R6sgRXzcbf3X+MCVu v88wCRmxrqYYuV4WMXCRLjYdaTVAMF3uYDsdY3jHTYEEjC1BXRr8epYUpXbOh+KUf4HN 4qubZ/VkYsdgxG6DxlB12SqaMRMfXt1DNV8Vs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CFp8sJ8lzAq7yssiHYorT7ctNKydw8EXrYAajffY5k0=; b=HnU2tiUIrs+yEW8FRVh6ZbKgdFpDOSYAAuUu+eFNYWJUC8NL+09mgBQ3zbW6DUGuld 6VSwciEo9NZVzO5CmMF1jjebCpKxAYdY+sLemHmIqN+oFxuNWGBJw8R5+hRuXG9FxjHG hGHTNOApp2zS97OTjLg5hWcBr01BpL3qZ03KYlTvWrF7gug8y7XaXPIWA17fCwJPDIKn hpO6wQFbqzTpqh26VcbjTzT4BJDknH8JfU2EAKxz2L0TwhQm4KW4p4PkgIzGO5xtG11M kr+izKrZ9pasIIs6ukGQdLUzOxqQSVIX3A7kb72dcc0cs/eDdwYCmHmY0loOFqDZmnJm gKAQ== X-Gm-Message-State: AOAM533RDSUkdR3FTC7i6Mnpxk8KC969QXct7JRTQHI5QaHrg2fm9Lgd PhQkPJqbjiKz40dDqSPWysLBX9nLsuDbanwO2ViNqw== X-Google-Smtp-Source: ABdhPJxkMbjOthLGQfDamnbdsRkVwutUZ3HS+LSZ4hij1NAFD2zOvvJpo3O7V/zqJk9Pg7lHnui7CI8qsotBne9STfw= X-Received: by 2002:a17:906:4fcd:: with SMTP id i13mr17037027ejw.472.1635950344576; Wed, 03 Nov 2021 07:39:04 -0700 (PDT) MIME-Version: 1.0 References: <20211102104748.57078-1-maxime.coquelin@redhat.com> <3a63bda9-2ff7-30bc-87b7-48e1324d1666@redhat.com> <242aa665-45b6-2441-4288-26a4056dc3e2@redhat.com> <75726d5f-35b9-4d59-7bde-483cb1c5475e@redhat.com> In-Reply-To: <75726d5f-35b9-4d59-7bde-483cb1c5475e@redhat.com> From: Lincoln Lavoie Date: Wed, 3 Nov 2021 10:38:53 -0400 Message-ID: To: Maxime Coquelin Cc: David Marchand , "Xia, Chenbo" , "dev@dpdk.org" , "Liu, Changpeng" , Thomas Monjalon , Aaron Conole , dpdklab , ci@dpdk.org, Owen Hilyard Content-Type: multipart/alternative; boundary="00000000000028bd0105cfe35f81" Subject: Re: [dpdk-ci] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" --00000000000028bd0105cfe35f81 Content-Type: text/plain; charset="UTF-8" On Wed, Nov 3, 2021 at 9:16 AM Maxime Coquelin wrote: > > > On 11/3/21 14:11, Lincoln Lavoie wrote: > > > > > > > > On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin > > > wrote: > > > > > > > > On 11/3/21 09:38, Maxime Coquelin wrote: > > > Hi David, > > > > > > On 11/3/21 09:36, David Marchand wrote: > > >> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo > > wrote: > > >>> Testing issues reported in patchwork is expected as SPDK uses > > >>> this struct, so we can ignore it as SPDK will rename it when it > > >>> adapts to DPDK 21.11 > > >> > > >> Please, no. > > >> We can't simply say "ignore failure in CI". > > >> > > >> The SPDK build test must be disabled in CI first. > > >> You can create a bugzilla and assign it to UNH lab. > > >> Example: https://bugs.dpdk.org/show_bug.cgi?id=579 > > > > >> > > >> Once done, we can merge this patch in DPDK. > > >> > > >> > > >> In parallel, either prepare the patch or talk to SPDK guys to > handle > > >> this change. > > >> Once this is done, update the bugzilla so that we can get SPDK > build > > >> tested again in CI. > > > > > > Thanks for the insights, I'll file a Bz and work with the SPDK > team. > > > > The Bz has been filed: > > https://bugs.dpdk.org/show_bug.cgi?id=876 > > > > > > > Maxime > > >> Thanks. > > >> > > >> > > > > SDPK tests have been disabled in the CI testing and shouldn't run for > > any new patches. Anything that was already in the queue will finish > > out. Bug ticket has been updated. > > Thanks Lincoln, as the patch wasn't merged yet, this API change will not > impact other jobs already queued. > > > Who from the SPDK team "has the ball" on this item, so we know it's > > being tracked and worked on? > > I think Changpeng Liu in Cc: is the right contact from the SPDK team for > this. For my information, are the SPDK tests based on their main branch > or on the last release? > SDPK branch should be their current LTS branch (21.1.x), so not the main branch. > > Thanks, > Maxime > > > Cheers, > > Lincoln > > > > > > -- > > *Lincoln Lavoie* > > Principal Engineer, Broadband Technologies > > 21 Madbury Rd., Ste. 100, Durham, NH 03824 > > lylavoie@iol.unh.edu > > https://www.iol.unh.edu > > +1-603-674-2755 (m) > > > > -- *Lincoln Lavoie* Principal Engineer, Broadband Technologies 21 Madbury Rd., Ste. 100, Durham, NH 03824 lylavoie@iol.unh.edu https://www.iol.unh.edu +1-603-674-2755 (m) --00000000000028bd0105cfe35f81 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Nov 3, 2021 at 9:16 AM Maxime Coquelin <= maxime.coquelin@redhat.com> wrote:

On 11/3/21 14:11, Lincoln Lavoie wrote:
>
>
>
> On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin
> <ma= xime.coquelin@redhat.com <mailto:maxime.coquelin@redhat.com>> wrote:<= br> >
>
>
>=C2=A0 =C2=A0 =C2=A0On 11/3/21 09:38, Maxime Coquelin wrote:
>=C2=A0 =C2=A0 =C2=A0 > Hi David,
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > On 11/3/21 09:36, David Marchand wrote:
>=C2=A0 =C2=A0 =C2=A0 >> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenb= o <chenbo.xia@= intel.com
>=C2=A0 =C2=A0 =C2=A0<mailto:chenbo.xia@intel.com>> wrote:
>=C2=A0 =C2=A0 =C2=A0 >>> Testing issues reported in patchwork = is expected as SPDK uses
>=C2=A0 =C2=A0 =C2=A0 >>> this struct, so we can ignore it as S= PDK will rename it when it
>=C2=A0 =C2=A0 =C2=A0 >>> adapts to DPDK 21.11
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> Please, no.
>=C2=A0 =C2=A0 =C2=A0 >> We can't simply say "ignore fail= ure in CI".
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> The SPDK build test must be disabled in C= I first.
>=C2=A0 =C2=A0 =C2=A0 >> You can create a bugzilla and assign it t= o UNH lab.
>=C2=A0 =C2=A0 =C2=A0 >> Example: https://bugs.d= pdk.org/show_bug.cgi?id=3D579
>=C2=A0 =C2=A0 =C2=A0<https://bugs.dpdk.org/show_bu= g.cgi?id=3D579>
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> Once done, we can merge this patch in DPD= K.
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >> In parallel, either prepare the patch or = talk to SPDK guys to handle
>=C2=A0 =C2=A0 =C2=A0 >> this change.
>=C2=A0 =C2=A0 =C2=A0 >> Once this is done, update the bugzilla so= that we can get SPDK build
>=C2=A0 =C2=A0 =C2=A0 >> tested again in CI.
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > Thanks for the insights, I'll file a Bz a= nd work with the SPDK team.
>
>=C2=A0 =C2=A0 =C2=A0The Bz has been filed:
>=C2=A0 =C2=A0 =C2=A0https://bugs.dpdk.org/show_bug.cg= i?id=3D876
>=C2=A0 =C2=A0 =C2=A0<https://bugs.dpdk.org/show_bu= g.cgi?id=3D876>
>
>=C2=A0 =C2=A0 =C2=A0 > Maxime
>=C2=A0 =C2=A0 =C2=A0 >> Thanks.
>=C2=A0 =C2=A0 =C2=A0 >>
>=C2=A0 =C2=A0 =C2=A0 >>
>
> SDPK tests have been disabled in the CI testing and shouldn't run = for
> any new patches.=C2=A0 Anything that was already in the queue will fin= ish
> out.=C2=A0 Bug ticket has been updated.

Thanks Lincoln, as the patch wasn't merged yet, this API change will no= t
impact other jobs already queued.

> Who from the SPDK team "has the ball" on this item, so we kn= ow it's
> being tracked and worked on?

I think Changpeng Liu in Cc: is the right contact from the SPDK team for this. For my information, are the SPDK tests based on their main branch
or on the last release?
SDPK branch should be their current LTS branch (21.= 1.x), so not the main branch.

=C2=A0

Thanks,
Maxime

> Cheers,
> Lincoln
>
>
> --
> *Lincoln Lavoie*
> Principal Engineer, Broadband Technologies
> 21 Madbury Rd., Ste. 100, Durham, NH 03824
> lylavoie@iol= .unh.edu <mailto:lylavoie@iol.unh.edu>
> https://www.iol.unh.edu <https://www.iol.unh.edu>
> +1-603-674-2755 (m)
> <https://www.iol.unh.edu>



--
Lincoln Lavoie
Prin= cipal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, = Durham, NH 03824
+1-603-674-= 2755 (m)

--00000000000028bd0105cfe35f81--