From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB352A09E4 for ; Thu, 4 Feb 2021 22:59:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3EAF240846; Thu, 4 Feb 2021 22:59:42 +0100 (CET) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by mails.dpdk.org (Postfix) with ESMTP id B8CB224082D for ; Thu, 4 Feb 2021 22:59:39 +0100 (CET) Received: by mail-ej1-f48.google.com with SMTP id hs11so8282393ejc.1 for ; Thu, 04 Feb 2021 13:59:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0051+fQJ1eor/cX6crd6GBWTPWiNoX2bzsmI75qSYtc=; b=DO2ps2jLQ/aCnYajjoi6XpBsUcEVgpo5uFOrWPHQxxLYuEMxqtZXnsaFAbz1yZQRih XcuI6xlXHIhSIXqHl4KslCivFh0dOisd4890l4u9LulkR+Mod4sqTeVGhFStiHXBFu5L HRZ2DUD0hIDExiPlaWwa1ahtBk8Hc+Ldj5suQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0051+fQJ1eor/cX6crd6GBWTPWiNoX2bzsmI75qSYtc=; b=ZAonoKKVFc9V5+xDMKGDxJxGaeeFK/soyfWgE8q7PID2lcI+Pe8iptbN+9GqLPZKzH eTmn+vrz2fIrrV6reKkx+wbFQ5YyJCRQqZ7lzhywAmf/GbLYk8FXnDXKmULSMNjBaVme /kF+EsNNKOzIaigS43gZJmco5NY5unmjhOpsehNh4ymy6qEJ5Y2EFYjCEeyTo9bwc9rB 4/J3k46nT3YG0PhO7oeOP6HU5bQdSR+oKSA556mkyryqkr60F/lJD2HtxjsSQn4kSHqX 8PXraJbOqzs1y8BuHcgtCIIOczvArg727LX7yQiVULZ5u+SG83K5ZF+nXxcvcXHX1+b/ +moA== X-Gm-Message-State: AOAM533f4flSagQoB1TTHlpmWnWTwSyawredR/VV14FaRrYiivCUC24G D97NG2ufji3usewbpxVyoL2UCk0X/edc6NixZEKUKA== X-Google-Smtp-Source: ABdhPJzKICQljoWXoYkwHv8MibK4+Cawkg5pTxAUTDaj9qf3t6Dq65F/vUjuV7sd50j2jSUj8dAVjJMIyPODQq6V1LY= X-Received: by 2002:a17:906:6087:: with SMTP id t7mr1158844ejj.90.1612475979240; Thu, 04 Feb 2021 13:59:39 -0800 (PST) MIME-Version: 1.0 References: <20210202090639.83164-1-leyi.rong@intel.com> <20210202143258.108477-1-leyi.rong@intel.com> <20210203020758.12cd8089@sovereign> <5ec7623cbb604753bb70fa9f4b0a7c3a@intel.com> In-Reply-To: From: Lincoln Lavoie Date: Thu, 4 Feb 2021 16:57:21 -0500 Message-ID: To: David Marchand Cc: Ferruh Yigit , "Zhang, Qi Z" , Dmitry Kozlyuk , "Rong, Leyi" , "thomas@monjalon.net" , "Richardson, Bruce" , "talshn@nvidia.com" , "Kadam, Pallavi" , "Menon, Ranjit" , "Xing, Beilei" , "aconole@redhat.com" , "dev@dpdk.org" , "ci@dpdk.org" Content-Type: multipart/alternative; boundary="000000000000f3b0f605ba89d1c6" Subject: Re: [dpdk-ci] [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" --000000000000f3b0f605ba89d1c6 Content-Type: text/plain; charset="UTF-8" Hi All, The jobs for Windows compile are running, so it may just be the patch hasn't caught up in the queue. Cheers, Lincoln On Thu, Feb 4, 2021 at 8:43 AM David Marchand wrote: > On Thu, Feb 4, 2021 at 1:36 PM Ferruh Yigit > wrote: > > > > On 2/4/2021 10:41 AM, Zhang, Qi Z wrote: > > > > > > > > >> -----Original Message----- > > >> From: Dmitry Kozlyuk > > >> Sent: Wednesday, February 3, 2021 7:08 AM > > >> To: Rong, Leyi > > >> Cc: david.marchand@redhat.com; Zhang, Qi Z ; > Yigit, > > >> Ferruh ; thomas@monjalon.net; Richardson, > Bruce > > >> ; talshn@nvidia.com; Kadam, Pallavi > > >> ; Menon, Ranjit ; > Xing, > > >> Beilei ; aconole@redhat.com; dev@dpdk.org; > > >> ci@dpdk.org > > >> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on > MinGW > > >> > > >> On Tue, 2 Feb 2021 22:32:58 +0800, Leyi Rong wrote: > > >>> Adds extra cflags '-fno-asynchronous-unwind-tables' > > >>> to avoid the MinGW build error: > > >>> Error: invalid register for .seh_savexmm > > >>> > > >>> Fixes: 5c38c33f7880 ("net/i40e: disable AVX512 with MinGW") > > >>> > > >>> Signed-off-by: Leyi Rong > > >> > > >> Tested-by: Dmitry Kozlyuk > > >> > > >> Re: -fno-asynchronous-unwind-tables, when cross-compiling from Linux, > I > > >> observe bit-to-bit identical i40e_rxtx_vec_avx512.c.obj. My guess it > that this > > >> option somehow affects GCC inlining heuristics. Similar issue existed > in > > >> librte_acl (at least a year ago win GCC 6, I believe), where GCC > generated > > >> incorrect code unless certain functions had been inlined (caught by > test app). > > >> No an AVX expert, just my 2c. > > > > > > Applied to dpdk-next-net-intel. > > > > > > > Hi Thomas, David, > > > > Do you prefer to get this directly to the main repo, since it is fixing > the > > windows build? > > I have no issue with the main branch for mingw. > The windows builds at UNH seem unavailable, so we can wait for the > next-net merge. > > > -- > David Marchand > > -- *Lincoln Lavoie* Principal Engineer, Broadband Technologies 21 Madbury Rd., Ste. 100, Durham, NH 03824 lylavoie@iol.unh.edu https://www.iol.unh.edu +1-603-674-2755 (m) --000000000000f3b0f605ba89d1c6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi = All,

The jo= bs for Windows compile are running, so it may just=C2=A0be the patch hasn&#= 39;t caught up in the queue.

Cheers,
Lincoln

On Thu, Feb 4, 2021 at 8:43 AM David Marchand= <david.marchand@redhat.com= > wrote:
= On Thu, Feb 4, 2021 at 1:36 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 2/4/2021 10:41 AM, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >> Sent: Wednesday, February 3, 2021 7:08 AM
> >> To: Rong, Leyi <leyi.rong@intel.com>
> >> Cc: david.marchand@redhat.com; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, > >> Ferruh <ferruh.yigit@intel.com>; thomas@monjalon.net; Richardson, Bruce
> >> <bruce.richardson@intel.com>; talshn@nvidia.com; Kadam, Pallavi
> >> <pallavi.kadam@intel.com>; Menon, Ranjit <ranjit.menon@intel.com>; Xin= g,
> >> Beilei <beilei.xing@intel.com>; aconole@redhat.com; dev@dpdk.org;
> >> ci@dpdk.org<= /a>
> >> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code err= or on MinGW
> >>
> >> On Tue,=C2=A0 2 Feb 2021 22:32:58 +0800, Leyi Rong wrote:
> >>> Adds extra cflags '-fno-asynchronous-unwind-tables= 9;
> >>> to avoid the MinGW build error:
> >>>=C2=A0 =C2=A0 =C2=A0Error: invalid register for .seh_savex= mm
> >>>
> >>> Fixes: 5c38c33f7880 ("net/i40e: disable AVX512 with = MinGW")
> >>>
> >>> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> >>
> >> Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >>
> >> Re: -fno-asynchronous-unwind-tables, when cross-compiling fro= m Linux, I
> >> observe bit-to-bit identical i40e_rxtx_vec_avx512.c.obj. My g= uess it that this
> >> option somehow affects GCC inlining heuristics. Similar issue= existed in
> >> librte_acl (at least a year ago win GCC 6, I believe), where = GCC generated
> >> incorrect code unless certain functions had been inlined (cau= ght by test app).
> >> No an AVX expert, just my 2c.
> >
> > Applied to dpdk-next-net-intel.
> >
>
> Hi Thomas, David,
>
> Do you prefer to get this directly to the main repo, since it is fixin= g the
> windows build?

I have no issue with the main branch for mingw.
The windows builds at UNH seem unavailable, so we can wait for the
next-net merge.


--
David Marchand



--
Lincoln Lavoie
Prin= cipal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, = Durham, NH 03824
+1-603-674-= 2755 (m)

--000000000000f3b0f605ba89d1c6--