DPDK CI discussions
 help / color / mirror / Atom feed
From: Ali Alnubani <alialnu@nvidia.com>
To: "jspewock@iol.unh.edu" <jspewock@iol.unh.edu>,
	"ci@dpdk.org" <ci@dpdk.org>
Subject: RE: [PATCH v6 0/4] Add ACVP Tool
Date: Tue, 28 Mar 2023 08:28:12 +0000	[thread overview]
Message-ID: <CH0PR12MB515621B7D37A36F2EC075AF6DA889@CH0PR12MB5156.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230327165141.7916-2-jspewock@iol.unh.edu>

> -----Original Message-----
> From: jspewock@iol.unh.edu <jspewock@iol.unh.edu>
> Sent: Monday, March 27, 2023 7:52 PM
> To: ci@dpdk.org
> Cc: Jeremy Spewock <jspewock@iol.unh.edu>
> Subject: [PATCH v6 0/4] Add ACVP Tool
> 
> From: Jeremy Spewock <jspewock@iol.unh.edu>
> 
> v1: https://mails.dpdk.org/archives/ci/2022-January/001599.html
> v2: https://mails.dpdk.org/archives/ci/2022-January/001611.html
> v3: https://mails.dpdk.org/archives/ci/2022-February/001636.html
> v4: https://mails.dpdk.org/archives/ci/2022-April/001702.html
> v5: https://mails.dpdk.org/archives/ci/2023-March/002112.html
> v6:
>   * fix commit messages
> 
> Jeremy Spewock (4):
>   tools: add acvp_tool
>   tools: add default config file for acvp_tool
>   tools: add requirements file for acvp_tool
>   doc: add readme file for acvp_tool
> 

Hello Jeremy,

In addition to the other comments on 2/4 and 4/4, I would like to note that Brandon's sign-off-by tag shouldn't be removed from the patches as he was the original author.

Regards,
Ali

      parent reply	other threads:[~2023-03-28  8:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 16:51 jspewock
2023-03-27 16:51 ` [PATCH v6 1/4] tools: add acvp_tool jspewock
2023-03-27 16:51 ` [PATCH v6 2/4] tools: add default config file for acvp_tool jspewock
2023-03-28  8:25   ` Ali Alnubani
2023-03-27 16:51 ` [PATCH v6 3/4] tools: add requirements " jspewock
2023-03-27 16:51 ` [PATCH v6 4/4] doc: add readme " jspewock
2023-03-28  8:27   ` Ali Alnubani
2023-04-03 18:49     ` Jeremy Spewock
2023-03-28  8:28 ` Ali Alnubani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH0PR12MB515621B7D37A36F2EC075AF6DA889@CH0PR12MB5156.namprd12.prod.outlook.com \
    --to=alialnu@nvidia.com \
    --cc=ci@dpdk.org \
    --cc=jspewock@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).