From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5B9BA0C57 for ; Thu, 4 Nov 2021 17:48:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD28241223; Thu, 4 Nov 2021 17:48:49 +0100 (CET) Received: from AZHDRRW-EX01.nvidia.com (azhdrrw-ex01.nvidia.com [20.51.104.162]) by mails.dpdk.org (Postfix) with ESMTP id 44D0B411C9 for ; Thu, 4 Nov 2021 17:48:48 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by mxs.oss.nvidia.com (10.13.234.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Thu, 4 Nov 2021 09:48:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MSudg+mm2GMreU/GX0zpJCAEb3OIkBOc+OiiNfZLC6rFNg8KnddFDKIzqmWoNUW+uiw6G0ssmRL2zsLP5DP2Uljg1OL4BHxp/MfIO+/K4CIj0xrC++YMmnGqIPT3MRivdBV95cxKzggYRfHvOXHX7sSKVhzIN4EpVUcO+WZA9PLE253pJ1fKHC0ffuzMKUY0pY1mfhxL3PX/Mw8e3ZAShAQEgbHxm2/qdsnktc5n6RVjeGr2Fzpk+UGh1cQJ90qQ5eOiLNu+oXH3CLYW2whVt0RlFqTd0vGOCyF4Z5PmC6/PcDRjMbnJzp6AuXLGtuSABq3ha972/Fp3/b4ui+Quqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ow8yfuNuGA5ZxS498pnA+xyEJnki9P6TWVegRln+qXA=; b=PUhIAjGPbmBye7XttX95GUOsmfaQIGLvGZ7bviOSKJ5z8gwuvEPlEOoyBd0CRIdDIp1vKgb+tXTp5tedst989Fm8UQGe8EOIWmyRALtC+342mvY4rz4AQRyqebtKh+hYWTFd9MQxHGRgJfol94VhJjWWqmHFwBr+XywAwRQIobkN35Nm0gzak6y+QYQ8wQM8UQ+2at/2YlOSSL1szL8jusv/4951Pi9WXEO00mqEOeZzkuL+gsHMFGHiLIju7QiMYfG/wnCbgAci4N1+RRbIvVk4VSz8+3O8SKWYMbhp18ecGRt6EhdJJxwg7V/Jz8wayCNRXnxiUDotrBelkglXEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ow8yfuNuGA5ZxS498pnA+xyEJnki9P6TWVegRln+qXA=; b=Gpv71EfH3Vtsar68KBKA8x0oZZnhGTZg2IKZ48IAfu7xS8s3pRoduiqVe3ZG03SemVdTvqE5wNt34WHCoWqYjUawKpzF6zk5bX4ylQX0FtHkLNNcHnpPrhooWoImRf7rgEzKTYUUHlHRrwWIAShTOdtGnDT8iWChf/HcgCqsiK2l+7LjzRqq+KadFpB8ei7oxz1CTRdJW56+CXCdAqSl70K8WWD2wHTBvF9cFWQdDCgcuHaB3FqwTQt5UtSCWK7nR0FG0UTuOsyFQ/4PzkuAFx7kN5G6o6wWrXw/6niftAUBNUZxjk5un86D0qRr7ZCp8QnjjjAs07mxtXSu+duyNQ== Received: from CH0PR12MB5156.namprd12.prod.outlook.com (2603:10b6:610:bb::17) by CH0PR12MB5028.namprd12.prod.outlook.com (2603:10b6:610:e3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Thu, 4 Nov 2021 16:48:46 +0000 Received: from CH0PR12MB5156.namprd12.prod.outlook.com ([fe80::c8b:4fa:420d:5e5c]) by CH0PR12MB5156.namprd12.prod.outlook.com ([fe80::c8b:4fa:420d:5e5c%5]) with mapi id 15.20.4649.019; Thu, 4 Nov 2021 16:48:45 +0000 From: Ali Alnubani To: NBU-Contact-Thomas Monjalon CC: "ci@dpdk.org" , "jerinj@marvell.com" , "ferruh.yigit@intel.com" , "david.marchand@redhat.com" , "juraj.linkes@pantheon.tech" Thread-Topic: [PATCH v2 05/10] tools: add functionality for setting pw delegates Thread-Index: AQHXtdu5qAm+7mlJpkCgH71Ih8ojTavYfQEggAz9LoCADjDWkA== Date: Thu, 4 Nov 2021 16:48:45 +0000 Message-ID: References: <20210906154537.1299-1-alialnu@nvidia.com> <24744594.yUaU8azXQc@thomas> <1810993.5c47M4QTcs@thomas> In-Reply-To: <1810993.5c47M4QTcs@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6078b0ce-a7cb-4beb-6927-08d99fb2f7c9 x-ms-traffictypediagnostic: CH0PR12MB5028: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DC9/z7sOZATkh77SkLOLiQTUiXAzv5lScFDX1EJ9zgHSmjPtdXLcz2FoPhYu9WmbhqTX35sn+x8gcRtppHfcCYOM+dx1NQEq8l/ZwvMIw3O4RdI6UtGLCTyhPk7jM9MMHnJQTzCZBVR4HQfkBKsrTiuzjkIbXkrrMrwDGErbQqAMAsxRJ9nTnPuhFRK1nsMg4jqduYoVbHl4OykDz1/1W5XM64tDSK2LmzeAsVxM4+gjXKE5/l7I+sXS+3nwX1Z0LChzajZVTEQLtYvlECQKBQMGxo5vMtu2PtcPohJRfNem6sMhBWIzni+VpWW9BYhW/TwFVOKZa3FviqYe6ynaG2H1H4x8o4kZ/ciuANFPTtEggJa4/v0SuJs90BTkthCSraz+RiulwuvY+92f4PWL1AcZB5z4xi02Iv6gb4AGV0Ey2OG3D31yKxCiIYBOxzUDguXE3NGUJIxJL8gn+oDKNQUr/+tc3HsI875eRTOqq+0snVzMeAT4Id/5/BQnaMU5/skwW9TrKwWckdJkhSAKOsdkJ75AV0vW6gMTH9v+ZFEQ70TyvgO73gd9+El6PrT4D5Hj93VwySOOdmS0aTeyDuOb9NWFBSTlAr90yBlPHSY5d7VEwRD1FDD9bvrY0KN98gP/1CzkQbXMp0yeO36NBBeDDgE86IEtoj2L2od/IvUR0HQiP9PCHTOu08szQQ1EI/Fo0SjwMSzE3VH07v9t8A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR12MB5156.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(4326008)(71200400001)(316002)(54906003)(8676002)(64756008)(66446008)(9686003)(186003)(508600001)(5660300002)(38070700005)(86362001)(52536014)(122000001)(6506007)(53546011)(66556008)(26005)(76116006)(83380400001)(6862004)(55016002)(66946007)(38100700002)(7696005)(8936002)(2906002)(107886003)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IwOcEsntm+2996CUjHh52pRr3JMwvAkf94qwaBPxuRbgcfZUqXxnIg8XZOIJ?= =?us-ascii?Q?h3OOlbY1zqIUmjGRwqQFsgovtfN6mMmNm3jv6mlQPOlrhkeODznIwn9y2DdJ?= =?us-ascii?Q?rH0QxmfyG1B01mnWh+nEwsPbiWmAko7om0WZfPrW3Orp+YJMIRXnTM/n4Y+O?= =?us-ascii?Q?Fct8W0MXiTvML21GCP7fBy2cxum3u3WaOkCDk7cUtj3IhjQ/7M1T/B/OcSMP?= =?us-ascii?Q?6L7UrNI8x5Q8XbnnAPTfZXPy5uZv/imwxLPEd6I9CBu5hz1stjM+WN5AwY9W?= =?us-ascii?Q?eoa1yEDerhgxjs2bMdEQlYMRu9JpAr5dn/+J64wx30YmfLZ+GUJeKmcUi7rW?= =?us-ascii?Q?xo+Dknm+IRCWp+0FfgV1p8ZpleA72Xh4x7Avopw710Scsod448EQx/9bmU04?= =?us-ascii?Q?0+26qhNPHrvQreqI4eK2FcP2Dep3m/aPEjdDPaWKLQXcJOgzz6Zg3NsAle89?= =?us-ascii?Q?XnebugI02WFyK6MVBGIdB26PWpsnFpK4HfhGjcb3vBWDCktvFP6a/GX58TLR?= =?us-ascii?Q?twgFNRhODeEa2FAXYykur3uPgv2+sexP1jpcJ5AXskA8fh6rFWLU1cV6N7+L?= =?us-ascii?Q?/xr6ib7iIEau5FPR/Ud/B09tDGrKRKloHgzrefV4ZMdpJrsTwRLRUMc2phpx?= =?us-ascii?Q?FjoHbWP6v9pKb4wgB4agUU9zQHxvdQXRrNIKAfXTcQVAlxZtk/xlhZ1pHJRJ?= =?us-ascii?Q?9fFla2X11BSOETO8bo2Y3Pl1V93m8ngk9eLPpkLF/d0ClSj6VRg8uZJtMdDF?= =?us-ascii?Q?k474zPLwE/bt1RJoPvI2ADj+fPfK+O27FiTbgQK+/ofLpYpadmSP9LdiUxO+?= =?us-ascii?Q?F11aUZP8XgfC5im1fa/OxBGp6HvcU0auLvsN6QvXOLmdnc+fgyFr+1bRQjC9?= =?us-ascii?Q?RPi3O2ltcDhzkRBxqZTYwWqMz+1zoYiD2pUY9+q3E2eo+X5yCKC7aD55XvVu?= =?us-ascii?Q?426MFV6CHw6kHhsbBHMQ1KIokdKJwH56o1be21w/83+s14x/RRj//fJ2Ryqs?= =?us-ascii?Q?jYbQiYDnAybOGReqc8xxPsru6XMyIcgo0lHuot7bq+A4jP/GGFxdHXLkzZ31?= =?us-ascii?Q?ElgfcUxxAatVK/5Fw/RQ200XpdIPoqUjMXfsobOuxxRJDxZPkgKTUkQyK9/s?= =?us-ascii?Q?yH03AAnkzeov6NomT0Td9GRYVChFSSv8gHvUwFmck/kFQGDMuzLRrdxxOkmN?= =?us-ascii?Q?kZ7i0GrX10xy7Z8HHDs9AAwGv15kIgiRirTbCrZw2+j+RlEgB40/a7MJkpf/?= =?us-ascii?Q?fONfCAlYj+qhUEbroDAxIuUdE1r3wEd9jPWyjAdiemlnKAxgi7rzgrzdJz7C?= =?us-ascii?Q?xYXVtTyJ0FkDcPtGxR/d7bhv7y7msu0CSEUXezRwW+C41UGluN1qxSmzJdOH?= =?us-ascii?Q?yx/Jz51bvbFxBMEhCM+WHVpiInGt/htdXtfwpV56OnOaJwEbYjEO/YEYoqpc?= =?us-ascii?Q?2KfLx0h1H0Adbn1H22eEMHiyJ9bVO2YSXoVc1FdbjIK+A9BiDoQdYufftJg7?= =?us-ascii?Q?/1SQtNsMwOX5AFRwikF2CkVy8e1rEtC0DDfQEzMYEvLnlCOuiSCNlaAZMU0Z?= =?us-ascii?Q?AtnOQDgpns2XefJEWbFav0U14FioD4stq+PNBQ20clSHdlolgvz3ZEwTxQvP?= =?us-ascii?Q?y1yYuWWFGcffIF45aMvxMNA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5156.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6078b0ce-a7cb-4beb-6927-08d99fb2f7c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2021 16:48:45.8737 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Varp2A5giiL4jHmllitwmvvpSK7Eh/eQ8lmy35+ThrpD3qeFL6cuCuvqK8yj+wcl9Dub9xd9OpIBa/yQTIJSDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5028 Subject: Re: [dpdk-ci] [PATCH v2 05/10] tools: add functionality for setting pw delegates X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, October 26, 2021 5:08 PM > To: Ali Alnubani > Cc: ci@dpdk.org; jerinj@marvell.com; ferruh.yigit@intel.com; > david.marchand@redhat.com; juraj.linkes@pantheon.tech > Subject: Re: [PATCH v2 05/10] tools: add functionality for setting pw > delegates >=20 > 18/10/2021 09:48, Ali Alnubani: > > From: Thomas Monjalon > > > 21/09/2021 16:35, alialnu@nvidia.com: > > > > From: Ali Alnubani > > > > > > > > A new command was added to set patch delegates in Patchwork > > > > based on the emails found in DPDK's MAINTAINERS file. > > > > > > > > Example usage: > > > > $ export MAINTAINERS_FILE_PATH=3D/path/to/dpdk/MAINTAINERS > > > > $ ./pw_maintainers_cli.py --type series set_pw_delegate SERIES_ID > > > > > > > > Signed-off-by: Ali Alnubani > > > > --- > > > > + def set_delegate(self, patch_list, delegate): > > > > + """Set the delegate for a patch. > > > > + Only tries to set a delegate for patches that don't have > > > > + one set already. > > > > > > I'm not sure we should skip patches which are already delegated. > > > If we use the command to explicitly delegate the patch, > > > we should do it, right? > > > > > > The skip logic may be implemented at a higher level in the CI. > > > > I added an arg (--force_set_delegate) to force overriding delegates in = v3. >=20 > Given the command is to set delegate, the force looks strange to me. > Wouldn't it be more logical to add an option to skip already delegated > patches? Isn't it safer not to force overriding the delegate by default? Users can send patches with the header "X-Patchwork-Delegate" to set a spec= ific delegate. Maintainers might want to set another user as the delegate w= hen there are multiple delegates in the MAINTAINERS file for a patch. Shoul= d we override these by default?