RE: [PATCH v3 0/6] Community Lab Container Definitions

[Ali Alnubani <alialnu@nvidia.com>]

> -----Original Message-----
> From: ohilyard@iol.unh.edu <ohilyard@iol.unh.edu>
> Sent: Monday, October 24, 2022 8:44 PM
> To: ci@dpdk.org
> Cc: aconole@redhat.com; Ali Alnubani <alialnu@nvidia.com>; Owen Hilyard
> <ohilyard@iol.unh.edu>
> Subject: [PATCH v3 0/6] Community Lab Container Definitions
> 
> From: Owen Hilyard <ohilyard@iol.unh.edu>
> 
> This patch series contains a new version of the DPDK CI containers. The old
> version was tied very tightly to the Community Lab Infrastructure, so it was
> not suitable for general use. This version is designed to make adding new
> OSes or OS versions as easy as possible. The minimum functionality can easily
> be built on any system that can compile DPDK. It includes support for
> building containers for other non-native architectures (ex: arm containers
> on x86) and for baking ABI references into the images.
> 
> The inventory file as added in this patch series defines what the community
> lab
> currently supports.
> 
> If you want to build these yourself, don't try to do parallel Makefile builds
> on non-server hardware. Libabigail is built into the containers, and since it
> is not avaliable in all distros it is compiled from source for many targets.
> If embedding the abi is enabled (DPDK_CI_CONTAINERS_BUILD_ABI=Y), with
> the
> current settings, DPDK will be compiled twice for every target in the
> inventory file. This will become three times when DPDK main has ABI stability
> again. Due to how the containers are constructed, building on non-native
> architectures is especially expensive because DPDK is compiled with an
> emulated
> compiler in a qemu vm that only has one thread.
> 
> Owen Hilyard (6):
>   containers/docs: Add container builder start
>   containers/inventory: Add inventory for container builder
>   containers/builder: Dockerfile creation script
>   containers/templates: Templates for Dockerfiles
>   containers/container_builder: Container for python scripts
>   containers/Makefile: Makefile to automate builds
> 

Your new patchset versions don't explain what changed in each patch compared to its older version.
See: https://doc.dpdk.org/guides/contributing/patches.html#creating-patches
> Version 2 and later of a patchset should also include a short log of the changes so the reviewer knows what has changed. This can be added to the cover letter or the annotations

Code changes from v2 look good to me. However, git-am warns of trailing whitespace errors when applying the patches.

Tested with podman version 4.3.0.
Tested-by: Ali Alnubani <alialnu@nvidia.com>

Thanks,
Ali