From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFDEFA0C5C for ; Wed, 8 Sep 2021 18:54:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFC1740E01; Wed, 8 Sep 2021 18:54:30 +0200 (CEST) Received: from AZHDRRW-EX01.nvidia.com (azhdrrw-ex01.nvidia.com [20.51.104.162]) by mails.dpdk.org (Postfix) with ESMTP id 233A64003E for ; Wed, 8 Sep 2021 18:54:29 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by mxs.oss.nvidia.com (10.13.234.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Wed, 8 Sep 2021 09:54:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gUhHaQ+Q7edPgL87xvh3nBwLqDgZOLKxASpK1sSmIjAIFBVC2wSYlvWDrxoZ836VKWRALJ7W9GabnxAvpyu2ut4iv+4iGmkiRXiBhAtfQvYG3XyJfFHyBmlb5TOp+6BvH+25fgf5GbTagXQaNmfHGXTGQ5EkQb26YhlDTlrPEStpt0GRAQuV7KVMutm8vyXKWHG6RYKrsH/4SI6xlYv7TY2hd0JRQd/Ca7TcGIuYpSCajpis6mcS3zIICGkNEyTz/jwOK4/+OYh4yFF6Y9wPo8vySgVwofo3yY6fxHFIkI8dkncrMuyQxrk2UEMcIPlYuJCPiODlNLrEzDeePXMtPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Zbq/fPlNICyYoxv2B4cs/NP2GUA4jhv8E41Bvgbb+GA=; b=JC5iaN9FdUejAAHW2YAs7tDwSQVCatpHK6k1w4JWZt5i12hVv/NZoj3eAk4fgv4+4oaJVbZUSQCkU8ksRkp/wkFuvot1n0YzKwXcjFfkgwYyftmxmRWjkgFtUZsiT9iDwa/XVeJ5LRGUwzOcPTUQuM/1ZjRwK/3D44VFtffY1OEgdm70RIXQL0VtpjHrSsnRLy+RoxMpj2pM3+twt10Lk3InHThWydcJweFie+chLUXn7AYlgTc2EhZ+TsQEmHHdZcUARTdBvY8neUU1ScGnyFSj5SQ4npLtIbI3auMjhpqJpnxj17lfNtwLwsNUPGVvbgNA71IEnNB/OnO5sdH0Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zbq/fPlNICyYoxv2B4cs/NP2GUA4jhv8E41Bvgbb+GA=; b=BSpTflgT4TNTJBJA7uO1yFpUjbAdQoJYEBwG5hO9Z5xuJMEhOOc4uDEl75pVMalpJ/qBe+yenEje9dUX6maej5M+iyB+FF+qZOFAfIjx5pgtj8Bl7HgIO80f6jrsH/k9mGXtVg5dsTkPaMjTlzAGcb9r5XXjD1bkTRuXsI5CgHGdM0v9ua3iy7K38iJpVB4DVZB3IjjBeqYJ56J95jEyXhOBxFbzek5ifuJzwMATbwpBXesUI59PcVfJ9nmCwZ+BxzI6PR4wxdVkEyMvbxfrhJcIgrqIyMHje2TR5QFPcwN84TLnS+voyffrz1zQ9oq9FzTOL2EOokXdOSwwCYrX6w== Received: from DM4PR12MB5167.namprd12.prod.outlook.com (2603:10b6:5:396::10) by DM4PR12MB5071.namprd12.prod.outlook.com (2603:10b6:5:38a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 16:54:27 +0000 Received: from DM4PR12MB5167.namprd12.prod.outlook.com ([fe80::5ce5:bfc8:30e7:759a]) by DM4PR12MB5167.namprd12.prod.outlook.com ([fe80::5ce5:bfc8:30e7:759a%5]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 16:54:27 +0000 From: Ali Alnubani To: =?iso-8859-2?Q?Juraj_Linke=B9?= , "ci@dpdk.org" CC: NBU-Contact-Thomas Monjalon , "jerinj@marvell.com" , "ferruh.yigit@intel.com" , "david.marchand@redhat.com" Thread-Topic: [dpdk-ci] [PATCH 1/9] tools: rename guess_git_tree script Thread-Index: AQHXozZiqcEtVlzBPUO5xmEmqBMiL6uYaYkAgAHzUfA= Date: Wed, 8 Sep 2021 16:54:27 +0000 Message-ID: References: <20210906154537.1299-1-alialnu@nvidia.com> <20210906154537.1299-2-alialnu@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: pantheon.tech; dkim=none (message not signed) header.d=none;pantheon.tech; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc234711-ec5d-4562-9203-08d972e951dc x-ms-traffictypediagnostic: DM4PR12MB5071: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0DqSLodjiiLTomr3PRSyf9qi+/opvq0J4GjpfU2CoxL0wS8nz7xlH9aPPBbMR9fjDrgmGbBEtJaKQbyMRbJS848EFHEM45TGiWnc4jRkIXRqYUn7JjbjqfTJ2r6+Hx6oQZpZvyYaQAW1GE2OnY6vgoV6sLFw9POPcz6bX1yA6+nJA0bE45HUhHjX+0Kq9jSkr+vNYeSGIGd0+ejM1JXC+ei84BEALlLBexMWQrBL7G9meFvuo3/czQoC11piRxgYwgOjNcyJBQdHc28Ky55JMdoxH7G8QDtkRzojsw5WDGpQELer94fiOS6bx80/+Cd+UsXtU5qiLEOWQFqJ0l66n5UyJ5PJ/qTT838gecdnQmwC2It9dwxWqxbPbv8Vinnr2DTFzb8r10igSmNe3Rpg1ctQ//oVp1sxtA5BRFGmylRz41y9pfYproNf/5AzFS8jIvjf9kCxM981se0a5H47wtAMVVtR3wk06ZBaHiJpADMe4cg2ALBAW9bHVMd4nrd0IGW6qFdOqQbKoER+xhy+FxYgCwyL+ozDJECi/Lvy+WWeqzZVBEndd+dorU3qDgAXT7nd70kEcjJ/yav0cM/uzoPmGN2MqhoFeOVz5m4Vv0ZNTJ5XKN9ZEX5i2v5wEHb/e5Bn2GtzrDuQCTeMaI13X3Gd31S7wwDteQqRqTdl7+rm2mdQpmuoVUbnIJV5PICkuPTX1qctlJwE1lTZ2VOvVw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5167.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(396003)(39860400002)(346002)(366004)(38070700005)(33656002)(86362001)(186003)(54906003)(110136005)(38100700002)(122000001)(6506007)(55016002)(52536014)(7696005)(53546011)(316002)(2906002)(5660300002)(8936002)(8676002)(71200400001)(26005)(83380400001)(4326008)(66946007)(64756008)(66556008)(66476007)(107886003)(76116006)(66446008)(478600001)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?F04K53oNY7+w+u77Mo5NZrrsiH7HfO9dWjPQyXvpn6H23befZmoOO87TnJ?= =?iso-8859-2?Q?wZEctfyv02SLa/eGuYHcPSCMgSonVXci2nEw1HtjGLl8rc3RES8Sx8/AoB?= =?iso-8859-2?Q?wGs0eiTQm2GiQPTMgrCREeb3Dj+R5oMfyuqGCNQvQfMKjRt4Xewawc3Tkb?= =?iso-8859-2?Q?5xn/v+ivTcmfkPkh2Pv7sICULDjw9UBVwZZ6WqeJDZ8ejH6omzerI6PTYk?= =?iso-8859-2?Q?GUkizZO2Xg8BgEyHhwIE298zE8f+TiffkidT/2bPPpVJehCPIYWFEAn2aC?= =?iso-8859-2?Q?UrI1fspCf9hln3gFF0M3dyHwNJlUSInOCEApQfgAPBOvqUGD79lrdOmgl/?= =?iso-8859-2?Q?spoSuznTdY+pDy9VbTA7kn/UtzMMfIHwU3aLmdKuWFnr6auXGMylTSA1jy?= =?iso-8859-2?Q?nqnz5qKhnjgWitFUv0ddI35wIvNBAtbSCzN2LDYqrf9Pd7yiXr5rz/PYjp?= =?iso-8859-2?Q?8RMZjvByxgnDbi1nySAc3tZHDRaofok/Iveg/tS4E7czpaaWR5YsWG29hb?= =?iso-8859-2?Q?lrjCxqZcD+o4yK3Byiewd9RQO0XZ8j50k7o6jGQUjEebiCxwk4YVU/fnvp?= =?iso-8859-2?Q?r34rgyoY+xCCvNtdlkOEf5ezyyUeJbcHYs8MF17HzKcKoAtbEA10Zuw0co?= =?iso-8859-2?Q?yWqzH7NpEGej2NWUMYHvYrZx2NjBsgORN7ADA1elklzRUB+gYxVTjPwTir?= =?iso-8859-2?Q?IIVuh4UK6UhEdoeQ94QW0tgzAmrjG7WfKwehMt5NqwQvFxJEJEIgST7Zky?= =?iso-8859-2?Q?GDXW+QfCT1KqT32KgkZIarsK0BKS+P3cxscukc8Xzd6j1couPuVnFSr4TL?= =?iso-8859-2?Q?W7mVc8wQVWdQ9UEHmau+BteqX1qlfC+2qKKzvl1SFTR3sY1eIM4CDa8jNP?= =?iso-8859-2?Q?kvGQ4tKtye9aYoeO+6/AId6ZCG8Vti3YZ+qd1VwGz2f2rlssTEcVCcu2H6?= =?iso-8859-2?Q?X2v2xDsnvfGg6mIEHNVeLsYrBnA13ES+iMiZduDosNT6WsSr0LnW1cOqzJ?= =?iso-8859-2?Q?tGPJEnoG4mTqzD0eitpeknkzUkGozsrs81R6hwKOz2CdjiqKrbhLaicdFn?= =?iso-8859-2?Q?YS3MFoXFf/Fyy4FLTL2rmlqlW6jCuOSIxNs10LlBdaDOBRDOGtyMvDE9C1?= =?iso-8859-2?Q?NPPalcjhCRSO+tfpg/bOmbN53ZcQPKdADIDGdjPKRs7ll2AmtqK7wAK7fp?= =?iso-8859-2?Q?6F+axe2ThGyxAIX9DlVruxuA3dI41FNpf3IgUSeG1KmhcOSuN9ksSPynCm?= =?iso-8859-2?Q?aD2YoYSOiyMUs4ujCbn/igyBvkgTnlU+N7mHhTpeSdGjic0wmyjSX8hfhe?= =?iso-8859-2?Q?JI2yR1xNqmHS6g/PCqfP7zW3byQbXoquhxPkj6AAjDLEx17Bh8teByUDwH?= =?iso-8859-2?Q?wNWSvfM4D1?= Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5167.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc234711-ec5d-4562-9203-08d972e951dc X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 16:54:27.5424 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ohbOukBCnX3iNhEuDvKxwgBePs+7P476bhIJub0IXV4/7bnADtG9MirU2ELEQsiNBySctVUv7MauF+NQOedRqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5071 Subject: Re: [dpdk-ci] [PATCH 1/9] tools: rename guess_git_tree script X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" > -----Original Message----- > From: Juraj Linke=B9 > Sent: Tuesday, September 7, 2021 2:03 PM > To: Ali Alnubani ; ci@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; > jerinj@marvell.com; ferruh.yigit@intel.com; david.marchand@redhat.com > Subject: RE: [dpdk-ci] [PATCH 1/9] tools: rename guess_git_tree script >=20 >=20 >=20 > > -----Original Message----- > > From: ci On Behalf Of Ali Alnubani > > Sent: Monday, September 6, 2021 5:45 PM > > To: ci@dpdk.org > > Cc: thomas@monjalon.net; jerinj@marvell.com; ferruh.yigit@intel.com; > > david.marchand@redhat.com > > Subject: [dpdk-ci] [PATCH 1/9] tools: rename guess_git_tree script > > > > The name 'maintainers.py' will make more sense when adding more > > operations to the script. > > >=20 > A noun evokes something non-executable and in my opinion 'maintainers.py' > doesn't describe what the script does in any way. >=20 > As far as I can tell, the script (with all the new changes) gets data fro= m > patchwork and the maintainers file and then processes those to produce a > list of trees, maintainers or updates PW. Maybe name it > pw_maintainers_cli.py? >=20 > Another thing that would make sense it to make the "--command" argument > positional, since it's mandatory and the argument name isn't really neces= sary. > But maybe that's a change for another series. Thanks for taking a look Juraj, I agree with the name you suggested, and I'= ll update in v2. I'll also try to implement your second suggestion in that version. >=20 > > Signed-off-by: Ali Alnubani > > --- > > tools/{guess_git_tree.py =3D> maintainers.py} | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) rename > > tools/{guess_git_tree.py =3D> maintainers.py} (98%) > > > > diff --git a/tools/guess_git_tree.py b/tools/maintainers.py similarity > > index 98% rename from tools/guess_git_tree.py rename to > > tools/maintainers.py index > > c9eef39..0cf1907 100755 > > --- a/tools/guess_git_tree.py > > +++ b/tools/maintainers.py > > @@ -31,13 +31,13 @@ variables PW_{SERVER,PROJECT,TOKEN} should be > set. > > If not, the script will try to load the git configurations > pw.{server,project,token}. > > > > Example usage: > > - ./guess-git-tree.py --command list_trees_for_series 2054 > > - ./guess-git-tree.py --command list_trees_for_patch 2054 > > + ./maintainers.py --command list_trees_for_series 2054 > > + ./maintainers.py --command list_trees_for_patch 2054 > > > > Or if you want to use inside other scripts: > > > > import os > > - from guess_git_tree import (Maintainers, GitPW, Diff) > > + from maintainers import (Maintainers, GitPW, Diff) > > _git_pw =3D GitPW({ > > 'pw_server': os.environ.get('PW_SERVER'), > > 'pw_project': os.environ.get('PW_PROJECT'), > > -- > > 2.25.1 > > >=20