RE: [PATCH v1] drivers/net: use internal API to get eth dev from name

["Yigit, Ferruh" <ferruh.yigit@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 9416 bytes --]

Hi Owen,

I can’t open the link.

But it was initially applied to the main repo, later I manually re-run it on next-net.
Compile error also verifies this [1], ‘rte_eth_dev_get_by_name()’ was added in next-net and missing in the main repo, error is related to API being missing.

Anyway, if the latest script in the CI select ‘next-net’ tree for the patch, I think we are good. Can you please confirm this?


[1]

rte_eth_bond_api.c:(.text+0x12e6): undefined reference to `rte_eth_dev_get_by_name'



From: Owen Hilyard <ohilyard@iol.unh.edu>
Sent: Monday, February 7, 2022 7:59 PM
To: Yigit, Ferruh <ferruh.yigit@intel.com>
Cc: Ali Alnubani <alialnu@nvidia.com>; kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>; dev@dpdk.org; dpdklab <dpdklab@iol.unh.edu>; Kumara Parameshwaran <kparameshwar@vmware.com>; ci@dpdk.org; Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH v1] drivers/net: use internal API to get eth dev from name

The Community CI hasn't been able to schedule downtime to update dpdk-ci across all of our systems since the refactoring Ali did. However, the patch was still applied on next-net and had a compilation error. See https://lab.dpdk.org/results/dashboard/patchsets/20895/. It was applied onto https://git.dpdk.org/next/dpdk-next-net/commit/?id=7445a787de053776616e41ab1d79090bd0f5ce33.

Owen

Here's the build log in case you were having issues seeing it:


[1/1511] Compiling C object drivers/librte_net_null.so.22.1.p/meson-generated_.._rte_net_null.pmd.c.o

[2/1511] Compiling C object drivers/librte_net_octeontx.so.22.1.p/meson-generated_.._rte_net_octeontx.pmd.c.o

[3/1511] Compiling C object drivers/librte_net_null.a.p/meson-generated_.._rte_net_null.pmd.c.o

[4/1511] Compiling C object drivers/librte_net_octeontx_ep.so.22.1.p/meson-generated_.._rte_net_octeontx_ep.pmd.c.o

[5/1511] Compiling C object drivers/librte_net_octeontx.a.p/meson-generated_.._rte_net_octeontx.pmd.c.o

[6/1511] Compiling C object drivers/librte_net_pcap.so.22.1.p/meson-generated_.._rte_net_pcap.pmd.c.o

[7/1511] Compiling C object drivers/librte_net_pfe.a.p/meson-generated_.._rte_net_pfe.pmd.c.o

[8/1511] Linking static target drivers/librte_net_null.a

[9/1511] Linking static target drivers/librte_net_octeontx.a

[10/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_init_ops.c.o

[11/1511] Linking static target drivers/librte_net_pfe.a

[12/1511] Linking target drivers/librte_net_mlx5.so.22.1

[13/1511] Linking target drivers/librte_common_sfc_efx.so.22.1

[14/1511] Linking target drivers/librte_common_cnxk.so.22.1

[15/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_hw.c.o

[16/1511] Compiling C object drivers/librte_net_octeontx_ep.a.p/meson-generated_.._rte_net_octeontx_ep.pmd.c.o

[17/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_init_fw_funcs.c.o

[18/1511] Linking target drivers/librte_net_bond.so.22.1

FAILED: drivers/librte_net_bond.so.22.1

cc  -o drivers/librte_net_bond.so.22.1 drivers/librte_net_bond.so.22.1.p/meson-generated_.._rte_net_bond.pmd.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_8023ad.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_alb.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_api.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_args.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_flow.c.o drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_pmd.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_bond.so.22 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/lib -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/drivers lib/librte_ethdev.so.22.1 lib/librte_eal.so.22.1 lib/librte_kvargs.so.22.1 lib/librte_telemetry.so.22.1 lib/librte_net.so.22.1 lib/librte_mbuf.so.22.1 lib/librte_mempool.so.22.1 lib/librte_ring.so.22.1 lib/librte_meter.so.22.1 drivers/librte_bus_pci.so.22.1 lib/librte_pci.so.22.1 drivers/librte_bus_vdev.so.22.1 lib/librte_sched.so.22.1 lib/librte_ip_frag.so.22.1 lib/librte_hash.so.22.1 lib/librte_rcu.so.22.1 -Wl,--end-group -Wl,--version-script=/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/bonding/version.map

drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_api.c.o: In function `rte_eth_bond_create':

rte_eth_bond_api.c:(.text+0x12e6): undefined reference to `rte_eth_dev_get_by_name'

collect2: error: ld returned 1 exit status

[19/1511] Linking target drivers/librte_net_ipn3ke.so.22.1

FAILED: drivers/librte_net_ipn3ke.so.22.1

cc  -o drivers/librte_net_ipn3ke.so.22.1 drivers/librte_net_ipn3ke.so.22.1.p/meson-generated_.._rte_net_ipn3ke.pmd.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_ethdev.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_flow.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_representor.c.o drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_tm.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_ipn3ke.so.22 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/lib -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/drivers lib/librte_ethdev.so.22.1 lib/librte_eal.so.22.1 lib/librte_kvargs.so.22.1 lib/librte_telemetry.so.22.1 lib/librte_net.so.22.1 lib/librte_mbuf.so.22.1 lib/librte_mempool.so.22.1 lib/librte_ring.so.22.1 lib/librte_meter.so.22.1 drivers/librte_bus_pci.so.22.1 lib/librte_pci.so.22.1 drivers/librte_bus_vdev.so.22.1 drivers/librte_bus_ifpga.so.22.1 lib/librte_rawdev.so.22.1 lib/librte_sched.so.22.1 -Wl,--end-group -Wl,--version-script=/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/ipn3ke/version.map

drivers/libtmp_rte_net_ipn3ke.a.p/net_ipn3ke_ipn3ke_ethdev.c.o: In function `ipn3ke_vswitch_probe':

ipn3ke_ethdev.c:(.text+0x7a2): undefined reference to `rte_eth_dev_get_by_name'

collect2: error: ld returned 1 exit status

[20/1511] Linking target drivers/librte_net_memif.so.22.1

FAILED: drivers/librte_net_memif.so.22.1

cc  -o drivers/librte_net_memif.so.22.1 drivers/librte_net_memif.so.22.1.p/meson-generated_.._rte_net_memif.pmd.c.o drivers/libtmp_rte_net_memif.a.p/net_memif_memif_socket.c.o drivers/libtmp_rte_net_memif.a.p/net_memif_rte_eth_memif.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_memif.so.22 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/lib -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/drivers lib/librte_ethdev.so.22.1 lib/librte_eal.so.22.1 lib/librte_kvargs.so.22.1 lib/librte_telemetry.so.22.1 lib/librte_net.so.22.1 lib/librte_mbuf.so.22.1 lib/librte_mempool.so.22.1 lib/librte_ring.so.22.1 lib/librte_meter.so.22.1 drivers/librte_bus_pci.so.22.1 lib/librte_pci.so.22.1 drivers/librte_bus_vdev.so.22.1 lib/librte_hash.so.22.1 lib/librte_rcu.so.22.1 -Wl,--end-group -Wl,--version-script=/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/memif/version.map

drivers/libtmp_rte_net_memif.a.p/net_memif_rte_eth_memif.c.o: In function `memif_mp_send_region':

rte_eth_memif.c:(.text+0x12ce): undefined reference to `rte_eth_dev_get_by_name'

collect2: error: ld returned 1 exit status

[21/1511] Compiling C object drivers/librte_net_pcap.a.p/meson-generated_.._rte_net_pcap.pmd.c.o

[22/1511] Compiling C object drivers/librte_net_pfe.so.22.1.p/meson-generated_.._rte_net_pfe.pmd.c.o

[23/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_dev.c.o

[24/1511] Linking static target drivers/librte_net_octeontx_ep.a

[25/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_int.c.o

[26/1511] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_l2.c.o

[27/1511] Generating symbol file drivers/librte_bus_fslmc.so.22.1.p/librte_bus_fslmc.so.22.1.symbols

[28/1511] Generating symbol file drivers/librte_bus_dpaa.so.22.1.p/librte_bus_dpaa.so.22.1.symbols

[29/1511] Generating rte_net_ngbe.sym_chk with a custom command (wrapped by meson to capture output)

[30/1511] Generating symbol file lib/librte_port.so.22.1.p/librte_port.so.22.1.symbols

[31/1511] Generating rte_net_octeontx.sym_chk with a custom command (wrapped by meson to capture output)

[32/1511] Generating symbol file drivers/librte_common_cnxk.so.22.1.p/librte_common_cnxk.so.22.1.symbols

[33/1511] Generating rte_net_pfe.sym_chk with a custom command (wrapped by meson to capture output)

[34/1511] Generating symbol file drivers/librte_common_sfc_efx.so.22.1.p/librte_common_sfc_efx.so.22.1.symbols

[35/1511] Generating rte_net_null.sym_chk with a custom command (wrapped by meson to capture output)

ninja: build stopped: subcommand failed.

[-- Attachment #2: Type: text/html, Size: 16061 bytes --]