DPDK CI discussions
 help / color / mirror / Atom feed
* Re: [dpdk-ci] [PATCH] vhost: rename driver callbacks struct
       [not found] ` <SN6PR11MB35040942741F6318830526549C8C9@SN6PR11MB3504.namprd11.prod.outlook.com>
@ 2021-11-03  8:36   ` David Marchand
  2021-11-03  8:38     ` Maxime Coquelin
  2021-11-03  9:10     ` [dpdk-ci] " Xia, Chenbo
  0 siblings, 2 replies; 8+ messages in thread
From: David Marchand @ 2021-11-03  8:36 UTC (permalink / raw)
  To: Xia, Chenbo, Maxime Coquelin
  Cc: dev, Liu, Changpeng, Thomas Monjalon, Aaron Conole, dpdklab, ci

On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo <chenbo.xia@intel.com> wrote:
> Testing issues reported in patchwork is expected as SPDK uses
> this struct, so we can ignore it as SPDK will rename it when it
> adapts to DPDK 21.11

Please, no.
We can't simply say "ignore failure in CI".

The SPDK build test must be disabled in CI first.
You can create a bugzilla and assign it to UNH lab.
Example: https://bugs.dpdk.org/show_bug.cgi?id=579

Once done, we can merge this patch in DPDK.


In parallel, either prepare the patch or talk to SPDK guys to handle
this change.
Once this is done, update the bugzilla so that we can get SPDK build
tested again in CI.

Thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [PATCH] vhost: rename driver callbacks struct
  2021-11-03  8:36   ` [dpdk-ci] [PATCH] vhost: rename driver callbacks struct David Marchand
@ 2021-11-03  8:38     ` Maxime Coquelin
  2021-11-03  9:52       ` Maxime Coquelin
  2021-11-03  9:10     ` [dpdk-ci] " Xia, Chenbo
  1 sibling, 1 reply; 8+ messages in thread
From: Maxime Coquelin @ 2021-11-03  8:38 UTC (permalink / raw)
  To: David Marchand, Xia, Chenbo
  Cc: dev, Liu, Changpeng, Thomas Monjalon, Aaron Conole, dpdklab, ci

Hi David,

On 11/3/21 09:36, David Marchand wrote:
> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo <chenbo.xia@intel.com> wrote:
>> Testing issues reported in patchwork is expected as SPDK uses
>> this struct, so we can ignore it as SPDK will rename it when it
>> adapts to DPDK 21.11
> 
> Please, no.
> We can't simply say "ignore failure in CI".
> 
> The SPDK build test must be disabled in CI first.
> You can create a bugzilla and assign it to UNH lab.
> Example: https://bugs.dpdk.org/show_bug.cgi?id=579
> 
> Once done, we can merge this patch in DPDK.
> 
> 
> In parallel, either prepare the patch or talk to SPDK guys to handle
> this change.
> Once this is done, update the bugzilla so that we can get SPDK build
> tested again in CI.

Thanks for the insights, I'll file a Bz and work with the SPDK team.

Maxime
> Thanks.
> 
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [PATCH] vhost: rename driver callbacks struct
  2021-11-03  8:36   ` [dpdk-ci] [PATCH] vhost: rename driver callbacks struct David Marchand
  2021-11-03  8:38     ` Maxime Coquelin
@ 2021-11-03  9:10     ` Xia, Chenbo
  2021-11-04  2:48       ` Liu, Changpeng
  1 sibling, 1 reply; 8+ messages in thread
From: Xia, Chenbo @ 2021-11-03  9:10 UTC (permalink / raw)
  To: David Marchand, Maxime Coquelin
  Cc: dev, Liu, Changpeng, Thomas Monjalon, Aaron Conole, dpdklab, ci

Hi David,

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, November 3, 2021 4:36 PM
> To: Xia, Chenbo <chenbo.xia@intel.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>
> Cc: dev@dpdk.org; Liu, Changpeng <changpeng.liu@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; Aaron Conole <aconole@redhat.com>; dpdklab
> <dpdklab@iol.unh.edu>; ci@dpdk.org
> Subject: Re: [PATCH] vhost: rename driver callbacks struct
> 
> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo <chenbo.xia@intel.com> wrote:
> > Testing issues reported in patchwork is expected as SPDK uses
> > this struct, so we can ignore it as SPDK will rename it when it
> > adapts to DPDK 21.11
> 
> Please, no.
> We can't simply say "ignore failure in CI".
> 
> The SPDK build test must be disabled in CI first.
> You can create a bugzilla and assign it to UNH lab.
> Example: https://bugs.dpdk.org/show_bug.cgi?id=579
> 
> Once done, we can merge this patch in DPDK.

Thanks for the heads up!

> 
> 
> In parallel, either prepare the patch or talk to SPDK guys to handle
> this change.

Already + Changpeng in the cc list

Changpeng, could you help with the change?

Thanks,
Chenbo

> Once this is done, update the bugzilla so that we can get SPDK build
> tested again in CI.
> 
> Thanks.
> 
> 
> --
> David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [PATCH] vhost: rename driver callbacks struct
  2021-11-03  8:38     ` Maxime Coquelin
@ 2021-11-03  9:52       ` Maxime Coquelin
  2021-11-03 13:11         ` [dpdk-ci] [dpdklab] " Lincoln Lavoie
  0 siblings, 1 reply; 8+ messages in thread
From: Maxime Coquelin @ 2021-11-03  9:52 UTC (permalink / raw)
  To: David Marchand, Xia, Chenbo
  Cc: dev, Liu, Changpeng, Thomas Monjalon, Aaron Conole, dpdklab, ci



On 11/3/21 09:38, Maxime Coquelin wrote:
> Hi David,
> 
> On 11/3/21 09:36, David Marchand wrote:
>> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo <chenbo.xia@intel.com> wrote:
>>> Testing issues reported in patchwork is expected as SPDK uses
>>> this struct, so we can ignore it as SPDK will rename it when it
>>> adapts to DPDK 21.11
>>
>> Please, no.
>> We can't simply say "ignore failure in CI".
>>
>> The SPDK build test must be disabled in CI first.
>> You can create a bugzilla and assign it to UNH lab.
>> Example: https://bugs.dpdk.org/show_bug.cgi?id=579
>>
>> Once done, we can merge this patch in DPDK.
>>
>>
>> In parallel, either prepare the patch or talk to SPDK guys to handle
>> this change.
>> Once this is done, update the bugzilla so that we can get SPDK build
>> tested again in CI.
> 
> Thanks for the insights, I'll file a Bz and work with the SPDK team.

The Bz has been filed:
https://bugs.dpdk.org/show_bug.cgi?id=876

> Maxime
>> Thanks.
>>
>>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct
  2021-11-03  9:52       ` Maxime Coquelin
@ 2021-11-03 13:11         ` Lincoln Lavoie
  2021-11-03 13:16           ` Maxime Coquelin
  0 siblings, 1 reply; 8+ messages in thread
From: Lincoln Lavoie @ 2021-11-03 13:11 UTC (permalink / raw)
  To: Maxime Coquelin
  Cc: David Marchand, Xia, Chenbo, dev, Liu, Changpeng,
	Thomas Monjalon, Aaron Conole, dpdklab, ci, Owen Hilyard

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin <maxime.coquelin@redhat.com>
wrote:

>
>
> On 11/3/21 09:38, Maxime Coquelin wrote:
> > Hi David,
> >
> > On 11/3/21 09:36, David Marchand wrote:
> >> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo <chenbo.xia@intel.com>
> wrote:
> >>> Testing issues reported in patchwork is expected as SPDK uses
> >>> this struct, so we can ignore it as SPDK will rename it when it
> >>> adapts to DPDK 21.11
> >>
> >> Please, no.
> >> We can't simply say "ignore failure in CI".
> >>
> >> The SPDK build test must be disabled in CI first.
> >> You can create a bugzilla and assign it to UNH lab.
> >> Example: https://bugs.dpdk.org/show_bug.cgi?id=579
> >>
> >> Once done, we can merge this patch in DPDK.
> >>
> >>
> >> In parallel, either prepare the patch or talk to SPDK guys to handle
> >> this change.
> >> Once this is done, update the bugzilla so that we can get SPDK build
> >> tested again in CI.
> >
> > Thanks for the insights, I'll file a Bz and work with the SPDK team.
>
> The Bz has been filed:
> https://bugs.dpdk.org/show_bug.cgi?id=876
>
> > Maxime
> >> Thanks.
> >>
> >>
>
> SDPK tests have been disabled in the CI testing and shouldn't run for any
new patches.  Anything that was already in the queue will finish out.  Bug
ticket has been updated.

Who from the SPDK team "has the ball" on this item, so we know it's being
tracked and worked on?

Cheers,
Lincoln


-- 
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 3620 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct
  2021-11-03 13:11         ` [dpdk-ci] [dpdklab] " Lincoln Lavoie
@ 2021-11-03 13:16           ` Maxime Coquelin
  2021-11-03 14:38             ` Lincoln Lavoie
  0 siblings, 1 reply; 8+ messages in thread
From: Maxime Coquelin @ 2021-11-03 13:16 UTC (permalink / raw)
  To: Lincoln Lavoie
  Cc: David Marchand, Xia, Chenbo, dev, Liu, Changpeng,
	Thomas Monjalon, Aaron Conole, dpdklab, ci, Owen Hilyard



On 11/3/21 14:11, Lincoln Lavoie wrote:
> 
> 
> 
> On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin 
> <maxime.coquelin@redhat.com <mailto:maxime.coquelin@redhat.com>> wrote:
> 
> 
> 
>     On 11/3/21 09:38, Maxime Coquelin wrote:
>      > Hi David,
>      >
>      > On 11/3/21 09:36, David Marchand wrote:
>      >> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo <chenbo.xia@intel.com
>     <mailto:chenbo.xia@intel.com>> wrote:
>      >>> Testing issues reported in patchwork is expected as SPDK uses
>      >>> this struct, so we can ignore it as SPDK will rename it when it
>      >>> adapts to DPDK 21.11
>      >>
>      >> Please, no.
>      >> We can't simply say "ignore failure in CI".
>      >>
>      >> The SPDK build test must be disabled in CI first.
>      >> You can create a bugzilla and assign it to UNH lab.
>      >> Example: https://bugs.dpdk.org/show_bug.cgi?id=579
>     <https://bugs.dpdk.org/show_bug.cgi?id=579>
>      >>
>      >> Once done, we can merge this patch in DPDK.
>      >>
>      >>
>      >> In parallel, either prepare the patch or talk to SPDK guys to handle
>      >> this change.
>      >> Once this is done, update the bugzilla so that we can get SPDK build
>      >> tested again in CI.
>      >
>      > Thanks for the insights, I'll file a Bz and work with the SPDK team.
> 
>     The Bz has been filed:
>     https://bugs.dpdk.org/show_bug.cgi?id=876
>     <https://bugs.dpdk.org/show_bug.cgi?id=876>
> 
>      > Maxime
>      >> Thanks.
>      >>
>      >>
> 
> SDPK tests have been disabled in the CI testing and shouldn't run for 
> any new patches.  Anything that was already in the queue will finish 
> out.  Bug ticket has been updated.

Thanks Lincoln, as the patch wasn't merged yet, this API change will not
impact other jobs already queued.

> Who from the SPDK team "has the ball" on this item, so we know it's 
> being tracked and worked on?

I think Changpeng Liu in Cc: is the right contact from the SPDK team for
this. For my information, are the SPDK tests based on their main branch
or on the last release?

Thanks,
Maxime

> Cheers,
> Lincoln
> 
> 
> -- 
> *Lincoln Lavoie*
> Principal Engineer, Broadband Technologies
> 21 Madbury Rd., Ste. 100, Durham, NH 03824
> lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
> https://www.iol.unh.edu <https://www.iol.unh.edu>
> +1-603-674-2755 (m)
> <https://www.iol.unh.edu>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct
  2021-11-03 13:16           ` Maxime Coquelin
@ 2021-11-03 14:38             ` Lincoln Lavoie
  0 siblings, 0 replies; 8+ messages in thread
From: Lincoln Lavoie @ 2021-11-03 14:38 UTC (permalink / raw)
  To: Maxime Coquelin
  Cc: David Marchand, Xia, Chenbo, dev, Liu, Changpeng,
	Thomas Monjalon, Aaron Conole, dpdklab, ci, Owen Hilyard

[-- Attachment #1: Type: text/plain, Size: 2894 bytes --]

On Wed, Nov 3, 2021 at 9:16 AM Maxime Coquelin <maxime.coquelin@redhat.com>
wrote:

>
>
> On 11/3/21 14:11, Lincoln Lavoie wrote:
> >
> >
> >
> > On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin
> > <maxime.coquelin@redhat.com <mailto:maxime.coquelin@redhat.com>> wrote:
> >
> >
> >
> >     On 11/3/21 09:38, Maxime Coquelin wrote:
> >      > Hi David,
> >      >
> >      > On 11/3/21 09:36, David Marchand wrote:
> >      >> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo <chenbo.xia@intel.com
> >     <mailto:chenbo.xia@intel.com>> wrote:
> >      >>> Testing issues reported in patchwork is expected as SPDK uses
> >      >>> this struct, so we can ignore it as SPDK will rename it when it
> >      >>> adapts to DPDK 21.11
> >      >>
> >      >> Please, no.
> >      >> We can't simply say "ignore failure in CI".
> >      >>
> >      >> The SPDK build test must be disabled in CI first.
> >      >> You can create a bugzilla and assign it to UNH lab.
> >      >> Example: https://bugs.dpdk.org/show_bug.cgi?id=579
> >     <https://bugs.dpdk.org/show_bug.cgi?id=579>
> >      >>
> >      >> Once done, we can merge this patch in DPDK.
> >      >>
> >      >>
> >      >> In parallel, either prepare the patch or talk to SPDK guys to
> handle
> >      >> this change.
> >      >> Once this is done, update the bugzilla so that we can get SPDK
> build
> >      >> tested again in CI.
> >      >
> >      > Thanks for the insights, I'll file a Bz and work with the SPDK
> team.
> >
> >     The Bz has been filed:
> >     https://bugs.dpdk.org/show_bug.cgi?id=876
> >     <https://bugs.dpdk.org/show_bug.cgi?id=876>
> >
> >      > Maxime
> >      >> Thanks.
> >      >>
> >      >>
> >
> > SDPK tests have been disabled in the CI testing and shouldn't run for
> > any new patches.  Anything that was already in the queue will finish
> > out.  Bug ticket has been updated.
>
> Thanks Lincoln, as the patch wasn't merged yet, this API change will not
> impact other jobs already queued.
>
> > Who from the SPDK team "has the ball" on this item, so we know it's
> > being tracked and worked on?
>
> I think Changpeng Liu in Cc: is the right contact from the SPDK team for
> this. For my information, are the SPDK tests based on their main branch
> or on the last release?
>
SDPK branch should be their current LTS branch (21.1.x), so not the main
branch.



>
> Thanks,
> Maxime
>
> > Cheers,
> > Lincoln
> >
> >
> > --
> > *Lincoln Lavoie*
> > Principal Engineer, Broadband Technologies
> > 21 Madbury Rd., Ste. 100, Durham, NH 03824
> > lylavoie@iol.unh.edu <mailto:lylavoie@iol.unh.edu>
> > https://www.iol.unh.edu <https://www.iol.unh.edu>
> > +1-603-674-2755 (m)
> > <https://www.iol.unh.edu>
>
>

-- 
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 6000 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [PATCH] vhost: rename driver callbacks struct
  2021-11-03  9:10     ` [dpdk-ci] " Xia, Chenbo
@ 2021-11-04  2:48       ` Liu, Changpeng
  0 siblings, 0 replies; 8+ messages in thread
From: Liu, Changpeng @ 2021-11-04  2:48 UTC (permalink / raw)
  To: Xia, Chenbo, David Marchand, Maxime Coquelin
  Cc: dev, Thomas Monjalon, Aaron Conole, dpdklab, ci

I'm on it. SPDK is using DPDK 21.08 now, we will bump to DPDK 21.11 in next SPDK 22.01 release.


> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Wednesday, November 3, 2021 5:10 PM
> To: David Marchand <david.marchand@redhat.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>
> Cc: dev@dpdk.org; Liu, Changpeng <changpeng.liu@intel.com>; Thomas
> Monjalon <thomas@monjalon.net>; Aaron Conole <aconole@redhat.com>;
> dpdklab <dpdklab@iol.unh.edu>; ci@dpdk.org
> Subject: RE: [PATCH] vhost: rename driver callbacks struct
> 
> Hi David,
> 
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Wednesday, November 3, 2021 4:36 PM
> > To: Xia, Chenbo <chenbo.xia@intel.com>; Maxime Coquelin
> > <maxime.coquelin@redhat.com>
> > Cc: dev@dpdk.org; Liu, Changpeng <changpeng.liu@intel.com>; Thomas
> Monjalon
> > <thomas@monjalon.net>; Aaron Conole <aconole@redhat.com>; dpdklab
> > <dpdklab@iol.unh.edu>; ci@dpdk.org
> > Subject: Re: [PATCH] vhost: rename driver callbacks struct
> >
> > On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo <chenbo.xia@intel.com> wrote:
> > > Testing issues reported in patchwork is expected as SPDK uses
> > > this struct, so we can ignore it as SPDK will rename it when it
> > > adapts to DPDK 21.11
> >
> > Please, no.
> > We can't simply say "ignore failure in CI".
> >
> > The SPDK build test must be disabled in CI first.
> > You can create a bugzilla and assign it to UNH lab.
> > Example: https://bugs.dpdk.org/show_bug.cgi?id=579
> >
> > Once done, we can merge this patch in DPDK.
> 
> Thanks for the heads up!
> 
> >
> >
> > In parallel, either prepare the patch or talk to SPDK guys to handle
> > this change.
> 
> Already + Changpeng in the cc list
> 
> Changpeng, could you help with the change?
> 
> Thanks,
> Chenbo
> 
> > Once this is done, update the bugzilla so that we can get SPDK build
> > tested again in CI.
> >
> > Thanks.
> >
> >
> > --
> > David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-11-04  2:48 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20211102104748.57078-1-maxime.coquelin@redhat.com>
     [not found] ` <SN6PR11MB35040942741F6318830526549C8C9@SN6PR11MB3504.namprd11.prod.outlook.com>
2021-11-03  8:36   ` [dpdk-ci] [PATCH] vhost: rename driver callbacks struct David Marchand
2021-11-03  8:38     ` Maxime Coquelin
2021-11-03  9:52       ` Maxime Coquelin
2021-11-03 13:11         ` [dpdk-ci] [dpdklab] " Lincoln Lavoie
2021-11-03 13:16           ` Maxime Coquelin
2021-11-03 14:38             ` Lincoln Lavoie
2021-11-03  9:10     ` [dpdk-ci] " Xia, Chenbo
2021-11-04  2:48       ` Liu, Changpeng

DPDK CI discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/ci/0 ci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ci ci/ http://inbox.dpdk.org/ci \
		ci@dpdk.org
	public-inbox-index ci

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.ci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git