From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FB9842672; Fri, 29 Sep 2023 12:54:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CFA4402AA; Fri, 29 Sep 2023 12:54:34 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id DB23840287 for ; Fri, 29 Sep 2023 12:54:31 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38T27Uss020589; Fri, 29 Sep 2023 03:54:31 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3tcrrs8au1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Sep 2023 03:54:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=go/Cuxh0FOiBs39VtspFNsalZMNo/Y1kxjDztXfWM2NIkYEGIptqqpuWS5GE9Ymtd+Qn8B0QLig61qKSLIlbK7qJUJJhIuA6sBkSykdpHHiPYRp0n3cF5QipO6XcnJmlB9Jsuxl5GkFvaZgl61gRj78cDobcTBXbJxaj2UniNjDwpb3iAWG8G+i2VqEK5G+BDf1RNlIJ3TeB3oUhQJIC55tBKLnNi2nXv9tKUBrWewmMda7B0638o9BsN03JvQaSCUKRr84fJHkjWIN2nokUUcoMMqpwlymIQLTAseOfwCcg8Pdn3cstOECEGdRZPpQDLXguggUdgFMfESLdRPjN7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BjgYUq8GGqXO9rNaTNuC5I8b9ySI1gdbNMuhcrSFMNE=; b=P7DPX767S7oVDuXpkf3zN7MnLy4noOqjKuDJaDkW7f+W7i7DuiHd/2eQHVP83Enwn6zkHCUgvUBEN3RCVO+vsuaJrJ07SXs7WQSVXfqBikuA76ueRQpmA/BdvsxpOMO6bw5ltByxxz5RoT5MzQGtbNSSoscD/cm9x2zamVMwK+9y6SMxdUUSuIUZYxfImVIoNxX/Qv2M61qpkJmoCjJYGuExJ8+5Y0eq4rX/NV04CIewwMwCiH3v78ca3Wb2sspcjvsNZjOCowxzML49Hpd3jcXw2Qh0Zo04sT9ZPJk3/o1+OVPESO0U9IBDg0phYs0ABDrnwtPtZv86M+kf+Z2ibw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BjgYUq8GGqXO9rNaTNuC5I8b9ySI1gdbNMuhcrSFMNE=; b=kgDjtp8Ty1HQyrgl4CrLS+T+Wb/DCx+7wOgUYFhsVZ5BYditpWGf5I3GgiszZAHMLcPhq7457JQdJS2O0C20rCwSZPYg2/TmGfo5sqcczGyT4bXHPFH4k0aoE8b4jerJX6kYC/QWaecLdZEZNSawWfPVvq4fajk43e5J6jjnz9M= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by DM4PR18MB4317.namprd18.prod.outlook.com (2603:10b6:5:398::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.23; Fri, 29 Sep 2023 10:54:26 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::e6de:4d63:8f64:f0b1]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::e6de:4d63:8f64:f0b1%4]) with mapi id 15.20.6813.017; Fri, 29 Sep 2023 10:54:26 +0000 From: Pavan Nikhilesh Bhagavatula To: Thomas Monjalon , Jerin Jacob Kollanukkaran , "alialnu@nvidia.com" , "aconole@redhat.com" , "ci@dpdk.org" Subject: RE: [EXT] Re: [PATCH] pw_maintainers_cli: enhance tree selection Thread-Topic: [EXT] Re: [PATCH] pw_maintainers_cli: enhance tree selection Thread-Index: AQHZ8q/UXHA2AM0+ik2PxR9CEJEf3rAxhtxAgAARQQCAAAaOQA== Date: Fri, 29 Sep 2023 10:54:26 +0000 Message-ID: References: <20230929083443.9925-1-pbhagavatula@marvell.com> <4320151.8hb0ThOEGa@thomas> In-Reply-To: <4320151.8hb0ThOEGa@thomas> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4086:EE_|DM4PR18MB4317:EE_ x-ms-office365-filtering-correlation-id: e980b1a0-1c4b-4f3b-f63b-08dbc0da72b0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2I2pr4HeG6/iWdBHkihzKHP1hSaIhG8nNtHAKLWtqDqedVc2Qu4qapY90Mq7Pp3G56QnUH/8Hm+eTZYcixJuZYeZLOrlzzhrxv/oK2nI3ouJafz+nZvyFGLrJ/rZ2m9NDSkDAmDXwxgalevkL+zX/n7A1TJp1gxWym+TMG9G4TbM+cvqpVsGkge92WFfpnRLwDZjmty/xXQLLxH5BPQ2wh79FOiwufRrryrRXOTcy0V99dbfICgqXbaocDGMjn/dlF6OrNOP8UlkG9QOIFOCkcioA8kyzvzzn/syOjnRPGtcLjihJfAeRJjF5Xa9FfTvu2MGORsH7ADwATx+ZDmfyPnTu12HOKmBs4HXM7JqZhMbw0R69/8nsXnXJNWLWye9RsGvLd+Zm0+a4cY+OvdfbpquYgKPeQnNoaD314O4v+WFzAEDnFSUOb0PG5gGvYfvNGQwLCzeVD9WzrGf9bOG5BvUMHACT1ylucyB7shwND8irTAPazvOt3ZMSf2ZhgPAO0hR/A4EYaJO9x45gy+NVnk45tSUljjVeaOdG55MX9tG1lfyUCco1r1Xtl7vZCwzjaZNWuL6cgCPR/q4ezpYtw3UUxBachRwnb1lybV9bh0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(136003)(39860400002)(396003)(376002)(346002)(230922051799003)(64100799003)(1800799009)(451199024)(186009)(33656002)(86362001)(66556008)(55016003)(71200400001)(6506007)(478600001)(966005)(52536014)(110136005)(53546011)(66446008)(76116006)(66946007)(64756008)(66476007)(7696005)(5660300002)(316002)(26005)(41300700001)(8676002)(8936002)(2906002)(38100700002)(9686003)(122000001)(38070700005)(19627235002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jm5/+OHznJSRUwbKhv+3wmprhxDdUXhoeEprsMbA9UghpZ7wTPZ5+VBoAbjk?= =?us-ascii?Q?X3ZAb89K0fLlXej2PvAGb2jinDE03kZWJX/Kh276atFsQpuRX8yV3xUaS8wY?= =?us-ascii?Q?/l38Vofgz/SvVbfd+Ck+vct9XcQPmkQvD9NhjJjkihGIXEtnPX8s/nBsPO/M?= =?us-ascii?Q?ohGXWOAiV+SeaduNjl00Ib9NPsYzCBNSd0SlvLp2HulNCohqksy/Fc1RDEXC?= =?us-ascii?Q?WEdKjhu3lebzxSedAiXTZcNWCllkXdXEAN15rmELm7Yqzd6vR9ryoByjCAT4?= =?us-ascii?Q?psW/xidAwlbmF66vNDXrHyn7hokN1GavvWlP4+2jVKJ7eOOg1J/rnEjIHQrX?= =?us-ascii?Q?UoDi9dlstZH9Mpr4tYdkoSReUrCxansWoyO+fslkoDvqf3w4N5fXbu3l00sA?= =?us-ascii?Q?rEaSm2SyoGuCaiHqT0KA0RBOxLHsADd0M8R7lxMMbn52MEY4C3Csro83z1Fc?= =?us-ascii?Q?9TfTLiq8gqG0o1Ikpg6M1XC1Fw7w7vbp5umKeh3QBxtljnlXyPKLnzEIUmOG?= =?us-ascii?Q?R6R9O618FUe/F22F8RfimOlNHOK9RdCZFytROwRjn1flq4kdfoW0UGIXdyH+?= =?us-ascii?Q?OkxAaV4rNFTuk0JFGL4Has/xkSh9JH0XMpl1yoGvrH+GTkQYTBjzxY9uAKvA?= =?us-ascii?Q?+f9rfpgVTwy/uD+cEMUSTvHB8gxwvAh0RdXG2IT1yA/mwfMIyO5fe/5t6n4/?= =?us-ascii?Q?Uq9hDGSvl7do8R6+pB4/B4ztZ8aKG9gLXwE61j2mDuCGGfMQcdkBk9P0FV6A?= =?us-ascii?Q?IvJd6WEIN4H9+wpHw2Hpvgk6D2IBIonvAQE7BxpLowq0y/9TLeElxhkZMj3G?= =?us-ascii?Q?VXwvW28ck8hu+338qRh/TFzmJ7uyTnsHAr4V51osAe1yzpG6VG4xYHEHT8oP?= =?us-ascii?Q?3Mvrt9oumy+w0Q9BVgtSSQ4V4R9MM8pHpqEd/u7IHi72RO2ew45m6uNBldEE?= =?us-ascii?Q?jEQD6MvbcUJ/lRFBY5Vt46yMzdxBq70xcgHijyfUKyMJnTHayPsXcsZwGG0/?= =?us-ascii?Q?J/MKomHFXvI0r7PsTQloqYE1Yjqycyjwagt2lZw41/NzXeUsIab8f815zGmn?= =?us-ascii?Q?WmG3mEsRSmvXnfELkz7OhTwacq3rpKuUWllx0l+rWtNC2TyVHZ6+NaRIl6w+?= =?us-ascii?Q?CDAjYOWFVOLjlQGN5Xgenc6r5IdDS3ZD4Sa28fCSxeRDqA/NQGOzOrljh0Vy?= =?us-ascii?Q?6Z9KHcbA45wX51rov66XfIpXiwZiTgPQ3DU7pTplMxHTroG5gSKv7SaugPoK?= =?us-ascii?Q?c1CH0R6ROx9j8dSUgFhfo4iyv0x2o0LxKg+JvjC3Htd/wngXTSKyaMgqXolg?= =?us-ascii?Q?OffAEYojfc9loCh3rjdTA3AuvnzoLEdlQSeCxr+athQB625r7YySEUQMr16B?= =?us-ascii?Q?E5nKDZp2VypEIVWEu0ThCSoVrE3pIfciwf83W8KepL2Qg8cdh4IN33e2qLHO?= =?us-ascii?Q?gOwY/6CuoFozqXBD92dVBiCiCFbfGQt9zmQB0oWHf8J6MAuJPW7UzCJzT20c?= =?us-ascii?Q?FTIwJr2TB7+93jO3+IqhacCvqi69uf8BGmi6UVolBE5GQlIY6+BNDowOTsQH?= =?us-ascii?Q?n+3QT1q5Poy8hMKKOg7rCKyrQHYHNrijDFZOyFgZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e980b1a0-1c4b-4f3b-f63b-08dbc0da72b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2023 10:54:26.2666 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uUUL7gYkzSShV66OueTyCno7WU2e+LMtWOk1s0HEdgSczHwNBRlCGYN8o7txWTm7Kd+IWtW9BOglKdKT39Z+EtPLaHzRgUn5KKkpRiom+60= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB4317 X-Proofpoint-ORIG-GUID: 3SbZ15ydDFWyhSxNkP38M-pwRi4PAxno X-Proofpoint-GUID: 3SbZ15ydDFWyhSxNkP38M-pwRi4PAxno X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-29_09,2023-09-28_03,2023-05-22_02 X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org > > > > > -----Original Message----- > > > From: pbhagavatula@marvell.com > > > Sent: Friday, September 29, 2023 2:05 PM > > > To: Jerin Jacob Kollanukkaran ; alialnu@nvidia.co= m; > > > aconole@redhat.com > > > Cc: ci@dpdk.org; Pavan Nikhilesh Bhagavatula > > > > Subject: [PATCH] pw_maintainers_cli: enhance tree selection > > > > > > From: Pavan Nikhilesh > > > > > > When longest prefix match doesnt find a suitable tree, pick the > > > tree which has the highest modified file count instead of defauting > > > to main tree. > > > > > > > This change is need to find the correct branch when a patch has a > specification > > Change followed by a implementation of driver layer example: > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__patches.dpdk.org_project_dpdk_list_-3Fseries- > 3D29675&d=3DDwICAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DE3SgYMjtKCMVsB- > fmvgGV3o-g_fjLhk5Pupi9ijohpc&m=3DWKN1erKSjH9MuEyyRs- > R3jYC5geZeUeNipx2GQlQpQSuQQCet70Torr1oSdZNvZp&s=3D6XFs2Ggg5G0VFd > YEaRexumEXM5JKc2vs5dmrRNcIUZw&e=3D >=20 > That's expected: when a series touches more than a tree scope, > it goes to main. > But that's not the issue here. > Both eventdev lib, test and drivers belong to the eventdev tree. > So why it is not already delegated to eventdev? > Please dig more. >=20 >=20 The main issue is the driver implementation touches common/cnxk which ties = it to=20 next-net-mrvl tree which causes the conflict. We have few options here,=20 1. Based on max number of files touched per tree (Current patch) 2. Ignore driver/common from tree selection when there is a conflict with = other tree. 3. When there is a conflict between trees choose the common tree instead of= company specific tree=20 Example, dpdk-next-eventdev + dpdk-next-net-mrvl =3D dpdk-next-eventdev