From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F8BE43008; Wed, 9 Aug 2023 12:00:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DA3940691; Wed, 9 Aug 2023 12:00:49 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 02830400D6; Wed, 9 Aug 2023 12:00:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691575247; x=1723111247; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=J4SKfoki+mIUaQtpBR2O4OvaUtE9rPmU2tCO6YyoZfs=; b=TfI05uOCnHjptn7NV8LcOfMQKUnc3zAsKCmTaRiibnGQF2vgA7tG3mGM We5F8NSzwrL8BjBz1yPTwM6O35aWyWgK1w2X13aw7v+VUwuDsAaRmuuLt IanOf5eDuxvhTGZpFFVjs7pj/2i0yKl/yRZqYhXH5At30QJxfjp1DE5pH 8GqnGQzi4OD33GzxyOwotUX6tGrtgzTirKzO96GlVZkMI5s3KNL5tGGVZ 4WZvDwIXodSh74U57hFPhZFh3GqcWbEgRwL2wpuvbmHAsJlsQoV2MLDsk IT4+N89HE8xPPgPzEmPb1YLFQAH8Y7be1dIqUNyXBgGzPQyljWmr0732c g==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="437448642" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="437448642" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2023 03:00:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="708654476" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="708654476" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 09 Aug 2023 03:00:45 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 9 Aug 2023 03:00:45 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 9 Aug 2023 03:00:45 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.45) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 9 Aug 2023 03:00:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RQeOi68yT6kb1+c7SUWCUtnRYZNgH/g50RaPMfpuhrvUTMfW34xk+VROvOjbWuR9d/uD9q8a1FrvUbv62eGq8pYPXsWg0JKvqZNZSP9f/fr61/cCuMj7IY/ChPMOcrf6EkYmhvttyfc3M54QEOSfaF+Y215lWoROv8x0EPZe8L0rABzn9fI9GbddELqKY5c7jPUVq5FMr4Gb1bshZelzhIq7+2THOa2trEc3oBX7Lppd77PYWWlxF3OQKctGYEInd1hG1WnOdm3+/8eZ2euyRMV96QzxbpTAPKWm58iqy0GPUiwqJcD8ANH+TdAvcFk6r1Rvfx3klMhGAMPONY9qVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l4pRTV2uEjVJktfJvbFYRBFKiYps4RDI5OLgCWcH7CU=; b=cPaaCjQ5/HjxLQAwlIR/fq14CAl18Z0u88fwWEjAarEDRj0KlwaBOLBfuKWoN3SSD26QUUwDcWKJPVVIsExGjS4uat0oRgoFmsIGrTpNf+2xaeIVYmiDDkbDqcbTsT3Z5UMzhXaVJCBhgLMIhEUZq2A1ht6VDCB2gpYDQdDy+MWbUyDnmg1iNkQQXUDQGJyvgAJjD1m/7cG262vcUgcklmbv+0RrQj1JPJ+yyn1JXcsNc8j3zKCttHqwubCJSWBAIndcE8QKI9pufsDuq1ewWot34V+vHWHRxi1qgKXsIbf7CsGDlX5PL5KSX9O7mNCvZiK9BYPxkWZ51N+/se5TOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS7PR11MB7784.namprd11.prod.outlook.com (2603:10b6:8:e1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Wed, 9 Aug 2023 10:00:43 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6652.028; Wed, 9 Aug 2023 10:00:42 +0000 Date: Wed, 9 Aug 2023 11:00:35 +0100 From: Bruce Richardson To: David Marchand CC: , Morten =?iso-8859-1?Q?Br=F8rup?= , Tyler Retzlaff , Subject: Re: [PATCH v7 2/3] log: separate logging functions out of EAL Message-ID: References: <20220829151901.376754-1-bruce.richardson@intel.com> <20230731153902.2350026-1-bruce.richardson@intel.com> <20230731153902.2350026-3-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2P250CA0026.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::31) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS7PR11MB7784:EE_ X-MS-Office365-Filtering-Correlation-Id: 615b0210-8a9e-47a9-92c5-08db98bf7dd9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FL2JxxQFcU7mEwymZE/pDZAh5hPfxJ7Tuv0g5Fbrcy/lQ4h8fl1kPPjTRGFvSuLIcP01C4e8Yjn2UVdQ2SMX7PmAnrkjp93HVZfCvLtua66uoGlKwnAkmmU8L3V+Hhvrks7C6hxUdRi0lGF8QSOhvGhjw6AjFVko1jDlGlVFJ2KnAIktGzbzMOcX+Mwe7JP3TaG44K5VZuldZMuG0fymDNauKaqQWLXAZZBHL//DvAw96pHVneKAg63UjoJb3msFbFsnyg9tdo3+nXPxaT4Rfz9SBAoul2kAGEUFu3v9TbvmClpDINdKmzg2niIk8fFZBVZ115EaMaBK04Y2JG2x6FMvTk/oMNLF1V08uuepF7mNUpjNbTBe12tuHQJCVFsobNqpvcSRMAbJBTbEPGVMrXox7eZdBKRn5zxv0W8UJwPqKgRZrlMfSZ3d+cAODdUc7NEKJIgggEJQW7Z2XeMlCidpsYBEV2JuMwKAUds52BMbFD7tE/N4/VtMMk1+Fjgkb0XpIPHHLKaeVMSjXan7EuEbU0GwLGxBZUzbjExBLo0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(376002)(346002)(366004)(396003)(39860400002)(451199021)(1800799006)(186006)(6512007)(478600001)(54906003)(83380400001)(86362001)(53546011)(26005)(82960400001)(38100700002)(6506007)(45080400002)(6486002)(6666004)(5660300002)(316002)(4326008)(6916009)(66476007)(66556008)(66946007)(8676002)(44832011)(8936002)(41300700001)(966005)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWRBd2hJSzd4NE95cmhnZzZuS2hLVnJVWVpGbjFFZmhYL0RDNXowWGJxM0Zz?= =?utf-8?B?QmFCeVlWOEREK1pOazBocHNYRTJvMVF3VjB3VEF1K1BEaXV2UHdPQVc0OXc1?= =?utf-8?B?a1lFM0NaQWM4cldkRUx2dFVWTm5FMTdXd3VpN2lFeS9FOHhlM2I2Y2J4YVFE?= =?utf-8?B?MHZiMWVmM2ZLR01mN1d6MTgzSDZHcEhNbDBLNE9Nc2RWaGF5L3V6STBsa0FB?= =?utf-8?B?RUNBMHRZZkhyaGtBNVd0eTAvdmFIZWw5WVpDU3BaYkhTNlcxZVh2dUVnclR1?= =?utf-8?B?Wm5ZellENXdycmNIanIvYi9mZEpFdDBVQlVJNDBERWJlUVR5SGtqMTdxWGVi?= =?utf-8?B?b1lhcVNFYUxxZkdJZ1Z1NzhnYkxXTDFVL1lSdHdWU2JocGpYL1RWU0Yvc0du?= =?utf-8?B?MUJ5U05Nb0dRWUI5cVpaaW1wRHlzSDkzbk53L2UrVFVUSUFCblIwMkpQc0FO?= =?utf-8?B?eWtlbFVaRTRPRTRGVkU3S2tuY3hpUVFBNnJnTkJRdURHanNJck5YK25JYnQz?= =?utf-8?B?cnNpQWcxalVVdDFNV2hsZ2tOdGkzQ2pPQytOS1d3NlFVOXdVUHJ2SnN4N1gz?= =?utf-8?B?bXZpYXE0Wnp6enVPclBmQ2ZucjRKN1B2eG9uazdVQkZOK3ROL0Y2Uk1PUlNy?= =?utf-8?B?T2IycU9hYThCcHdQeHRiM0RseUFkRjk5b1kxM3IxUlNyc3lZbnU5VThUNCtk?= =?utf-8?B?WUw2WG9qVGxCK3pFRzY1Q3krbmp0YTY0YlF4eU1EdVNMSzdTdUhGempFWGxD?= =?utf-8?B?N2VtS1pWd0NpajVzaC9oUG8yTGhqNmJLOTZ5Y0tUR1BkWXQwZ1ovOXJJRW5Q?= =?utf-8?B?YzBMSE14bzMzSXJ1RUpSc3Z0cjhuN0Q2TElXNWxNa1Yrd29yZ0FFbXlhSHdX?= =?utf-8?B?MWhNTXZ2UFk0SndrSE92Zk9KK0hEemtmeE5rWXhVUE1KckVBdTNWSUNFRmVs?= =?utf-8?B?TEhRYkJkNEpJM0pVeU5MSWw4bDhtbGNuM2QxZnpjV2NuY2pSaEh5LzBuUG84?= =?utf-8?B?V0lad1l5dUMzNVFQaW0xMGxMdUg2amNSWXRlbDVEOFZwYkI1c1B1Z3NWOWdt?= =?utf-8?B?aSsyN1cvVnlTYzI2ci9ySnZLdFpHdGtqV2ZiL1krSjRKMXQwakkvNHczVlQv?= =?utf-8?B?VlNkaSsvVVJIWVFhUHVZcGVWZCsrSmk1WjdMTXV4dmRpOUtVQy9TL2p2L09I?= =?utf-8?B?N0VPSnhxaS81RkJiUDQ5a1VNeHBBYmF2Y2NRd0NDRWpwaERNelhIVW8vcXQz?= =?utf-8?B?V0hNQzVNbnhwNWlWOEpFK214RzZobnFrbm9yOXVwN3F1QlBiU0M4bGh2anEw?= =?utf-8?B?aFFyOVo0RE4vTjMxeXBkeHNyK0RVcTdoM0tsOEVRcnBVMjl4aGRIK3UxaHp6?= =?utf-8?B?M1JFcXdzR243Q2VnZU9KcjFHOFRJeC9DdGFzUmRCc2FpZ3c3d2pnSVJZbVhE?= =?utf-8?B?bVdmUjZ6Y1ltdGFKMUhZd1FDaGZRSjRrRXdvNXphWmZkUWdTeDJhZUpQV0k4?= =?utf-8?B?bE5rTHUwbU1GYnd2T2Z5c0dwaVFIMkFDa3ZOMm9UTlBOWXZZZ1JvMXh0SHFW?= =?utf-8?B?UFNCZDc2ZkZGMEo4cVhsSEl3WnBxQ2x5RWFsSXJQdzFpNzhXalJQQW1DYzJZ?= =?utf-8?B?Vy9hVm1ockZtUmhJWG1GV0t6c3dWMHVjcldCRDh1V1lnZUZXUlEzMHhhendB?= =?utf-8?B?bkNCT1pZZml6VGdHRFhKN3NrZnREM2pwY2I4cUhkRTBNMTh5R0dzWXlMaEZX?= =?utf-8?B?NmtsVzgyMjBVRVZkSE5QZkIrY09rQjVOR09VQ09WOXJmbWt6Mk5xUzE4a1VH?= =?utf-8?B?YXhCem1waWdmU3dnU0EybWhqKzhpaWl6cmIrK0FEZ2VvQTJDQWJTU0tHTHZl?= =?utf-8?B?MWhlV0dSR3hzcnNnQk03a21hc3QxYitsSlRUZlV6NXVSLzJhU1BoMEsrcjJa?= =?utf-8?B?L3dOb0tFeFBRQkppZG9SL1NpVVFZMWFMVE1PY3lzTjVyZ09QaE04RDMydUJI?= =?utf-8?B?Y0tBY2dtZVVWRjhveTk1MllFcUljVjJWMDlTS3BDYzRjUlRnODVUMlpKOXdn?= =?utf-8?B?NzlBSmk5d08zcGFaYWJOM0VEa3ZhMTBuSmhZRFBDMENOWTVtcUJrZG5mUjBU?= =?utf-8?B?THR6dytyQTlxYWJ1QjdiMnk3b0xXMnFiTjU5Vlp0U3RXQ2UvMzVKb09wM3hI?= =?utf-8?B?YWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 615b0210-8a9e-47a9-92c5-08db98bf7dd9 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 10:00:42.2773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N+QnBDpGuUSadX5HWO1xle9jhFS+54jeeVbyYoniB0DKjlGjuXns1au8b7YTvPWBCqISwLlnN07U9RdwNvpHRLU+CsknUZ2LGuUUl3+BfKk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7784 X-OriginatorOrg: intel.com X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org On Mon, Jul 31, 2023 at 05:29:04PM +0100, Bruce Richardson wrote: > On Mon, Jul 31, 2023 at 06:22:40PM +0200, David Marchand wrote: > > On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson > > wrote: > > > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in > > > index 1a4210b948..40f7dd2877 100644 > > > --- a/doc/api/doxy-api.conf.in > > > +++ b/doc/api/doxy-api.conf.in > > > @@ -52,6 +52,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \ > > > @TOPDIR@/lib/kni \ > > > @TOPDIR@/lib/kvargs \ > > > @TOPDIR@/lib/latencystats \ > > > + @TOPDIR@/lib/log \ > > > @TOPDIR@/lib/lpm \ > > > @TOPDIR@/lib/mbuf \ > > > @TOPDIR@/lib/member \ > > > > In case you are wondering about the reason.. the Intel CI reports an > > error on building the documentation: > > > > *Build Failed #1: > > OS: UB2204-64 > > Target: x86_64-native-linuxapp-doc > > FAILED: doc/api/html > > /usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html > > /usr/bin/doxygen doc/api/doxy-api.conf > > /root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/doc/api/doxy-api-index.md:230: > > error: unable to resolve reference to 'rte_log.h' for \ref command > > (warning treated as error, aborting now) > > Traceback (most recent call last): > > File "/root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/x86_64-native-linuxapp-doc/../doc/api/generate_doxygen.py", > > line 13, in > > subprocess.run(doxygen_command, check=True, stdout=out) > > File "/usr/lib/python3.10/subprocess.py", line 524, in run > > raise CalledProcessError(retcode, process.args, > > subprocess.CalledProcessError: Command '['/usr/bin/doxygen', > > 'doc/api/doxy-api.conf']' returned non-zero exit status 1. > > [2772/2774] Compiling C object app/test/dpdk-test.p/test_ring.c.o > > [2773/2774] Generating doc/guides/html_guides with a custom command > > ninja: build stopped > > > > IIRC Intel CI excludes changes on the doc/ directory when applying patches. > > http://inbox.dpdk.org/dev/CY5PR11MB618735108D3E9D90C67EEF96F5DA9@CY5PR11MB6187.namprd11.prod.outlook.com/ > > > > .. which seems to match the failure reported here, as doxygen would > > fail to find rte_log.h. > > > Yes, I was very much wondering about the reason for failure, since I could > find no issues with building the docs on my own system! > Is this patchset ok for merge then, or is there something else outstanding holding it back? Thanks, /Bruce