From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B8BB43071; Tue, 15 Aug 2023 15:16:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03B5A43263; Tue, 15 Aug 2023 15:16:07 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5BF6E40F17; Tue, 15 Aug 2023 15:16:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692105361; x=1723641361; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=vhVpfF6mkbFLvwx6YIFlQRL9N3mK16kcSxtrAgGnzzc=; b=Ao4ti4IttLaXhZIJZL/KV5SZZGrN7W0AW78cq14iQQdMROpHeFbmHsT3 kEAor7gj6bMk/VwA2GQGAI2ERcs9PkNr9w1u07lbJe57CTW5jMWpn3BsF qYwL/O7T5MRPjFvvXb3Z7jTwTh9tfss7fNUyLB6U0TqFb9BmIasiS4fuv 7rK5hO4YJRHCNazAO86BhUdo8O5rB8ZDIEXtXhxF7K19E+3pzH5mZaj8g 83IBpSF6djKES0gc7CFbv7VFIUDSRsC19BlIWeowe83jOIs5wxjnHdPD4 gXNUV+mBfQiSJ1J1U9OR29TBuGjXtbDpTVf8R37qV0MBgzP06Fv9b2Ko7 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="375043101" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="375043101" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 06:16:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="857442823" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="857442823" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 15 Aug 2023 06:15:59 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 15 Aug 2023 06:15:59 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 15 Aug 2023 06:15:58 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 15 Aug 2023 06:15:58 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 15 Aug 2023 06:15:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WnVxb+rjrYfMaZQaSXPRjhMbU95oCoEwZuG84WYJC2RrjWexkZVV2ub82S8wFcCeOnd528G1qvFYVKI/++jgmQr22d4S1Mpb9FypAhBiquUUPzyeHpaTkIZRVYOUOZ6R/6r1GgJrhdEW4P+V8wQFGozXuxRuVD2XFnDFusT5hs13f5spbc8qKyqoWOlgMIbQhn4YSkhd6aqJQtJkeukd0M50lzP4WwAJtFTX/LOSBl1UlSsqPFq5I8u+Gf3DD8198H/7eMBK8sLOwyHO8I+JH1gjIN1I04nCfBi+YAfR7044Fhnlc4t0wY3SETm3NF35ypj8PP0Bm9/k+bPIwhguQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=odpb59AQ66T9ixSNccgK9TvBiFFOzaHXGbFiWhZvMZE=; b=X8t+Ec/cxAPW4bsq6EurJsuq8mGhGc77kDF3J41VtE949C/O2At4fR+pA2auyR7cuAu+fZNabAZ+pkfbuihkB7j2M9ZGdc6jArlk4MYj4e69X1ZD6NUxC7jhruhQaNoNRaCCZpDOf+8ru3niF2dXCGG/GF7a8xsy3X5DSdBfQw620z6/IadWbGaOjGGD8me8OPSIVRP5WhL9S3jg7WysYDb31HLFDTPFg9Egbps4rVoYC7Ramo4163zYeKPEeskH77Hu1lP3qGEnLqsE4QuI/duM2gA9fHwtgwzXmtZh5W9NGmHMn7s8Gdb5gzbVKDgVww/jrlMCawrI1sFpcW0dvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by BL3PR11MB6316.namprd11.prod.outlook.com (2603:10b6:208:3b3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.26; Tue, 15 Aug 2023 13:15:56 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1bb0:424:8477:dbfb]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1bb0:424:8477:dbfb%3]) with mapi id 15.20.6678.025; Tue, 15 Aug 2023 13:15:56 +0000 Date: Tue, 15 Aug 2023 14:15:49 +0100 From: Bruce Richardson To: CC: Subject: Re: [PATCH v4 0/8] expand list of optional libraries Message-ID: References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815131320.375088-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230815131320.375088-1-bruce.richardson@intel.com> X-ClientProxiedBy: DUZPR01CA0302.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::19) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|BL3PR11MB6316:EE_ X-MS-Office365-Filtering-Correlation-Id: fd8a86cf-e223-4803-0e91-08db9d91c23a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N+aSRUykJ+qYPHae03COhKv/LUCvyTxSoexl+gJJH9uHdyGREv3QYHE3/Aeck90fONj9TWYKYS5hI3w2dHxc1hxVbzSLEuL7ui5W3pvpyru7htMCqqJLGNbXLJYhXmuX+doLHXcx3ErOa7ttgUuTV0K8on644ypztgpg50aDZwMXjPR6F5sxrCDGBbUhIN2S/dTFxLgP0Za3wRg+iiouco3+0ySlv/hZPYNXX+B87Akbvd0FhAvlaI4rs1GPocrvARFnotvh3+8jtGl6pjCqp5tBygYitK4r2tktvZsv7su+V+odirmCCrF3+3VXvdChFkiLsPIKjlzaSEhAXlMHCe8QGLArj/DNpIQvAPPYx1GdVRt83NJbIwwsHA7Kefp5yo1h9KMxit+9mPrSMPo1ZkA6yQ3UCH7pyD1znhXJowwypyhuqAQsM4BLaGZ7M3Vp6st9W08hfAJ206ncJveUJ3Qg5leHqXmxIhVYhna2af8sgR9j2eh8J9pOvDbstMRn/buPFrWSeZzadWOyiuVoxIC5C5eNcBG8iQ7VfYRr6BAupWve/RPHcBVyR2vP6Is9 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(396003)(376002)(136003)(366004)(451199024)(1800799009)(186009)(316002)(6486002)(4326008)(5660300002)(478600001)(82960400001)(86362001)(2906002)(6666004)(6916009)(44832011)(26005)(8676002)(41300700001)(6506007)(38100700002)(450100002)(6512007)(66556008)(66946007)(66476007)(8936002)(83380400001)(66574015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?vFkwrLTUR26s94qWhAbcqRmXr1Kuilex/ZD+N8t+XRhO4hWr9JAP6iq+ty?= =?iso-8859-1?Q?BdQUr0BXrVJORb5N89ecBhMtVmEvkopiZ4Ez5ixYYIeZxECqFCAE7YnTa1?= =?iso-8859-1?Q?juTb166GFLwcTSC+v0Pyo6zNJ6J4YV1Fi0xjBf7jOG4VnqW+wU+rEUmrWr?= =?iso-8859-1?Q?sYKCyw5MvzxqnTzfKwamriURlahWW9fxeVmeaz9KP7Gc2AmIFAGRn/Az3f?= =?iso-8859-1?Q?uDiz0AdQgas5hJh5Wi6p1v1vdb3Gp8dJD0u7dVIwlrPb0rGN1MGaqjN00i?= =?iso-8859-1?Q?RUJ71UnAFuHnXu+N4jdBfFbw/JlK706svkvifuLTCBb1UUVpeAWGUaQenn?= =?iso-8859-1?Q?V+eYqIWPkMnUnG3R/F7p7J1T1JaPLDQYKlYUbohCDWrZwxPtYxEcKp/98D?= =?iso-8859-1?Q?BUAioDYLM7Urs04y306d/JeEQAov8wVZViEnkfRSUJTbIqTHEknmMj5qqc?= =?iso-8859-1?Q?NwTq/J0/qk4TYnMiOCqNVvLNIZB11uG30v94+OBXteyh98Fj6BncrJ0BbA?= =?iso-8859-1?Q?CIAPQg1oEP73KnWuvc8xFeAzbRW2ictgTPn6Nh6Avu0p37VjWnRAzQhX4c?= =?iso-8859-1?Q?yZKGgMZ2Qf8YKX+fFYGJvkgzXWIYzTx+Okm3gs5QpkpezslxXhzi6sdIkc?= =?iso-8859-1?Q?yVfdTY7UK0LFmfeVDBPJvCe7vzo6+u0RWtGEkxtgAg3bA6u0qaxxEmD4bb?= =?iso-8859-1?Q?DeRAysRBClJMCfouOA+KB+lYkyGnwEgKrB7fXmotN9hj1FWgU43z+UEfKJ?= =?iso-8859-1?Q?gTEe5eCUZWERtaRKZLfMdqVJRsRTnS1pmp9d13uQZCiBaBI8a4ocNyq0uv?= =?iso-8859-1?Q?gzrY+ylMH71Tf3lw3543sihSxv8waazNllO6AbnDrDpMLS3qW6Rnrr48Mb?= =?iso-8859-1?Q?BLYG/cZYMns7UWzapUaQedJ9p0aIE3VNZBZ1P2PzVuw4J9BEgJo8UkFjRh?= =?iso-8859-1?Q?GQhDf9ix2KpGtgI5vH+pXi4qR1FSzdr14C42e+aYEQwJe3r1TN6d1CCwMr?= =?iso-8859-1?Q?e08DCqZ0c8OIKp5W3g8pHzXh1HNk8jHJsaAXYmJL7RbNVSkeL7EFDIE/4k?= =?iso-8859-1?Q?xerxJgYmouc7ClNTjHieJoGgYOUYNw52MNnsNMVdazvlHJWXRKuDgWonYF?= =?iso-8859-1?Q?SZHWAT/o7mr/QPO9g2Kduu0ETptvYCkSmfrP6LB7szjYOC24J/P7lUntWf?= =?iso-8859-1?Q?UCtNfx7FlBKn1LbBb2Ytn+1JcBh35vgChpyZLZO5gCqe/lP9VGxlE6MgSV?= =?iso-8859-1?Q?I3wAie9bo5N0jTko3phmwX4LHxK1+H+zQjKsCKsHiMJlwia5WpG85R6stS?= =?iso-8859-1?Q?KX1/G3iQ3eyhxpL9oncN19cvheIDsJKrNgTSSCxbYF4fWP1gX0Ox1PUw1i?= =?iso-8859-1?Q?z4l/EDOajxG6Lf/X/3fk7zCkQKCwiPwGBGpS0Ajkj2oRdKeM9eL+pYtt+s?= =?iso-8859-1?Q?yGhBx8sVKapVtrDIEQrXO/RQwMws+w3IWuAK8xXJJwqwf4t/eg//LIzADn?= =?iso-8859-1?Q?A+1XaSch+eHchKZrFGWCvXo2hBHa/RL9bkCqZFFCsO4leE6jvuERglq9L3?= =?iso-8859-1?Q?ySshM4rGu4KpX1/8su1GSM6FuEbkCmYo48QFXnzzy1WJJ9Nt8jLncVmFrV?= =?iso-8859-1?Q?qe0C7u3f4uYKl7i7CxtZKdK7h+LaeCLMbfw+vEPo1te2UEAkpX/pqrQg?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fd8a86cf-e223-4803-0e91-08db9d91c23a X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2023 13:15:55.9842 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VZ/rS3NbQThcepzxMs2/R2+5NTWLKaWzDVnM8b2Am+qZIzdvlqJH1vlrGTE9WzcLNuOQZX7C5+6EFtKDB3e5YfdbpEcXMNy0i1/n5YLplF0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6316 X-OriginatorOrg: intel.com X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org On Tue, Aug 15, 2023 at 02:13:12PM +0100, Bruce Richardson wrote: > This patchset contains changes to DPDK to make the build more configurable > overall. The changes can be grouped into two areas: > > * Firstly, there are changes to make the build of the unit tests more > flexible and maintainable. These 5 patches switch the unit tests from > having separate hard-coded lists of files and tests, with lots of > conditional logic to add/remove items from the list, to instead being > a single list of files and dependencies per-file. The actual lists of > test-suites are built up dynamically from the list of files whose > dependencies are met and therefore will be part of the build. > This rework enables... > * The second set of patches which expands the list of libraries which > can be disabled at build-time, while still giving a successful build > of DPDK. Overall, after this set is applied, the list of optional > libraries in DPDK is approx doubled in size. [15 additions giving > 31 optional libs] > > NOTES: > * as stated in the RFC, the test binary moves in the build as a result > of this set - from app/test/dpdk-test to app/dpdk-test. > * running the suites of tests no longer works after patch 4 until patch > 5 is applied. If this is an issue, the two patches can be merged on > apply. However, the individual tests are still runnable through the > test binary - it's only through "meson test" that there are issues, so > I'm keeping the patches separate since each is relatively complex in its > own right. > * A number of files in the test directory were not being built, and seem > to have never been built with meson. This requires separate work, outside > the scope of the patchset to fix. > * Similarly, some unit tests were never added to test suites. These can > now be found by using grep to find the old REGISTER_TEST_COMMAND macro. > Again, adding orphan tests to suites is outside the scope of this set. > > V4: > - improve test suite definition, hopefully improving test pass rate: > - drop unnecessary file-prefix for fast tests, since tests are not parallel > - always pass driver path flag in "meson test" for shared builds. > Missed applying Morten's ack to the series in V4. Adding it here. Series-acked-by: Morten Brørup