From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 405AF43080; Wed, 16 Aug 2023 14:33:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FB1F410D0; Wed, 16 Aug 2023 14:33:59 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id F294340EF0; Wed, 16 Aug 2023 14:33:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692189238; x=1723725238; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=er1K8SzYgYY3NJXxUv3D7m1Oq6Q/ul7eSljukZ8CP3o=; b=O2sFOEHYfxeCHRhULhdOB7gW9IO/rHg6gnYLAxjt7S/Xee3jpriibOLm spWw6YyYnyCb2x6L4SMbC1lzvJ/Om2c3UfdBfg0SLHmMWShVI+SWFVTrB 66DeR7dUCzrl0MeFag+D4i82giyyeZDenGvzX9ms/kqi+o3UPdvUUwb32 DrHr/zn3bfEELCIK/dN08UAYij0ipWLrChNcYJP0AziyqpnQJzAuAQOF3 PtZ0pThqCQjGAMKO2UIoejrunVTkpycFREk7LOC/9hwHHHUk4dQ27yxMR 6bNpkWUzzsG4jaHO4LZDPdasg6kYB5Xh6Jr3eFCy7+4m9tGzWbFL52SVe A==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="375288534" X-IronPort-AV: E=Sophos;i="6.01,176,1684825200"; d="scan'208";a="375288534" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2023 05:33:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="848472627" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="848472627" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 16 Aug 2023 05:33:55 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 16 Aug 2023 05:33:55 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 16 Aug 2023 05:33:55 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 16 Aug 2023 05:33:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kO3ee0XgQLkLT2/crWkzVgRRK4LpPeRYqa5OUbtnsb1/q3b6b4UaoFVu77oKOij45WV/07ky3nV0e9+2H/MQ0DSWg+rQodvN1BpoJGF7ITW8GW8WARii/MvPD8Sj1K5IohVyob+Kq/z5vvcEVo+7gtR2uJQa9r89Sy+HkBjrsmFL2kvTBswXXUmH9JrQf/7I0DD3dANV4Yc+EaiP185tird+a7IlXQakBnr3IJBneKZKf1qMSEByPzKw8t3iDgOe19LOs5T4M3EOR3cSrzf8Shy8Ytbpxk5L9k/ZBNkIE2jwq1DGD67QlShQrNSSKC2P5PgGalUn6Y40aVp+KquPZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qhhpjyCscOityAyXHFnpS9j2bgERVMuK95x6YYxJuMc=; b=ijjv4uPRm7jFl+lgMOnEkg+v41D7p2EIECvXTM/QWYLneLpg4T75vjcbAeFrmbdJxfVcGRvgNfHDKi6n7x167dacnmBKkSLSMgNQwLvc6nO7sr4MGj/C+vyTycwRntVDcro3eNiiEBo1TVQz5sLQU/0VQCeyifBbg2XlOoe1zbKoTbrwXCSlDILUUhfaN4BvTzFZ4lswW/Y5jW39YKIajKE8ZLU+bcoDJPhxYxQ9U5RXqru7bQYje+OTwGPyYEsTVuD62fdUABk1CPm0sapihxVJGg8ub6upbK74ci9IiGHvP9tADAJsj3CXCpzW91xHGSQMKxtQDPPgMJfBhjweaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB6322.namprd11.prod.outlook.com (2603:10b6:208:38a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.29; Wed, 16 Aug 2023 12:33:53 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6678.025; Wed, 16 Aug 2023 12:33:53 +0000 Date: Wed, 16 Aug 2023 13:33:46 +0100 From: Bruce Richardson To: David Marchand CC: , , Morten =?iso-8859-1?Q?Br=F8rup?= , Olivier Matz Subject: Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros Message-ID: References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-6-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB6PR0301CA0096.eurprd03.prod.outlook.com (2603:10a6:6:30::43) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB6322:EE_ X-MS-Office365-Filtering-Correlation-Id: fe0509d3-e974-4c4e-5644-08db9e550d07 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6CU+nJmsjgRHFc/ombnNyx9OQu2DE+U9xD3mjWhsubkufJcA+NIF5Zr97l3FnFbk2zZzpqNdBHzURf6ilpCMvBl2jPqANiDqs2F4lB9zWjQDTJ+IUrpFxcWV1d8yhseXAk+mleRshkPjkZJB/jw5m/rWNdl7xFSMzKetemHQ6ekpTHTcaEee6+oyJ2gB/m1fbntaFOxYSkw1Sj5JlPlzcZIPEDtpx3JttL2nvmpYSHVnAfH7XKly64IjaTESF7e/NU1YiRNdICD+5kbxc70bxrOULziKMtH6dlnxJlo708gKkZX0LDsGVDEk0kzQJ8gelHHvk47ZhL3UzC2hVpzyzHiN9Irs5USkylkz+jKhg8W16ZX5htfZxrw18tYQq4atGpVhKFxs4Km68Zg05cfJG/zmC7dcr+7/UE30NDCXbuAJn8QCOTX27OqWlxe6CaUsGW6yT3Ss9QdrZTmhHOQCYC5GS9E0/dh+q5hYV4CYX9MkuW4RL3Q/IJSI/M8soFWhXmLc8fTFFL17xyJr65gV13eShpw4lIuG3R+RCdyyOF32f0QpiKylRDDT/6i5aImx X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(366004)(346002)(39860400002)(396003)(451199024)(1800799009)(186009)(2906002)(83380400001)(86362001)(478600001)(6506007)(6486002)(6666004)(6512007)(53546011)(26005)(5660300002)(44832011)(41300700001)(54906003)(316002)(66946007)(66556008)(66476007)(6916009)(8676002)(8936002)(4326008)(82960400001)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVorNDE5WGNWZjRRZ1Q1SEdIM1QrM1RXUzB1M21yc2dvSmJsSG9DSUNmV3Jm?= =?utf-8?B?RlFFWUhZMy8zS2M3bFFBdnNrR1NTM3pYNUlIQnBmL1VJampjbVpwaHVXS2s5?= =?utf-8?B?R2Y1dGRzbzJRSlBYTElUdmtGVnJhRXFNZWFxT2RqbXNFckVKYVEzM3pFaGVa?= =?utf-8?B?VTJ5RzJPTlV0OUhNdExyRnovbGxrTE1UVkF5NmtONUJuS3l2WjlZUnJJR3hF?= =?utf-8?B?YkJqbDhaRGVpeEp1bnBXUlVHWkJjMDBLRjY5ekhXamNWRGhIM0pFVDN3eHNJ?= =?utf-8?B?c0RQMjJvYm9pMlNScHBQcisrN1JQOStONllOakpSakx3RWMrM0JZS3B3OVBQ?= =?utf-8?B?QitOcFF2elBVbHc3R3h5d05ZbndGS200ZllhZG1QeUgvZGtBK1Y4UFV6b2p0?= =?utf-8?B?akFNdVBYOWRXMEw3dVQxM1RwaU0ySWF0VmhtRVJsK1ZxWWluWGQ0dEJYL05y?= =?utf-8?B?OFl4LysyVmNlY0N6MzNPMFViT2tEc1g1TEI1V2VBdEVwdVJtQVprMWdOOWV5?= =?utf-8?B?eHg3MDN4WVRkQWNXMnJ3cXBVRjZBenJhRWJNRy9CWmNMZWNoSkFURFVmRHQx?= =?utf-8?B?ZHBsMkh0cTkyQ3VUa01ab0ZvVTVWKzZNQWZyd05QNmFYdzM2aWszcXR3SEFR?= =?utf-8?B?MnpNb2srOEhwQmZkUXJyMHpKUWtJZDVTZzRHc0Vva0xVTW45UjJ2ZXZ4RXdF?= =?utf-8?B?VWh1ZW5uRnFMQ0ovK013cEEyZTZqd2tnbUdsUnRrcHNyTE9NMGVrUVloVUtl?= =?utf-8?B?c1hIZlFvT1ZYdFJaY1dmR0gvYnhCMmFVdUd2Q1IzL2dlNW9nZnc1SUFQQjJr?= =?utf-8?B?d3F1NUJxNlMvb0o0UzB3RFJFL0ttMEdFczRkbTlPb3dEbVVkcmVtNG5HSklW?= =?utf-8?B?U1YxWnZkSXIzMEs2YURmWUVxb1liSFFvc1RrcG5zYzA2SXFGU01yRkNMb21S?= =?utf-8?B?NDBaZ1BXMDRNd1hpNjlWcWZrY3diMXNkS1djem50c0p1RnBjcXZvZEJrcWwz?= =?utf-8?B?Y0FVYnZBL3V5cTlnQXZiSmtZY2p6WnFYRndoTkhiMERYWEVuRUxTdVJTU3NY?= =?utf-8?B?eWFCdVYzazl1WTRvcW1HeGl4anROMVgrZXlMOCtTY05sTVd0a2NMdmMyQm82?= =?utf-8?B?N0NJVUF5NHdNamthSTRYWjlQeU5hNmlzT01ZZElrV3dVaGxGTUtpL1lxVmFM?= =?utf-8?B?SmxKNEtxc0lwdEdCQlBTUVh6UGlUbCtHMEtNRG1WQ0dCK0RPei8xNjNhcm0x?= =?utf-8?B?UGxwTFgvZGJVYUJXb3dXQ052a04vNklRck5UVVpXK0d0NlF0MjhSelBhUktz?= =?utf-8?B?cjAzcnFGY3MzQnIwUXh2emEvbFVhQXloUmQ3YkJTbStHaXRzRUp3VHZaYVE1?= =?utf-8?B?c2FOZFNhZGZXQ2hseFBQdEpTa2lSalZFVkhTaitubTRUR3FqL0lyNTdYdUNY?= =?utf-8?B?ZXBUYjRiOTBmdXZZZi8rV0RydE5JNXl4eUhtKzR1cG81NTdxYysybE5vOTBh?= =?utf-8?B?aU9sOGZsZDZhSUVvY1E2TkhSRFdOdWRFNnhQaG80ZU80RzVSc251Zkp0SFZr?= =?utf-8?B?K2JlQy9NM1NDQ21WNFl2dkhDNjBLMk10bkNQcWdMTER5dENpYVhyTFcyMFRj?= =?utf-8?B?UjhaNmhzdjhkTkdEekRja2gwaG5IY0Y5N2lkMUowbGM3clF3dCtiK3FTQnhN?= =?utf-8?B?NFljNHN4UEMrTHRER000SWlJMkpubDhtK1BJcHR3dEJuRUE3MjIzR083WlR1?= =?utf-8?B?M0dkNTdaRDBZQ3hzY1hUZTJQb1FnNkxCMm1SVTBYQTQwOUhlTTc1ZkU0WnFJ?= =?utf-8?B?dTZWdkxXY0Nvd3ZrbE5haml2aUlWK2hKUlZoUlNHUU9xVW9IWmhndEVnUHJR?= =?utf-8?B?MVBiODVhcG5YU2U0NEJEeDhHTWRrN3ZMd0NySHpEa2hVMW9DN1gwUzg3ZE9C?= =?utf-8?B?OXBhT1lOSkNpZ2c4cjNLYzUvc2ZTdFRLRlJ1NldiZHBMQ0ZXbldHaTFYZVc5?= =?utf-8?B?TnF2alBPb2ZrTGtaMXdVMU90angxcjlTdEh4Y3FYQ3RrWEFrdDhNaVNHNnZy?= =?utf-8?B?UjlwTzRXWnU0U1ordlYvWkkvWVc1UTFRVGgrRmswdHpDN3F6ZGVFblQreFRn?= =?utf-8?B?RDdwOHB1WmZsMm5VeGFlbjVIOTlyM1pqL1RaUWM5aDZpS2VremFJRUJQNU80?= =?utf-8?B?OHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: fe0509d3-e974-4c4e-5644-08db9e550d07 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2023 12:33:53.7052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: czh/o6oRQXTFITMCzGOLnZAVXgqGXE/RlUWYeL3mfaql1NwJyjsRi8lMUgdcBu4XCdqCRaIWwyu2tuKT1kY38NEDu+e0yaw6r/iOyGoqaRU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6322 X-OriginatorOrg: intel.com X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org On Wed, Aug 16, 2023 at 01:40:41PM +0200, David Marchand wrote: > On Wed, Aug 16, 2023 at 1:15 PM David Marchand > wrote: > > > > On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson > > wrote: > > > These lines here seem to be exposing a bug in the mempool unit tests for > > > shared builds, which is why we have a CI failure. > > > > > > The mempool unit tests use the mempool "create_empty" API, and then call > > > the populate APIs to finish setting up the mempool. However, the > > > create_empty API does not explicitly configure a particular set of mempool > > > ops for the new mempool, leaving the ops field at 0. This means that unless > > > the app explicitly sets other ops, the mempool will use the ops from > > > whatever driver registers itself first. This occurs even when the driver is > > > unsuitable, e.g. on my Intel system, the dpaa2 is first on the list, > > > leading to failures in setting up and using the mempool. > > > > Hum, it sounds like a bug to me. > > The dpaa2 driver should not be registered as the default (or here, > > default platform) mempool. > > Other mempool drivers ensure that required hw is available, I guess > > dpaa2 is missing some check. > > Ok, re-reading your last comment, I agree it looks like an issue in > the unit test itself. > Copying Olivier. > No, I think it's not a bug in the test, but rather in the mempool. Unfortunately, I think the concept of the "default" driver for mempools seems to exist only when using the mbuf library to create mempools. Even then, the default mempool is different from what the first entry in the list is. That's the fundamental issue here, we are using the zero-eth entry in the ops list, rather than a default one. /Bruce