Re: [OS-Team] [dpdklab] Re: [PATCH 0/5] Increase minimum meson version

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Oct 08, 2024 at 03:49:12PM -0400, Patrick Robb wrote:
>    On Tue, Oct 8, 2024 at 4:28 AM David Marchand
>    <[1]david.marchand@redhat.com> wrote:
> 
>      This series can't be merged until the (UNH and LoongArch) CI are
>      ready
>      for such a change.
>      TL;DR: the meson minimum version is being changed from 0.53.2 to
>      0.57
>      in the current release.
>      @UNH @Min Zhou
>      How long would it take for all CI to be ready for this change?
> 
>    Thanks for the heads up. So, as far as I can tell, this will require an
>    update to the dpdk/.ci/linux-setup.sh script (which I have just
>    submitted) as I think various labs rely on it including the github
>    robot, loongson, Intel (Maybe, I don't know).

The update to that linux-setup file is included already in the first patch
of the series. No additional updates needed for jobs that rely on it.

> UNH does not use it much
>    as we opt to meet the meson dependency separately in the dpdk-ci
>    project's container template engine.

That's a bit of a pity, since we can't update the meson version
automatically as part of the meson update as we do with CIs using the
linux-setup script. Is there some other file that can be in the DPDK main
repo that can contain this details to regular DPDK patches can update the
CI too as part of a meson update?

>    It will also require updates to the container template engine, which I
>    can get Cody started on tomorrow.
> 
>      Important note: if relevant to your CI, testing against LTS branches
>      must still be done with the 0.53.2 version, so no change relying on
>      post 0.53.2 meson feature gets backported.
> 
>    Okay, full disclosure I don't think this is something we handled the
>    last time the meson version got bumped in 2022. So, back then we just
>    bumped the meson version for all environments to .53, then did LTS
>    testing for 19.11, 20.11, 21.11 from environments running meson .53.
>    But, I understand how this is an issue and something we should avoid
>    this go around.
>    However, it is not ideal to set the meson version "at runtime" for CI
>    testing based on the repo under test (mainline and next-* want .57, old
>    LTS versions want .53). It would be possible to modify our jenkinsfiles
>    (automation scripts) to check the DPDK version, and run pip commands
>    resetting the meson version accordingly, at the start of each testing
>    job... but I have a couple concerns here with regards to
>    stability/maintenance.

I would recommend against using the DPDK version as a guide. However, the
meson version is included in the project options in the meson.build file of
the code. Could you use "grep meson_version meson.build" in a script to
extra the required version info? If it's helpful, we can possibly provide
some sort of compatibility guarantee of the format of this line.


Regards,
/Bruce