DPDK CI discussions
 help / color / mirror / Atom feed
* [PATCH] Increasing ci meson version to .57
@ 2024-10-08 19:25 Patrick Robb
  2024-10-08 19:33 ` Patrick Robb
  2024-10-08 20:05 ` Bruce Richardson
  0 siblings, 2 replies; 4+ messages in thread
From: Patrick Robb @ 2024-10-08 19:25 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, david.marchand, zhoumin, aconole,
	rajesh.t.puttaswamy, ci, Patrick Robb

There is a proposed increase in the minimum meson version to .57
This patch aligns the linux setup ci script with this change.

Signed-off-by: Patrick Robb <probb@iol.unh.edu>
---
 .ci/linux-setup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
index 975bf32144..c7b6a86d38 100755
--- a/.ci/linux-setup.sh
+++ b/.ci/linux-setup.sh
@@ -4,7 +4,7 @@
 [ "$(id -u)" != '0' ] || alias sudo=
 
 # need to install as 'root' since some of the unit tests won't run without it
-sudo python3 -m pip install --upgrade 'meson==0.53.2'
+sudo python3 -m pip install --upgrade 'meson==0.57'
 
 # setup hugepages. error ignored because having hugepage is not mandatory.
 cat /proc/meminfo
-- 
2.46.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Increasing ci meson version to .57
  2024-10-08 19:25 [PATCH] Increasing ci meson version to .57 Patrick Robb
@ 2024-10-08 19:33 ` Patrick Robb
  2024-10-08 20:05 ` Bruce Richardson
  1 sibling, 0 replies; 4+ messages in thread
From: Patrick Robb @ 2024-10-08 19:33 UTC (permalink / raw)
  To: dev
  Cc: bruce.richardson, david.marchand, zhoumin, aconole,
	rajesh.t.puttaswamy, ci

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

Oh, I guess I should have mentioned that I did "test" this for good
measure, by spinning up a base ubuntu 20.04 container, running the
linux-setup.sh with this change, and did a dpdk build.

Tested-by: Patrick Robb <probb@iol.unh.edu>

On Tue, Oct 8, 2024 at 3:27 PM Patrick Robb <probb@iol.unh.edu> wrote:

> There is a proposed increase in the minimum meson version to .57
> This patch aligns the linux setup ci script with this change.
>
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> ---
>  .ci/linux-setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
> index 975bf32144..c7b6a86d38 100755
> --- a/.ci/linux-setup.sh
> +++ b/.ci/linux-setup.sh
> @@ -4,7 +4,7 @@
>  [ "$(id -u)" != '0' ] || alias sudo=
>
>  # need to install as 'root' since some of the unit tests won't run
> without it
> -sudo python3 -m pip install --upgrade 'meson==0.53.2'
> +sudo python3 -m pip install --upgrade 'meson==0.57'
>
>  # setup hugepages. error ignored because having hugepage is not mandatory.
>  cat /proc/meminfo
> --
> 2.46.1
>
>

[-- Attachment #2: Type: text/html, Size: 1645 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Increasing ci meson version to .57
  2024-10-08 19:25 [PATCH] Increasing ci meson version to .57 Patrick Robb
  2024-10-08 19:33 ` Patrick Robb
@ 2024-10-08 20:05 ` Bruce Richardson
  2024-10-08 20:11   ` Patrick Robb
  1 sibling, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2024-10-08 20:05 UTC (permalink / raw)
  To: Patrick Robb
  Cc: dev, david.marchand, zhoumin, aconole, rajesh.t.puttaswamy, ci

On Tue, Oct 08, 2024 at 03:25:43PM -0400, Patrick Robb wrote:
> There is a proposed increase in the minimum meson version to .57
> This patch aligns the linux setup ci script with this change.
> 
> Signed-off-by: Patrick Robb <probb@iol.unh.edu>
> ---
>  .ci/linux-setup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
> index 975bf32144..c7b6a86d38 100755
> --- a/.ci/linux-setup.sh
> +++ b/.ci/linux-setup.sh
> @@ -4,7 +4,7 @@
>  [ "$(id -u)" != '0' ] || alias sudo=
>  
>  # need to install as 'root' since some of the unit tests won't run without it
> -sudo python3 -m pip install --upgrade 'meson==0.53.2'
> +sudo python3 -m pip install --upgrade 'meson==0.57'
>  

This change should be already covered in [1].

Regards,
/Bruce

[1] https://patches.dpdk.org/project/dpdk/patch/20240920125737.1197969-2-bruce.richardson@intel.com/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Increasing ci meson version to .57
  2024-10-08 20:05 ` Bruce Richardson
@ 2024-10-08 20:11   ` Patrick Robb
  0 siblings, 0 replies; 4+ messages in thread
From: Patrick Robb @ 2024-10-08 20:11 UTC (permalink / raw)
  To: Bruce Richardson
  Cc: dev, david.marchand, zhoumin, aconole, rajesh.t.puttaswamy, ci

[-- Attachment #1: Type: text/plain, Size: 56 bytes --]

Haha... I guess that serves as a lesson.

Thanks Bruce.

[-- Attachment #2: Type: text/html, Size: 101 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-08 20:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-08 19:25 [PATCH] Increasing ci meson version to .57 Patrick Robb
2024-10-08 19:33 ` Patrick Robb
2024-10-08 20:05 ` Bruce Richardson
2024-10-08 20:11   ` Patrick Robb

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).