From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3375A0C41 for ; Tue, 7 Sep 2021 13:03:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93A97410ED; Tue, 7 Sep 2021 13:03:28 +0200 (CEST) Received: from mailgw01.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by mails.dpdk.org (Postfix) with ESMTP id 605F8410EC for ; Tue, 7 Sep 2021 13:03:27 +0200 (CEST) Received: from mailgw01.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw01.pantheon.sk (Proxmox) with ESMTP id 17CDD201B4C; Tue, 7 Sep 2021 13:03:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=ne5WFaQS6MT002WnB2Mt LHbT9jwdQUGl79YxxXHiekg=; b=HFMGOs8DhRfGHlENG2wpxqXwSV5F6X4HNC60 hNgrrmTtn4QYymGr/7hORemHrFnJ/qurm72mINs/46EilH8orCmBwEHsDBezTK48 fQtK2lIdWIG7VA6I/e+s00siNHZUOtZ+7PNzumqHEhlNR0uBQHDhSQ9lMszu6wS2 Se145ah9c0m2CSRAn/6tJzWrpV8sMt5L65q6SmyMK4VgvSkq206z6p2nLSAnlO8g m/F8Rdarwx0+uRIMeZbUId2CVb28aqUktiANc0PvstE1eL9sTzHYucqapzqUEkmA FMKriI/7vFHxrZaIsR7G0pKkjLIEsbLUtW1btrxeotfp40cXSg== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: Ali Alnubani , "ci@dpdk.org" CC: "thomas@monjalon.net" , "jerinj@marvell.com" , "ferruh.yigit@intel.com" , "david.marchand@redhat.com" Thread-Topic: [dpdk-ci] [PATCH 1/9] tools: rename guess_git_tree script Thread-Index: AQHXozZiJELkHPhgUkuRbvFWmSclkquYS/gA Date: Tue, 7 Sep 2021 11:03:26 +0000 Message-ID: References: <20210906154537.1299-1-alialnu@nvidia.com> <20210906154537.1299-2-alialnu@nvidia.com> In-Reply-To: <20210906154537.1299-2-alialnu@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-ci] [PATCH 1/9] tools: rename guess_git_tree script X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Sender: "ci" > -----Original Message----- > From: ci On Behalf Of Ali Alnubani > Sent: Monday, September 6, 2021 5:45 PM > To: ci@dpdk.org > Cc: thomas@monjalon.net; jerinj@marvell.com; ferruh.yigit@intel.com; > david.marchand@redhat.com > Subject: [dpdk-ci] [PATCH 1/9] tools: rename guess_git_tree script >=20 > The name 'maintainers.py' will make more sense when adding more operation= s > to the script. >=20 A noun evokes something non-executable and in my opinion 'maintainers.py' d= oesn't describe what the script does in any way. As far as I can tell, the script (with all the new changes) gets data from = patchwork and the maintainers file and then processes those to produce a li= st of trees, maintainers or updates PW. Maybe name it pw_maintainers_cli.py= ? Another thing that would make sense it to make the "--command" argument pos= itional, since it's mandatory and the argument name isn't really necessary.= But maybe that's a change for another series. > Signed-off-by: Ali Alnubani > --- > tools/{guess_git_tree.py =3D> maintainers.py} | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) rename tools/{guess_git= _tree.py > =3D> maintainers.py} (98%) >=20 > diff --git a/tools/guess_git_tree.py b/tools/maintainers.py similarity in= dex 98% > rename from tools/guess_git_tree.py rename to tools/maintainers.py index > c9eef39..0cf1907 100755 > --- a/tools/guess_git_tree.py > +++ b/tools/maintainers.py > @@ -31,13 +31,13 @@ variables PW_{SERVER,PROJECT,TOKEN} should be set. > If not, the script will try to load the git configurations pw.{server,pr= oject,token}. >=20 > Example usage: > - ./guess-git-tree.py --command list_trees_for_series 2054 > - ./guess-git-tree.py --command list_trees_for_patch 2054 > + ./maintainers.py --command list_trees_for_series 2054 > + ./maintainers.py --command list_trees_for_patch 2054 >=20 > Or if you want to use inside other scripts: >=20 > import os > - from guess_git_tree import (Maintainers, GitPW, Diff) > + from maintainers import (Maintainers, GitPW, Diff) > _git_pw =3D GitPW({ > 'pw_server': os.environ.get('PW_SERVER'), > 'pw_project': os.environ.get('PW_PROJECT'), > -- > 2.25.1 >=20