DPDK CI discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: Ilya Maximets <i.maximets@ovn.org>
Cc: ci@dpdk.org,  Michael Santana <msantana@redhat.com>,
	 Jeremy Kerr <jk@ozlabs.org>
Subject: Re: [PATCH 1/2] treewide: Add a User Agent for CURL requests
Date: Mon, 22 Jan 2024 14:31:48 -0500	[thread overview]
Message-ID: <f7t1qa96u6z.fsf@redhat.com> (raw)
In-Reply-To: <f7e87288-6367-46dc-aa10-31931fbec883@ovn.org> (Ilya Maximets's message of "Mon, 22 Jan 2024 19:11:39 +0100")

Ilya Maximets <i.maximets@ovn.org> writes:

> On 1/22/24 18:26, Aaron Conole wrote:
>> This will help identifying robot usage across PW instances.
> Thanks, Aaron!
> I didn't test, but the patch seems fine to me in general.
> But what do you think about adding a common string to all the
> requests, so it's easier to identify them?  With this change
> the user agent is different for different parts of the system.
> Maybe do something like 'User-Agent: xxx (pw-ci)', so all the
> requests have '(pw-ci)' part in common?

Makes sense.  Done.

> Best regards, Ilya Maximets.

  reply	other threads:[~2024-01-22 19:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 17:26 [PATCH 0/2] Reduced checks API usage Aaron Conole
2024-01-22 17:26 ` [PATCH 1/2] treewide: Add a User Agent for CURL requests Aaron Conole
2024-01-22 18:11   ` Ilya Maximets
2024-01-22 19:31     ` Aaron Conole [this message]
2024-01-22 18:17   ` Michael Santana
2024-01-22 17:26 ` [PATCH 2/2] post_pw: Store submitted checks locally as well Aaron Conole
2024-01-22 18:16   ` Michael Santana
2024-01-22 19:31     ` Aaron Conole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7t1qa96u6z.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=ci@dpdk.org \
    --cc=i.maximets@ovn.org \
    --cc=jk@ozlabs.org \
    --cc=msantana@redhat.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).