From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6A1F4399D; Mon, 22 Jan 2024 20:31:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B10C4402C3; Mon, 22 Jan 2024 20:31:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 101C440298 for ; Mon, 22 Jan 2024 20:31:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705951912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EdMhxHi4IpWoe3gw2fHB+IXsRmSWjB6HpXABXFj9xDw=; b=baw17I3QhqI+F0ogr1HoVWn96GAzQJ2bT/5jJWVWqJniVycrUUp0Za9KaiMNWhYSXiQp2n bLdKP/Xpd+fWT1ddAk1cYkWEJ9+KqToVUK4EnJlIUCdtk7d1hAVcBjI1G8V4YtdifXQRvK ecVJSEjZbOOiXGJr3hm80WEiSaYejRE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-324-M9ARrwQ1MwyoFnX-GAlmiw-1; Mon, 22 Jan 2024 14:31:49 -0500 X-MC-Unique: M9ARrwQ1MwyoFnX-GAlmiw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 19001185A786; Mon, 22 Jan 2024 19:31:49 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.33.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D609E492BE2; Mon, 22 Jan 2024 19:31:48 +0000 (UTC) From: Aaron Conole To: Ilya Maximets Cc: ci@dpdk.org, Michael Santana , Jeremy Kerr Subject: Re: [PATCH 1/2] treewide: Add a User Agent for CURL requests References: <20240122172635.3641078-1-aconole@redhat.com> <20240122172635.3641078-2-aconole@redhat.com> Date: Mon, 22 Jan 2024 14:31:48 -0500 In-Reply-To: (Ilya Maximets's message of "Mon, 22 Jan 2024 19:11:39 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Ilya Maximets writes: > On 1/22/24 18:26, Aaron Conole wrote: >> This will help identifying robot usage across PW instances. > > Thanks, Aaron! > > I didn't test, but the patch seems fine to me in general. > > But what do you think about adding a common string to all the > requests, so it's easier to identify them? With this change > the user agent is different for different parts of the system. > Maybe do something like 'User-Agent: xxx (pw-ci)', so all the > requests have '(pw-ci)' part in common? Makes sense. Done. > Best regards, Ilya Maximets.