From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A84D945AD6; Mon, 7 Oct 2024 17:53:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83E98427E8; Mon, 7 Oct 2024 17:53:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 693444026C for ; Mon, 7 Oct 2024 17:52:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728316378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nkagKD48pOju+McIWfrv4y7G/+VBwNw9QpNmSlszpts=; b=RDKtEqK8KvgehxXnF/QHf69BsAL5Jh6pizgFEh8r01XSncuTw/E3IjsvNbEUkmAvLHLoFO xtBejtEyasw7w49g2sVJSD1Yl5kjb5SoDLgd80Tk++VKmCBa7GypdQcMt3yEzkrgoHedko NZkYiDbdJIpYSfwl/KG6uHE7lOb/IIk= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-CLqZhjXMPEevjl2GU2ELDg-1; Mon, 07 Oct 2024 11:52:55 -0400 X-MC-Unique: CLqZhjXMPEevjl2GU2ELDg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 852BA1943CE6; Mon, 7 Oct 2024 15:52:54 +0000 (UTC) Received: from RHTRH0061144 (unknown [10.22.9.85]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 09ED11955F42; Mon, 7 Oct 2024 15:52:52 +0000 (UTC) From: Aaron Conole To: Manit Mahajan Cc: ci@dpdk.org, probb@iol.unh.edu, alialnu@nvidia.com, Luca Vizzarro Subject: Re: [PATCH] config: adding dts tag for dts path patches In-Reply-To: <20241001170703.30348-1-mmahajan@iol.unh.edu> (Manit Mahajan's message of "Tue, 1 Oct 2024 13:07:03 -0400") References: <20241001170703.30348-1-mmahajan@iol.unh.edu> Date: Mon, 07 Oct 2024 11:52:51 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Manit Mahajan writes: > DTS provides a check-format script which runs a series of code quality > checks including formatting, linting, and type-checking using the > following tools: black, isort, pylama, and mypy. Developers are supposed > to run this script before submitting their patch series. In CI testing, > we want to run this formatting script on all patches which modify > dpdk/dts/* going forward, and submit a new patchwork check named > dts-check-format. In order to do this, we need to be able to set a tag > in the patch parser script for all patch series which meet this > condition. This series adds the dts tag and path assignment to > config/patch_parser.cfg. > > Signed-off-by: Manit Mahajan > --- Hi Manit, FYI, your signed-off-by line is incorrect. It is missing the email address. I can add it on apply if you are okay with that, but in the future, it should look like:: Signed-off-by: Manit Mahajan Thanks! > config/patch_parser.cfg | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/config/patch_parser.cfg b/config/patch_parser.cfg > index 5757f9a..dac3b23 100644 > --- a/config/patch_parser.cfg > +++ b/config/patch_parser.cfg > @@ -13,6 +13,7 @@ app = application > license = documentation > VERSION = documentation > build = core > +dts = dts > > # This is an ordered list of the importance of each patch classification. > # It should be used to determine which classification to use on tools which > @@ -22,4 +23,5 @@ priority_list = > core, > driver, > application, > - documentation > + documentation, > + dts