* [PATCH] config: adding dts tag for dts path patches
@ 2024-10-01 17:07 Manit Mahajan
2024-10-01 17:19 ` Patrick Robb
2024-10-07 15:52 ` Aaron Conole
0 siblings, 2 replies; 7+ messages in thread
From: Manit Mahajan @ 2024-10-01 17:07 UTC (permalink / raw)
To: ci; +Cc: probb, alialnu, aconole, Manit Mahajan
DTS provides a check-format script which runs a series of code quality
checks including formatting, linting, and type-checking using the
following tools: black, isort, pylama, and mypy. Developers are supposed
to run this script before submitting their patch series. In CI testing,
we want to run this formatting script on all patches which modify
dpdk/dts/* going forward, and submit a new patchwork check named
dts-check-format. In order to do this, we need to be able to set a tag
in the patch parser script for all patch series which meet this
condition. This series adds the dts tag and path assignment to
config/patch_parser.cfg.
Signed-off-by: Manit Mahajan
---
config/patch_parser.cfg | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/config/patch_parser.cfg b/config/patch_parser.cfg
index 5757f9a..dac3b23 100644
--- a/config/patch_parser.cfg
+++ b/config/patch_parser.cfg
@@ -13,6 +13,7 @@ app = application
license = documentation
VERSION = documentation
build = core
+dts = dts
# This is an ordered list of the importance of each patch classification.
# It should be used to determine which classification to use on tools which
@@ -22,4 +23,5 @@ priority_list =
core,
driver,
application,
- documentation
+ documentation,
+ dts
--
2.41.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] config: adding dts tag for dts path patches
2024-10-01 17:07 [PATCH] config: adding dts tag for dts path patches Manit Mahajan
@ 2024-10-01 17:19 ` Patrick Robb
2024-10-04 14:01 ` Aaron Conole
2024-10-07 15:52 ` Aaron Conole
1 sibling, 1 reply; 7+ messages in thread
From: Patrick Robb @ 2024-10-01 17:19 UTC (permalink / raw)
To: Manit Mahajan; +Cc: ci, alialnu, aconole, Luca Vizzarro
[-- Attachment #1: Type: text/plain, Size: 127 bytes --]
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
Adding Luca since he is keen to see the dts format script run in CI
testing. :)
[-- Attachment #2: Type: text/html, Size: 217 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] config: adding dts tag for dts path patches
2024-10-01 17:19 ` Patrick Robb
@ 2024-10-04 14:01 ` Aaron Conole
2024-10-04 17:54 ` Patrick Robb
0 siblings, 1 reply; 7+ messages in thread
From: Aaron Conole @ 2024-10-04 14:01 UTC (permalink / raw)
To: Patrick Robb; +Cc: Manit Mahajan, ci, alialnu, Luca Vizzarro
Patrick Robb <probb@iol.unh.edu> writes:
> Reviewed-by: Patrick Robb <probb@iol.unh.edu>
>
> Adding Luca since he is keen to see the dts format script run in CI testing. :)
Should I hold off on Luca's ack/reviewed before applying?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] config: adding dts tag for dts path patches
2024-10-04 14:01 ` Aaron Conole
@ 2024-10-04 17:54 ` Patrick Robb
2024-10-07 12:56 ` Luca Vizzarro
0 siblings, 1 reply; 7+ messages in thread
From: Patrick Robb @ 2024-10-04 17:54 UTC (permalink / raw)
To: Aaron Conole; +Cc: Manit Mahajan, ci, alialnu, Luca Vizzarro
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
No, I don't think that's necessary. What he described (run the format check
every time a file within /dts/* is being changed) will be accomplished with
this patch. And I don't think he has worked with the dpdk-ci repo
previously anyways.
On Fri, Oct 4, 2024 at 10:01 AM Aaron Conole <aconole@redhat.com> wrote:
> Patrick Robb <probb@iol.unh.edu> writes:
>
> > Reviewed-by: Patrick Robb <probb@iol.unh.edu>
> >
> > Adding Luca since he is keen to see the dts format script run in CI
> testing. :)
>
> Should I hold off on Luca's ack/reviewed before applying?
>
>
[-- Attachment #2: Type: text/html, Size: 1016 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] config: adding dts tag for dts path patches
2024-10-04 17:54 ` Patrick Robb
@ 2024-10-07 12:56 ` Luca Vizzarro
0 siblings, 0 replies; 7+ messages in thread
From: Luca Vizzarro @ 2024-10-07 12:56 UTC (permalink / raw)
To: Patrick Robb, Aaron Conole; +Cc: Manit Mahajan, ci, alialnu
On 04/10/2024 18:54, Patrick Robb wrote:
> No, I don't think that's necessary. What he described (run the format
> check every time a file within /dts/* is being changed) will be
> accomplished with this patch. And I don't think he has worked with the
> dpdk-ci repo previously anyways.
As you said I haven't worked on the dpdk-ci repo before, so not sure
what's happening here :D
Thank you for the cc. Will also keep a look out for what I presume is
the next patch including dts-check-format?
And thank you Manit for making this happen!
Best,
Luca
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] config: adding dts tag for dts path patches
2024-10-01 17:07 [PATCH] config: adding dts tag for dts path patches Manit Mahajan
2024-10-01 17:19 ` Patrick Robb
@ 2024-10-07 15:52 ` Aaron Conole
2024-10-07 15:54 ` Patrick Robb
1 sibling, 1 reply; 7+ messages in thread
From: Aaron Conole @ 2024-10-07 15:52 UTC (permalink / raw)
To: Manit Mahajan; +Cc: ci, probb, alialnu, Luca Vizzarro
Manit Mahajan <mmahajan@iol.unh.edu> writes:
> DTS provides a check-format script which runs a series of code quality
> checks including formatting, linting, and type-checking using the
> following tools: black, isort, pylama, and mypy. Developers are supposed
> to run this script before submitting their patch series. In CI testing,
> we want to run this formatting script on all patches which modify
> dpdk/dts/* going forward, and submit a new patchwork check named
> dts-check-format. In order to do this, we need to be able to set a tag
> in the patch parser script for all patch series which meet this
> condition. This series adds the dts tag and path assignment to
> config/patch_parser.cfg.
>
> Signed-off-by: Manit Mahajan
> ---
Hi Manit,
FYI, your signed-off-by line is incorrect. It is missing the email
address. I can add it on apply if you are okay with that, but in the
future, it should look like::
Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
Thanks!
> config/patch_parser.cfg | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/config/patch_parser.cfg b/config/patch_parser.cfg
> index 5757f9a..dac3b23 100644
> --- a/config/patch_parser.cfg
> +++ b/config/patch_parser.cfg
> @@ -13,6 +13,7 @@ app = application
> license = documentation
> VERSION = documentation
> build = core
> +dts = dts
>
> # This is an ordered list of the importance of each patch classification.
> # It should be used to determine which classification to use on tools which
> @@ -22,4 +23,5 @@ priority_list =
> core,
> driver,
> application,
> - documentation
> + documentation,
> + dts
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] config: adding dts tag for dts path patches
2024-10-07 15:52 ` Aaron Conole
@ 2024-10-07 15:54 ` Patrick Robb
0 siblings, 0 replies; 7+ messages in thread
From: Patrick Robb @ 2024-10-07 15:54 UTC (permalink / raw)
To: Aaron Conole; +Cc: Manit Mahajan, ci, alialnu, Luca Vizzarro
[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]
Good catch Aaron, sorry that I missed this in my review.
We will accept your offer to amend the commit on apply. :)
On Mon, Oct 7, 2024 at 11:53 AM Aaron Conole <aconole@redhat.com> wrote:
> Manit Mahajan <mmahajan@iol.unh.edu> writes:
>
> > DTS provides a check-format script which runs a series of code quality
> > checks including formatting, linting, and type-checking using the
> > following tools: black, isort, pylama, and mypy. Developers are supposed
> > to run this script before submitting their patch series. In CI testing,
> > we want to run this formatting script on all patches which modify
> > dpdk/dts/* going forward, and submit a new patchwork check named
> > dts-check-format. In order to do this, we need to be able to set a tag
> > in the patch parser script for all patch series which meet this
> > condition. This series adds the dts tag and path assignment to
> > config/patch_parser.cfg.
> >
> > Signed-off-by: Manit Mahajan
> > ---
>
> Hi Manit,
>
> FYI, your signed-off-by line is incorrect. It is missing the email
> address. I can add it on apply if you are okay with that, but in the
> future, it should look like::
>
> Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
>
> Thanks!
>
> > config/patch_parser.cfg | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/config/patch_parser.cfg b/config/patch_parser.cfg
> > index 5757f9a..dac3b23 100644
> > --- a/config/patch_parser.cfg
> > +++ b/config/patch_parser.cfg
> > @@ -13,6 +13,7 @@ app = application
> > license = documentation
> > VERSION = documentation
> > build = core
> > +dts = dts
> >
> > # This is an ordered list of the importance of each patch
> classification.
> > # It should be used to determine which classification to use on tools
> which
> > @@ -22,4 +23,5 @@ priority_list =
> > core,
> > driver,
> > application,
> > - documentation
> > + documentation,
> > + dts
>
>
[-- Attachment #2: Type: text/html, Size: 2657 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-10-07 15:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-01 17:07 [PATCH] config: adding dts tag for dts path patches Manit Mahajan
2024-10-01 17:19 ` Patrick Robb
2024-10-04 14:01 ` Aaron Conole
2024-10-04 17:54 ` Patrick Robb
2024-10-07 12:56 ` Luca Vizzarro
2024-10-07 15:52 ` Aaron Conole
2024-10-07 15:54 ` Patrick Robb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).