From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ci-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8913842830 for <public@inbox.dpdk.org>; Fri, 24 Mar 2023 14:34:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8477F406B8; Fri, 24 Mar 2023 14:34:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 235974021F for <ci@dpdk.org>; Fri, 24 Mar 2023 14:34:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679664863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TbyPw23TcSa5ime1TweK+uo/N0zb1+22+HysCGIkX2U=; b=Dq2+GTFPlJon6VPB8xGUNY+ctz9md1l/XwPJzTeXO4Q4TF3Un1sTtxAn4K27b0T5n+rMmt 4Aj4OwbKoZ15jVEdmTNAe4mC2657bULEoFFm13lm+QNtH0mrThQkIs7WTGVmzCaEi+bRxx QWH2bup6hf7eG6JkjWp5TGVYsSHXeE4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-652-PzYlBHNgP76gxY5ZtAf15w-1; Fri, 24 Mar 2023 09:34:20 -0400 X-MC-Unique: PzYlBHNgP76gxY5ZtAf15w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F2C80858F09; Fri, 24 Mar 2023 13:34:19 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.10.240]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D111B202701E; Fri, 24 Mar 2023 13:34:19 +0000 (UTC) From: Aaron Conole <aconole@redhat.com> To: jspewock@iol.unh.edu Cc: ci@dpdk.org Subject: Re: [PATCH v5 0/4] Add ACVP tool References: <20230315172837.29736-1-jspewock@iol.unh.edu> Date: Fri, 24 Mar 2023 09:34:19 -0400 In-Reply-To: <20230315172837.29736-1-jspewock@iol.unh.edu> (jspewock@iol.unh.edu's message of "Wed, 15 Mar 2023 13:28:34 -0400") Message-ID: <f7tbkkip92c.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions <ci.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/ci>, <mailto:ci-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/ci/> List-Post: <mailto:ci@dpdk.org> List-Help: <mailto:ci-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/ci>, <mailto:ci-request@dpdk.org?subject=subscribe> Errors-To: ci-bounces@dpdk.org jspewock@iol.unh.edu writes: > From: Jeremy Spewock <jspewock@iol.unh.edu> > > v1: https://mails.dpdk.org/archives/ci/2022-January/001599.html > v2: https://mails.dpdk.org/archives/ci/2022-January/001611.html > v3: https://mails.dpdk.org/archives/ci/2022-February/001636.html > v4: https://mails.dpdk.org/archives/ci/2022-April/001702.html > v5: > * updated out-of-date readme to better match current implementation > * updated default config file to support more algorithms Just one nit that I sent. Overall, LGTM. > Brandon Lo (4): > tools: add acvp_tool > tools: add default config file for acvp_tool > tools: add requirements file for acvp_tool > doc: add readme file for acvp_tool > > tools/acvp/README | 129 +++++++++++++++ > tools/acvp/__init__.py | 0 > tools/acvp/acvp_config.json | 52 ++++++ > tools/acvp/acvp_tool.py | 319 ++++++++++++++++++++++++++++++++++++ > tools/acvp/requirements.txt | 7 + > 5 files changed, 507 insertions(+) > create mode 100644 tools/acvp/README > create mode 100644 tools/acvp/__init__.py > create mode 100644 tools/acvp/acvp_config.json > create mode 100755 tools/acvp/acvp_tool.py > create mode 100644 tools/acvp/requirements.txt