From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD369439B7; Wed, 24 Jan 2024 16:55:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7F1542DF2; Wed, 24 Jan 2024 16:55:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B34C742DEE for ; Wed, 24 Jan 2024 16:55:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706111721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jsq9hq6p+2DDs3sQ69P/6u6PpPEkImkpoGVNMzgZckw=; b=b7fdR1p+ibmVqPuOflPaQIiiHtrP27uQQtO0qICvoBYPyukC38eUOxnvM9akSOPj9JDSf9 eMnRzVV6baaDFtnj/sm315KLmaBDy7Dr6PnHdzKgxMvh3ch0UdDHsHmgRu6qscaw1Jdg+P eDKTgZMOeqdxodR+ze4U6uNK4vWhjnA= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-SmJ4wtXPPyCgFg_zNzP5LQ-1; Wed, 24 Jan 2024 10:55:20 -0500 X-MC-Unique: SmJ4wtXPPyCgFg_zNzP5LQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9A260383CCEB; Wed, 24 Jan 2024 15:55:19 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.33.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6E6D62166B32; Wed, 24 Jan 2024 15:55:19 +0000 (UTC) From: Aaron Conole To: Michael Santana Cc: ci@dpdk.org, Ilya Maximets Subject: Re: [PATCH] post_pw: Correct the patch ID detection. References: <20240124133804.73253-1-aconole@redhat.com> Date: Wed, 24 Jan 2024 10:55:19 -0500 In-Reply-To: (Michael Santana's message of "Wed, 24 Jan 2024 09:39:07 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Michael Santana writes: > On Wed, Jan 24, 2024 at 8:38=E2=80=AFAM Aaron Conole = wrote: >> >> The patch ID detection regex can match on multiple instances of the >> reported patch url. That will cause us to send a bad API request >> into the patchwork server. Correct this by only trusting the first >> value to be sent. >> >> Signed-off-by: Aaron Conole > Acked-by: Michael Santana Thanks - applied. >> --- >> post_pw.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/post_pw.sh b/post_pw.sh >> index a8111ff..f11c444 100755 >> --- a/post_pw.sh >> +++ b/post_pw.sh >> @@ -63,7 +63,7 @@ send_post() { >> context=3D"$(echo "$report" | sed -n 's/.*Test-Label: //p' | tr ' '= '_' | tr ':' '-')" >> state=3D"$(echo "$report" | sed -n 's/.*Test-Status: //p' | xargs)" >> description=3D"$(echo "$report" | sed -ne 's/^_\(.*\)_$/\1/p')" >> - patch_id=3D"$(echo "$report" | sed -ne 's@.*href.*/patch[es]*/\(.*\= )/\?".*@\1@ip' | sed 's@/@@')" >> + patch_id=3D"$(echo "$report" | sed -ne 's@.*href.*/patch[es]*/\(.*\= )/\?".*@\1@ip' | sed 's@/@@' | head -n 1)" >> target_url=3D"$link" >> >> api_url=3D"${pw_instance}/api/patches/${patch_id}/checks/" >> -- >> 2.41.0 >>