* [PATCH] post_pw: Correct the patch ID detection.
@ 2024-01-24 13:38 Aaron Conole
2024-01-24 14:39 ` Michael Santana
0 siblings, 1 reply; 3+ messages in thread
From: Aaron Conole @ 2024-01-24 13:38 UTC (permalink / raw)
To: ci; +Cc: Michael Santana, Ilya Maximets
The patch ID detection regex can match on multiple instances of the
reported patch url. That will cause us to send a bad API request
into the patchwork server. Correct this by only trusting the first
value to be sent.
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
post_pw.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/post_pw.sh b/post_pw.sh
index a8111ff..f11c444 100755
--- a/post_pw.sh
+++ b/post_pw.sh
@@ -63,7 +63,7 @@ send_post() {
context="$(echo "$report" | sed -n 's/.*Test-Label: //p' | tr ' ' '_' | tr ':' '-')"
state="$(echo "$report" | sed -n 's/.*Test-Status: //p' | xargs)"
description="$(echo "$report" | sed -ne 's/^_\(.*\)_$/\1/p')"
- patch_id="$(echo "$report" | sed -ne 's@.*href.*/patch[es]*/\(.*\)/\?".*@\1@ip' | sed 's@/@@')"
+ patch_id="$(echo "$report" | sed -ne 's@.*href.*/patch[es]*/\(.*\)/\?".*@\1@ip' | sed 's@/@@' | head -n 1)"
target_url="$link"
api_url="${pw_instance}/api/patches/${patch_id}/checks/"
--
2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] post_pw: Correct the patch ID detection.
2024-01-24 13:38 [PATCH] post_pw: Correct the patch ID detection Aaron Conole
@ 2024-01-24 14:39 ` Michael Santana
2024-01-24 15:55 ` Aaron Conole
0 siblings, 1 reply; 3+ messages in thread
From: Michael Santana @ 2024-01-24 14:39 UTC (permalink / raw)
To: Aaron Conole; +Cc: ci, Ilya Maximets
On Wed, Jan 24, 2024 at 8:38 AM Aaron Conole <aconole@redhat.com> wrote:
>
> The patch ID detection regex can match on multiple instances of the
> reported patch url. That will cause us to send a bad API request
> into the patchwork server. Correct this by only trusting the first
> value to be sent.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
Acked-by: Michael Santana <msantana@redhat.com>
> ---
> post_pw.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/post_pw.sh b/post_pw.sh
> index a8111ff..f11c444 100755
> --- a/post_pw.sh
> +++ b/post_pw.sh
> @@ -63,7 +63,7 @@ send_post() {
> context="$(echo "$report" | sed -n 's/.*Test-Label: //p' | tr ' ' '_' | tr ':' '-')"
> state="$(echo "$report" | sed -n 's/.*Test-Status: //p' | xargs)"
> description="$(echo "$report" | sed -ne 's/^_\(.*\)_$/\1/p')"
> - patch_id="$(echo "$report" | sed -ne 's@.*href.*/patch[es]*/\(.*\)/\?".*@\1@ip' | sed 's@/@@')"
> + patch_id="$(echo "$report" | sed -ne 's@.*href.*/patch[es]*/\(.*\)/\?".*@\1@ip' | sed 's@/@@' | head -n 1)"
> target_url="$link"
>
> api_url="${pw_instance}/api/patches/${patch_id}/checks/"
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] post_pw: Correct the patch ID detection.
2024-01-24 14:39 ` Michael Santana
@ 2024-01-24 15:55 ` Aaron Conole
0 siblings, 0 replies; 3+ messages in thread
From: Aaron Conole @ 2024-01-24 15:55 UTC (permalink / raw)
To: Michael Santana; +Cc: ci, Ilya Maximets
Michael Santana <msantana@redhat.com> writes:
> On Wed, Jan 24, 2024 at 8:38 AM Aaron Conole <aconole@redhat.com> wrote:
>>
>> The patch ID detection regex can match on multiple instances of the
>> reported patch url. That will cause us to send a bad API request
>> into the patchwork server. Correct this by only trusting the first
>> value to be sent.
>>
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
> Acked-by: Michael Santana <msantana@redhat.com>
Thanks - applied.
>> ---
>> post_pw.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/post_pw.sh b/post_pw.sh
>> index a8111ff..f11c444 100755
>> --- a/post_pw.sh
>> +++ b/post_pw.sh
>> @@ -63,7 +63,7 @@ send_post() {
>> context="$(echo "$report" | sed -n 's/.*Test-Label: //p' | tr ' ' '_' | tr ':' '-')"
>> state="$(echo "$report" | sed -n 's/.*Test-Status: //p' | xargs)"
>> description="$(echo "$report" | sed -ne 's/^_\(.*\)_$/\1/p')"
>> - patch_id="$(echo "$report" | sed -ne 's@.*href.*/patch[es]*/\(.*\)/\?".*@\1@ip' | sed 's@/@@')"
>> + patch_id="$(echo "$report" | sed -ne 's@.*href.*/patch[es]*/\(.*\)/\?".*@\1@ip' | sed 's@/@@' | head -n 1)"
>> target_url="$link"
>>
>> api_url="${pw_instance}/api/patches/${patch_id}/checks/"
>> --
>> 2.41.0
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-24 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-24 13:38 [PATCH] post_pw: Correct the patch ID detection Aaron Conole
2024-01-24 14:39 ` Michael Santana
2024-01-24 15:55 ` Aaron Conole
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).