From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7E7842EAB; Tue, 18 Jul 2023 16:21:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA451410D3; Tue, 18 Jul 2023 16:21:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 96A5140A84 for ; Tue, 18 Jul 2023 16:21:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689690068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sCg2hLYoBH+8WHd0gmHB2uQDaS0GgG+2MnwxLRxopJ0=; b=L5F0MeotNPSEpsHhnhy07RTOoPkjzM97sStUgjHPCzJZzfmNyknNBDn6OVRrz7BYlaDCLL ZwOsfg3KI+ymASv9rXUrZeOTH45asZ/m6kOuTXZ/odlAEJbls++Q1q0uTM/JNl2rcBnsko 6xqu0onBZZUsir/+7FbNXfKb+OXAx/I= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-554-diWqlKR7Ml6rUTjOCk4cmA-1; Tue, 18 Jul 2023 10:19:42 -0400 X-MC-Unique: diWqlKR7Ml6rUTjOCk4cmA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 116AD384CC63; Tue, 18 Jul 2023 14:17:33 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.34.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF367C2C863; Tue, 18 Jul 2023 14:17:32 +0000 (UTC) From: Aaron Conole To: Adam Hassick Cc: ci@dpdk.org, alialnu@nvidia.com Subject: Re: [PATCH v7 0/6] Community Lab Containers and Builder Engine References: <20230711202124.1636317-1-ahassick@iol.unh.edu> Date: Tue, 18 Jul 2023 10:17:32 -0400 In-Reply-To: (Adam Hassick's message of "Tue, 18 Jul 2023 09:40:40 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Adam Hassick writes: > These issues are fixed in v8. Thanks > On Mon, Jul 17, 2023 at 3:07=E2=80=AFPM Aaron Conole = wrote: > > Adam Hassick writes: > > > This patch series contains a new version of the DPDK CI containers. Th= e old > > version was tied very tightly to the Community Lab Infrastructure, so = it was > > not suitable for general use. This version is designed to make adding = new > > OSes or OS versions as easy as possible. The minimum functionality can= easily > > be built on any system that can compile DPDK. It includes support for > > building containers for other non-native architectures (ex: arm contai= ners > > on x86) and for baking ABI references into the images. > > > > The inventory file as added in this patch series defines what the comm= unity lab > > currently supports. > > > > If you want to build these yourself, don't try to do parallel Makefile= builds > > on non-server hardware. Libabigail is built into the containers, and s= ince it > > is not avaliable in all distros it is compiled from source for many ta= rgets. > > If embedding the abi is enabled (DPDK_CI_CONTAINERS_BUILD_ABI=3DY), wi= th the > > current settings, DPDK will be compiled twice for every target in the > > inventory file. This will become three times when DPDK main has ABI st= ability > > again. Due to how the containers are constructed, building on non-nati= ve > > architectures is especially expensive because DPDK is compiled with an= emulated > > compiler in a qemu vm that only has one thread. > > > > --- > > > > v2: > > * Added poetry.lock > > * Remove duplicates in inventory file > > * Fix typo in base container template > > > > v3: > > * Libabigail is now not built by default unless DPDK_CI_CONTAINERS_BUI= LD_ABI=3Dy > > * Made minimum podman version 4.0.0 due to dependencies on cache mount= s > > > > v4: > > * Fix whitespace errors > > > > v5: > > * Updated container templates and inventory > > * Add support for OCI manifests > > * Update README to reflect changes > > > > v6: > > * Fix spelling errors and whitespace errors > > > > v7: > > * Add workaround to Arch template to install Python packages as root > > * Compare against v4 and polish the patchset > > Please can you repost with the spelling fixes, and also fixing Owen's > email address? (it is currently listed like a mailing list archive). > > > Owen Hilyard (6): > > * Add README file for containers * Add pyproject file with required > > dependencies for building containers > > Adds a yaml file used to define what containers should be built, wha= t > > packages the containers should have, what platforms to build for a= nd > > how they should be tagged. > > This script will template out all of the Dockerfiles based on the > > definitions provided in the inventory using the jinja2 templating > > library. > > Adds a variety of extensible templates used to create the Dockerfile= s > > for each target. All templates inherit from base, and most distros > > and distro families have their own templates that are used to defi= ne > > common functionality. Multiple versions of a distro may use a sing= le > > template if they are similar enough (ex: fedora). > > Adds a container that can be used to run the python scripts to creat= e > > the Dockerfiles for the CI containers. This removes a large number > > of python environment dependencies from the host requirements. > > The Makefile that can be used to build all of the container images > > using "make build", and can also be used to push them to a remote > > repository (for use in CI). > > > > containers/Makefile | 252 ++++++++++ > > containers/README.md | 178 +++++++ > > containers/container_builder.dockerfile | 26 + > > containers/template_engine/inventory.yaml | 470 +++++++++++++++++= + > > .../template_engine/inventory_schema.json | 221 ++++++++ > > containers/template_engine/make_dockerfile.py | 358 +++++++++++++ > > containers/template_engine/poetry.lock | 220 ++++++++ > > containers/template_engine/pyproject.toml | 21 + > > .../templates/containers.makefile.j2 | 73 +++ > > .../templates/containers/alpine.dockerfile.j2 | 3 + > > .../templates/containers/arch.dockerfile.j2 | 39 ++ > > .../templates/containers/base.dockerfile.j2 | 120 +++++ > > .../containers/centos8.dockerfile.j2 | 21 + > > .../containers/centos9.dockerfile.j2 | 17 + > > .../templates/containers/debian.dockerfile.j2 | 7 + > > .../containers/debian10.dockerfile.j2 | 3 + > > .../containers/debian11.dockerfile.j2 | 3 + > > .../debian11_arm_ipsec.dockerfile.j2 | 16 + > > .../containers/debian_bullseye.dockerfile.j2 | 3 + > > .../containers/debian_buster.dockerfile.j2 | 3 + > > .../templates/containers/fedora.dockerfile.j2 | 11 + > > .../containers/fedora36_clang.dockerfile.j2 | 7 + > > .../containers/fedora_clang.dockerfile.j2 | 8 + > > .../containers/fedora_coverity.dockerfile.j2 | 10 + > > .../containers/opensuse.dockerfile.j2 | 10 + > > .../containers/redhat_family.dockerfile.j2 | 5 + > > .../templates/containers/rhel.dockerfile.j2 | 16 + > > .../templates/containers/rhel7.dockerfile.j2 | 15 + > > .../templates/containers/rhel8.dockerfile.j2 | 15 + > > .../templates/containers/rhel9.dockerfile.j2 | 19 + > > .../templates/containers/rpm.dockerfile.j2 | 3 + > > .../templates/containers/ubuntu.dockerfile.j2 | 3 + > > .../containers/ubuntu20.04.dockerfile.j2 | 12 + > > .../containers/ubuntu22.04.dockerfile.j2 | 3 + > > .../containers/ubuntu_cross.dockerfile.j2 | 11 + > > .../containers/ubuntu_sve.dockerfile.j2 | 12 + > > 36 files changed, 2214 insertions(+) > > create mode 100644 containers/Makefile > > create mode 100644 containers/README.md > > create mode 100644 containers/container_builder.dockerfile > > create mode 100644 containers/template_engine/inventory.yaml > > create mode 100644 containers/template_engine/inventory_schema.json > > create mode 100755 containers/template_engine/make_dockerfile.py > > create mode 100644 containers/template_engine/poetry.lock > > create mode 100644 containers/template_engine/pyproject.toml > > create mode 100644 containers/template_engine/templates/containers.ma= kefile.j2 > > create mode 100644 containers/template_engine/templates/containers/al= pine.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/ar= ch.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/ba= se.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/ce= ntos8.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/ce= ntos9.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/de= bian.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/de= bian10.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/de= bian11.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/de= bian11_arm_ipsec.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/de= bian_bullseye.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/de= bian_buster.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/fe= dora.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/fe= dora36_clang.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/fe= dora_clang.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/fe= dora_coverity.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/op= ensuse.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/re= dhat_family.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/rh= el.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/rh= el7.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/rh= el8.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/rh= el9.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/rp= m.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/ub= untu.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/ub= untu20.04.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/ub= untu22.04.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/ub= untu_cross.dockerfile.j2 > > create mode 100644 containers/template_engine/templates/containers/ub= untu_sve.dockerfile.j2