From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 935BB43699; Thu, 7 Dec 2023 20:07:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 701AB42F2D; Thu, 7 Dec 2023 20:07:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A056742F04 for ; Thu, 7 Dec 2023 20:07:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701976045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=b7SaiuQqU2DcGDIqps9vLlGIT2VNg3XXhI1ZT9hIKDQ=; b=e2cw9QjX5FIDoU8Rd7enfHR5izf9hfk08rQFiFJyEpSw3wAThE1F/HuRBRFLI0JvVMOzSe a5LwKLwmt6THKwSzk2ZEWwbftqtzRgMUkzlVX9EXZe0E+tAsIN0qvX0JnqCawFFx5kg7j8 CrYXs1NmG2Avmlq+iYJLanRuNkbcObc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-202-eMgzG9QzMN2CJbaFGREp1g-1; Thu, 07 Dec 2023 14:07:22 -0500 X-MC-Unique: eMgzG9QzMN2CJbaFGREp1g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A87DD85A589; Thu, 7 Dec 2023 19:07:21 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.17.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3AC52026D66; Thu, 7 Dec 2023 19:07:20 +0000 (UTC) From: Aaron Conole To: Min Zhou Cc: ci@dpdk.org, msantana@redhat.com, dmarchan@redhat.com, thomas@monjalon.net, probb@iol.unh.edu, dceara@redhat.com Subject: Re: [PATCH v1] tools: fix parsing message-id in the headers of email References: <20231204025246.14779-1-zhoumin@loongson.cn> Date: Thu, 07 Dec 2023 14:07:20 -0500 In-Reply-To: <20231204025246.14779-1-zhoumin@loongson.cn> (Min Zhou's message of "Mon, 4 Dec 2023 02:52:46 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Min Zhou writes: > Some email has the message-id header named "Message-id", like this: > https://patches.dpdk.org/project/dpdk/patch/20230930010024.34377-1-rdna@apple.com/. > So add the parsing for this kind of email. > > Signed-off-by: Min Zhou > --- Hi Min, I wonder - we will keep having this issue of these header fields being incorrectly matched based on case issues. Maybe we should make getheader have the ability to ignore case, or pass something like Message-[iI][dD] as the header argument. WDYT? > tools/parse-email.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/parse-email.sh b/tools/parse-email.sh > index 9cb9583..fbe038a 100755 > --- a/tools/parse-email.sh > +++ b/tools/parse-email.sh > @@ -35,6 +35,7 @@ subject=$(getheader Subject "$1") > from=$(getheader From "$1") > msgid=$(getheader Message-Id "$1") > [ -n "$msgid" ] || msgid=$(getheader Message-ID "$1") > +[ -n "$msgid" ] || msgid=$(getheader Message-id "$1") > pwid=$(getheader X-Patchwork-Id "$1") > listid=$(getheader List-Id "$1") > reply=$(getheader In-Reply-To "$1")