From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5F7942F71; Fri, 28 Jul 2023 22:39:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A086040EE3; Fri, 28 Jul 2023 22:39:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 656A840685 for ; Fri, 28 Jul 2023 22:39:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690576740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YOxqgo9wSd2piyFU1W58QkkFO8aTyv2PmU/RNNnrmHA=; b=Q5sFdD8EBIr6tCa+3hJcBqcDOJXqIa5/1jEcrcVDlwrOUEAkqqZtYS4JJAxtC+BvZhLxzt Kgr7qrhj8oDiauHciFaf0JO4YjKOSu7ldTKdEidhMnqpdANQF9Sx/Ewr9fuC+22lZdgE9b j4pNau/QAuXNhL1GAUtMf6TPHzYRKds= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-wO31-op8M32hcKki5tzf-w-1; Fri, 28 Jul 2023 16:38:59 -0400 X-MC-Unique: wO31-op8M32hcKki5tzf-w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A6C56101A54E; Fri, 28 Jul 2023 20:38:58 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.8.217]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 592D2F7827; Fri, 28 Jul 2023 20:38:58 +0000 (UTC) From: Aaron Conole To: Adam Hassick Cc: ci@dpdk.org, alialnu@nvidia.com Subject: Re: [PATCH v8 0/6] Community Lab Containers and Builder Engine References: <20230717210815.29737-1-ahassick@iol.unh.edu> Date: Fri, 28 Jul 2023 16:38:57 -0400 In-Reply-To: <20230717210815.29737-1-ahassick@iol.unh.edu> (Adam Hassick's message of "Mon, 17 Jul 2023 17:08:09 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Adam Hassick writes: > This patch series contains a new version of the DPDK CI containers. The old > version was tied very tightly to the Community Lab Infrastructure, so it was > not suitable for general use. This version is designed to make adding new > OSes or OS versions as easy as possible. The minimum functionality can easily > be built on any system that can compile DPDK. It includes support for > building containers for other non-native architectures (ex: arm containers > on x86) and for baking ABI references into the images. > > The inventory file as added in this patch series defines what the community lab > currently supports. > > If you want to build these yourself, don't try to do parallel Makefile builds > on non-server hardware. Libabigail is built into the containers, and since it > is not avaliable in all distros it is compiled from source for many targets. > If embedding the abi is enabled (DPDK_CI_CONTAINERS_BUILD_ABI=Y), with the > current settings, DPDK will be compiled twice for every target in the > inventory file. This will become three times when DPDK main has ABI stability > again. Due to how the containers are constructed, building on non-native > architectures is especially expensive because DPDK is compiled with an emulated > compiler in a qemu vm that only has one thread. > > --- I plan to apply this on Monday unless Ali posts something. > v2: > * Added poetry.lock > * Remove duplicates in inventory file > * Fix typo in base container template > > v3: > * Libabigail is now not built by default unless DPDK_CI_CONTAINERS_BUILD_ABI=y > * Made minimum podman version 4.0.0 due to dependencies on cache mounts > > v4: > * Fix whitespace errors > > v5: > * Updated container templates and inventory > * Add support for OCI manifests > * Update README to reflect changes > > v6: > * Fix spelling errors and whitespace errors > > v7: > * Add workaround to Arch template to install Python packages as root > * Compare against v4 and polish the patchset > > v8: > * Fix typos > * Correct the default for the dpdk-stable clone URL > > Owen Hilyard (6): > containers/docs: Add container builder start > containers/inventory: Add inventory for container builder > containers/builder: Dockerfile creation script > containers/templates: Templates for Dockerfiles > containers/container_builder: Container for python scripts > containers/Makefile: Makefile to automate builds > > containers/Makefile | 250 ++++++++++ > containers/README.md | 178 +++++++ > containers/container_builder.dockerfile | 26 + > containers/template_engine/inventory.yaml | 470 ++++++++++++++++++ > .../template_engine/inventory_schema.json | 221 ++++++++ > containers/template_engine/make_dockerfile.py | 358 +++++++++++++ > containers/template_engine/poetry.lock | 220 ++++++++ > containers/template_engine/pyproject.toml | 21 + > .../templates/containers.makefile.j2 | 73 +++ > .../templates/containers/alpine.dockerfile.j2 | 3 + > .../templates/containers/arch.dockerfile.j2 | 39 ++ > .../templates/containers/base.dockerfile.j2 | 120 +++++ > .../containers/centos8.dockerfile.j2 | 21 + > .../containers/centos9.dockerfile.j2 | 17 + > .../templates/containers/debian.dockerfile.j2 | 7 + > .../containers/debian10.dockerfile.j2 | 3 + > .../containers/debian11.dockerfile.j2 | 3 + > .../debian11_arm_ipsec.dockerfile.j2 | 16 + > .../containers/debian_bullseye.dockerfile.j2 | 3 + > .../containers/debian_buster.dockerfile.j2 | 3 + > .../templates/containers/fedora.dockerfile.j2 | 11 + > .../containers/fedora36_clang.dockerfile.j2 | 7 + > .../containers/fedora_clang.dockerfile.j2 | 8 + > .../containers/fedora_coverity.dockerfile.j2 | 10 + > .../containers/opensuse.dockerfile.j2 | 10 + > .../containers/redhat_family.dockerfile.j2 | 5 + > .../templates/containers/rhel.dockerfile.j2 | 16 + > .../templates/containers/rhel7.dockerfile.j2 | 15 + > .../templates/containers/rhel8.dockerfile.j2 | 15 + > .../templates/containers/rhel9.dockerfile.j2 | 19 + > .../templates/containers/rpm.dockerfile.j2 | 3 + > .../templates/containers/ubuntu.dockerfile.j2 | 3 + > .../containers/ubuntu20.04.dockerfile.j2 | 12 + > .../containers/ubuntu22.04.dockerfile.j2 | 3 + > .../containers/ubuntu_cross.dockerfile.j2 | 11 + > .../containers/ubuntu_sve.dockerfile.j2 | 12 + > 36 files changed, 2212 insertions(+) > create mode 100644 containers/Makefile > create mode 100644 containers/README.md > create mode 100644 containers/container_builder.dockerfile > create mode 100644 containers/template_engine/inventory.yaml > create mode 100644 containers/template_engine/inventory_schema.json > create mode 100755 containers/template_engine/make_dockerfile.py > create mode 100644 containers/template_engine/poetry.lock > create mode 100644 containers/template_engine/pyproject.toml > create mode 100644 containers/template_engine/templates/containers.makefile.j2 > create mode 100644 containers/template_engine/templates/containers/alpine.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/arch.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/base.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/centos8.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/centos9.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/debian.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/debian10.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/debian11.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/debian11_arm_ipsec.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/debian_bullseye.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/debian_buster.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/fedora.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/fedora36_clang.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/fedora_clang.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/fedora_coverity.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/opensuse.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/redhat_family.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/rhel.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/rhel7.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/rhel8.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/rhel9.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/rpm.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/ubuntu.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/ubuntu20.04.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/ubuntu22.04.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/ubuntu_cross.dockerfile.j2 > create mode 100644 containers/template_engine/templates/containers/ubuntu_sve.dockerfile.j2