DPDK CI discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Patrick Robb" <probb@iol.unh.edu>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"Adam Hassick" <ahassick@iol.unh.edu>,
	thomas@monjalon.net, ci@dpdk.org, dts@dpdk.org
Subject: Re: Skip tests on Depends-on tag
Date: Tue, 05 Sep 2023 12:00:33 -0400	[thread overview]
Message-ID: <f7ty1hkobj2.fsf@redhat.com> (raw)
In-Reply-To: <CAJFAV8wNJTwvfP9EP5q-5sR=yrVZA9wSxkLZw-Lpg4iFy-O+2w@mail.gmail.com> (David Marchand's message of "Tue, 5 Sep 2023 09:10:18 +0200")

David Marchand <david.marchand@redhat.com> writes:

> Hello Patrick, Morten,
>
> On Tue, Sep 5, 2023 at 3:22 AM Patrick Robb <probb@iol.unh.edu> wrote:
>>
>> Thanks for the suggestion. I'm also thinking the community lab should move to an apply-patchset process like:
>>     -if commit message contains "depends-on", then:
>>         -get depends-on series id
>>         -get referenced patch series and attempt to apply, and if successful then attempt to apply original patch on that.
>>         -run testing
>>
>> I see that the github-robot reported a PASS, so they might already be doing this. I'll raise it during the next CI meeting and see what the ci group thinks or if they've discussed this before. Maybe there are some issues with this which I'm not thinking of, but we'll see what the group thinks.
>
> My two cents (and copying Aaron): the ovsrobot (for dpdk) handles some
> part of the Depends-on: series-XXX logic, indeed.
> https://github.com/ovsrobot/pw-ci/commit/f2a73a46464424e977d4f8877e9a32314e4a0a07
> https://github.com/ovsrobot/pw-ci/commit/3d263267cbd2d0c7b962aaaade9815379d03bba2
>
> If you look at the 29416 or 29417 series branch history, you'll see
> changes from series 29415:
> https://github.com/ovsrobot/dpdk/commits/series_29417

Yes - we do handle depends-on as noted.  It would be good for the lab to
support this as well.  Support shouldn't be terribly difficult to
provide to the apply process, and it seems it is getting more use lately.


      reply	other threads:[~2023-09-05 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 10:02 Morten Brørup
2023-09-05  1:22 ` Patrick Robb
2023-09-05  7:10   ` David Marchand
2023-09-05 16:00     ` Aaron Conole [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ty1hkobj2.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=ahassick@iol.unh.edu \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=dts@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=probb@iol.unh.edu \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).