From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3BA042D17 for ; Wed, 21 Jun 2023 20:38:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C033E4068E; Wed, 21 Jun 2023 20:38:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 117224003C for ; Wed, 21 Jun 2023 20:38:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687372734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TjmofPP24NtNp9Se7VQHT82Zp2W2MmudMA1E91lCkQQ=; b=Z8rgxx90mCKYP1VAO8IDXG0Z3+e1w8/FNrx/ljBD+ogSe43bwckJOsqRSlPD40+2BNAyCv CbwS8cv7yX1Izs7xUj+x2Cp3EENYtXstGBDo/h0zmcs1dV+4pm7xbZq9RkOQB1xwr3C6pA L8VwRHdHrAqKoXBOMAJ5DSZMuHMp/UA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-641-0uQRA9CSPwaeDuYxPj4MwQ-1; Wed, 21 Jun 2023 14:38:50 -0400 X-MC-Unique: 0uQRA9CSPwaeDuYxPj4MwQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4A3E685A58A; Wed, 21 Jun 2023 18:38:34 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.32.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B0E9492C13; Wed, 21 Jun 2023 18:38:30 +0000 (UTC) From: Aaron Conole To: Patrick Robb Cc: Ali Alnubani , "ci@dpdk.org" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "ohilyard@iol.unh.edu" Subject: Re: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff References: <20220207150826.18950-1-ohilyard@iol.unh.edu> <20220207150826.18950-3-ohilyard@iol.unh.edu> Date: Wed, 21 Jun 2023 14:38:28 -0400 In-Reply-To: (Patrick Robb's message of "Wed, 21 Jun 2023 11:39:53 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Patrick Robb writes: > Patrick, are [1/3] and [2/3] still needed as well? > > Yes please on both. We are currently using 1/3 in our Jenkins process for= including tag arguments in creating > the execution file. Thanks for raising this. Looks like this slipped my queue. I'll apply it now. Thanks. > =20 > > On Wed, Jun 21, 2023 at 11:19=E2=80=AFAM Ali Alnubani wrote: > > > -----Original Message----- > > From: Ali Alnubani > > Sent: Monday, February 7, 2022 5:56 PM > > To: ohilyard@iol.unh.edu; ci@dpdk.org > > Subject: RE: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by em= pty diff > >=20 > > > -----Original Message----- > > > From: ohilyard@iol.unh.edu > > > Sent: Monday, February 7, 2022 5:08 PM > > > To: ci@dpdk.org; Ali Alnubani > > > Cc: Owen Hilyard > > > Subject: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empt= y diff > > > > > > From: Owen Hilyard > > > > > > A sanity check has been added to find_filenames. Occasionally, due t= o > > > how the community lab internally handles getting patches from > > > patchworks, a patch will result in no diff. This patch adds handling= for > > > this case. > > > > > > Signed-off-by: Owen Hilyard > > > --- > >=20 > > Thanks Owen. > >=20 > > Tested-by: Ali Alnubani > > Acked-by: Ali Alnubani > > Hi Thomas and Aaron, > > Can we merge this patch? Pull requests can still cause the script to cra= sh because they have an empty > diff. > > Patrick, are [1/3] and [2/3] still needed as well? > > Thanks, > Ali