From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAC2342937 for ; Thu, 13 Apr 2023 23:20:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B83C041138; Thu, 13 Apr 2023 23:20:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7E1AC410F9 for ; Thu, 13 Apr 2023 23:20:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681420819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aQowHchDFTlZtxzPcHz223siDoMecGa+5lkOpyy/nXc=; b=h18LiILfAy4bvTqzqvkSCnGjpeaFKDghesiZukkjG1KpOWlGejpJKInOAPYIHW92BRELWr jvsf2Idq/59SxqhcKsgH4knLSO/qUrXms5cG7PFcmQGkuijGuO4+nKSBhphZZuh3E3evfP cKAQZz40e3DvSEXI7CAyCA92uc7xBs0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-378-rHzCPlbWOYqaYgVFzvnelg-1; Thu, 13 Apr 2023 17:20:14 -0400 X-MC-Unique: rHzCPlbWOYqaYgVFzvnelg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2520888B7A8; Thu, 13 Apr 2023 21:20:14 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.8.179]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AF9F8C16028; Thu, 13 Apr 2023 21:20:13 +0000 (UTC) From: Aaron Conole To: Jeremy Spewock Cc: Thomas Monjalon , Patrick Robb , Ali Alnubani , "ci@dpdk.org" Subject: Re: [PATCH v7 0/4] Add ACVP Tool References: <20230403183930.12001-2-jspewock@iol.unh.edu> <2276688.ElGaqSPkdT@thomas> Date: Thu, 13 Apr 2023 17:20:13 -0400 In-Reply-To: (Jeremy Spewock's message of "Wed, 12 Apr 2023 17:10:40 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org Jeremy Spewock writes: > Hello, > > I can see why you would want to squash everything into one patch; I had j= ust thought that the intention with > maintaining the structure of the old patch series was to preserve Brandon= 's original commits and comments alongside > some minor expansion where necessary. If it would be preferred however, I= can resubmit with everything squashed into > a single patch. > > Aaron, if you could also review this series and give your thoughts on the= matter as well that would be greatly > appreciated. After looking at the structure, I agree with Thomas about squashing. Generally, try to introduce the change as a complete atom. In this case, we don't extend anything anywhere else. If there were other scripts, etc. then we could do that. When I see the squashed patch come through, I can apply and push. Thanks! > Thanks, > Jeremy > > On Wed, Apr 12, 2023 at 4:16=E2=80=AFAM Thomas Monjalon wrote: > > Hi, > > Aaron is the maintainer. > I can also push the commits. > > I think you should squash all in one patch > and provide an explanation in the commit message > about what this tool is for exactly. > > 11/04/2023 23:22, Patrick Robb: > > Hi Ali, > >=20 > > Aaron says he is not a maintainer either. Do you know whether there is= some > > place I can look to see who the current maintainers are? There isn't a= n > > equivalent to the MAINTAINERS file like in the main DPDK repo. > >=20 > > Thomas, you might be the only current maintainer on this repo. We'll b= e > > grateful at the lab if you're able to merge this patch. > >=20 > > Best, > > Patrick > >=20 > > On Mon, Apr 10, 2023 at 11:19=E2=80=AFAM Ali Alnubani wrote: > >=20 > > > > Hi Ali, > > > > > > > > Is this good to be merged since it's been acked by a maintainer wi= th no > > > more discussion afterwards? Or is there something more to be done he= re? > > > [..] > > > > > > Hello Patrick, > > > > > > Already acked from my side, waiting for a maintainer to merge if the= y have > > > no other comments (Thomas/Aaron). > > > > > > Thanks, > > > Ali