From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0F3343CEE; Tue, 19 Mar 2024 16:30:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA16840ED2; Tue, 19 Mar 2024 16:30:00 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2050.outbound.protection.outlook.com [40.107.93.50]) by mails.dpdk.org (Postfix) with ESMTP id B386E40ED0; Tue, 19 Mar 2024 16:29:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G0gyGs4l+gIZsGAAtJwbzXeOLsZMzn1ZErLyTuioTfkNbXR6STMij+bcVjQnBKEGWg8MCfHTaOiIQkwKi/sAHSDZzz3tSGRzJ7mCMSymu4aBvzL+6vF/ahmvmdOJ594dr2RKdSaTGldxKhh34zU9kMzrhXzWYZttcsfrTn2fx8ckK1rDCSzv3JWFpdPl/DmqpRNPwGZYjgXlQlUPvLZTG+zyTZuvY+I7h8aLoDks3y78f4ItoYe9lvTg7KBWhlkXFmSjSIRQpyeO8JzyzrrhQ4AcrYqcE+OkM6WmzBhNZJAEfWqqc8J1nbj9g61vopZkD8Rf6g16XxsfHWZYzggD8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ra7tvFnaFXFW76SNtkzBHEf7JbeBaGgL1c+xT3g8Gd0=; b=kl2bve0Gd8ehCWsM4K4mAalXuav0zzQkWPphTKVP2U10OlmDFFzIavJU3AAcfb6wnhOkxaF4JqlsS7Pyv5WIFiVEONp+r7eieyUlKymAzn9z70P4GqG3gUGZ+ymF+4H/6w8gqOdtZa5X2zp0HrfwFMDvVdm3aTcf6Kyt64wap37X5AGYIvoy5U3kNwyQTtPdQllrdE/Fk2i4yY9PX1ZvkkaZS3CLg1aFctGP3DfSruvkHTwl9Iz+LTGHl8PSePhUCKunNUpnCMz8aUFFi9rgHgzG95sYtE+F9JP08UBT6qdGBlK8+641BuXGnMPYfU5uQckjdPr7+ydo31ktYSlP9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ra7tvFnaFXFW76SNtkzBHEf7JbeBaGgL1c+xT3g8Gd0=; b=XxKkGANjWiuXGXpFV+abU/E9SXSRxDS/rnbM2juXu2WN6R/iDrfnFCOUV5xIyK/6RUBPbMY60d1eE6dO+AcoDwOGno/RoecsZ5TJXd6G3ZIYuRpsfaVIBY9jRA5RQsJ7mpr2Cvs6y2YDS5MwQN8dUHw7qwNvjP2lFcZCZhXWU4k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY8PR12MB8214.namprd12.prod.outlook.com (2603:10b6:930:76::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27; Tue, 19 Mar 2024 15:29:57 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7386.025; Tue, 19 Mar 2024 15:29:57 +0000 Message-ID: Date: Tue, 19 Mar 2024 15:29:53 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: fix auto completion for indirect list action Content-Language: en-US From: Ferruh Yigit To: Shani Peretz , dev@dpdk.org Cc: mkashani@nvidia.com, Ori Kam , Aman Singh , Yuying Zhang , Gregory Etelson , "ci@dpdk.org" References: <20240318092109.87656-1-shperetz@nvidia.com> <62669854-8add-4fdd-b882-a63d78f0d6e8@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <62669854-8add-4fdd-b882-a63d78f0d6e8@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0057.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY8PR12MB8214:EE_ X-MS-Office365-Filtering-Correlation-Id: d23288b0-ee3c-4860-b81a-08dc48296f21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: olw5S2C0/bDRUr4H2a9A34T2wZ0CVzzTmAw+Cl0fMdap6msa5WJr/Tfw0jRRLvTJSXEFeHQ4d8gzuThGwFmzCWW/7HJKifjQPOIV8ISKrohDJ9BO/LRnHDdwcq8g76JwC/stDiB4RCZBENIzlQk4zx7a+e2d6h4ri2AOkcw3JmiLem0oH7qUYj39qH0DHR4/zR3r0WHKuFlAuPkhRHWTg1NHV8trmjx7EssZQMdbId0xPNBre/aPeO1jn9MH7F/4dydghdCtCTInKg5z3vogU/7ew+ucDJowV8EjeTNyb+kyYrb7Qx9n8EIytYw6umFdOappDXluDhxMhoLfQpkRGaK6FkJi430J7BSprUPUWhRwC22Un+J6PA0FxIZWK5BreAuwcXPOZUCazIlG6ET/t1R+rzOI3isU28i6u3q7rK7nhQ9xo+tnaHyOviDQWlSilrc2WMEmsHGIO/v5EaCGUbh9eX+gragJ1TbIQPXEbXrbfX7jmuF/vBgTwRIUB7jvKwyW+Okjg/cmYupmK5lCZmSaTrZ/wQIevmSQ058AVSt/KSE2+9p+HYseZIwo1b9+Lf9/o+v2Gwullyaj0TyJOc5jfHHb0jATXZWWewmzY2xcozT7x7NyMsjheiUxDipJEOpy/G8d+AIz7PaMjEgxQUR8RnUHhB8WGRGKZzt87Zc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3hhZ280NXVQTUs2WU55NmFLTVczOUlLZWVVNlN0cXZCV0lCWmxMaEd1RE5l?= =?utf-8?B?cVYyUThMUURkZkppUGQ0WG5NeHR4V1Z5bHNwZWxwY3VDNUJVMnNLRURjNVhu?= =?utf-8?B?NGZuaE1TbThJQlRqYUxzQWZrRVlMRXAyUWsxSjd2WUdpZWMzd1B5cWN2eDJi?= =?utf-8?B?QkRGTG1GU2FZdG1kWG9HdFhpQkNiRDVja1ZVZWJvSEhrZTRET29nelFIdURO?= =?utf-8?B?QkNoL2NLc1ZGNGVYZjBxOEliNUdCOFJDYTlHTngra0psbWo4b2FWNEtzYXEy?= =?utf-8?B?RythdzdtWEk5Vjk4ays5b3ZZdTZOU0hCRzNTNHY2c29kL3RFakx1NlVqenFG?= =?utf-8?B?TC9ORGR0dWNKMUtUWS9YTkpidXBDcDBSdi9PQnN4N1hKeFFVZVVQMk42QnF5?= =?utf-8?B?V1JvVm4zOTlsMVVNL1dtWk15ZWdZKzA5OEdKQ2tyakpLeUtJUG92UHJpZU10?= =?utf-8?B?K1o1OCt0YXRrd2lNWHVTWDRaaUllNkQzZEtseVViZVVRQXBGbDVQNGNpRmM5?= =?utf-8?B?bVNvWEhlTXVOS0ZGRzlidm1nUjFJNDFPZHBQOFEzdTdkaUxSaDJ6RE9RRTJS?= =?utf-8?B?Nk9xZC9jQ1gvQm05QVAvWG5YWm0wOTVnOVUvOWsyMyt0UEJtKzBqSi92UWMw?= =?utf-8?B?QjNJMmtrQS85b3IxZVBKaU9WL1ZhNi81Z3BuVWUxMUhhT0V3RlJpRDFyTkYy?= =?utf-8?B?eUc4VmNWUUIyN1BkRmRsTU9ZbHowK3NFSFp1MzE5WmhmdWtyVlJoaE81ZjRv?= =?utf-8?B?dGhuQXQrVEQ1SXFzTnRQcXUraUVDa1hyZkNzT1U2OWhmWUlrRjREblU5WUgv?= =?utf-8?B?VWhDMmpZeXJOVnoyYi9qYnRBSGp1WDNvUEpmNGNKcVhtdGFrRnJ5QXQwQ2RV?= =?utf-8?B?NXg5ekRyTVhZSnM1UFNpOTR1RXZzY2lDcUJ2dnhuMlIxdVhaSlREVGVqWGsz?= =?utf-8?B?RmZ0eDlqeHBlM1NBMURvUktGNFFYZ2VvTHRIVHdaaUpUK2xJbVIrYWltTHhS?= =?utf-8?B?R1VnNDZUYTZaU3ZoT3RYRmJUWXd6cW5maHg0eWlJdU0wb0MyOFlPZk8wZ2ZO?= =?utf-8?B?MVRoNjBBL3JSWlhrSVUrL0N1Vk83Ri9SZm1FZXM1ZlJVa1d6L3phVzVaZVpj?= =?utf-8?B?a2NLWVJmLzJKNFdlYkdHSXV6Z2VSeHprRWM0d05xZEVnMWo0UkJSdzBONnRx?= =?utf-8?B?ZlJhLzJGYUlLSmpVa2JtWDRoSm1NUFdBY3Z2T1BIMldVRWQ0TG9nem1heHQy?= =?utf-8?B?N2dYbFBrSUpSVU9GaklZMFFwMVZiUytNVnVmVnN4N1ZiaDMzekFHaVRveVVL?= =?utf-8?B?T3d5VVFSRytPVmxPMmpockhzTTRzRVpTR2JyM2hVbER2UC9HSVV1WTd6Nm9W?= =?utf-8?B?b0FaUkNDT3N0TURaTCtubXZ1VVJQQzhLUWptQmFZenp1RnlPUTc0UjZUeVpN?= =?utf-8?B?R2l2dEQzVGhKRlVLZ2pUM3ArS21vaGQrNEFkVDBLcUI3VW5Ic2xQSFZlSHE4?= =?utf-8?B?S1M2K1d3NkN4Q0xoY2hUcElnWjZ1SnN6ZkdkYVhLMFE4aEd0YlpUNVNZemdr?= =?utf-8?B?ditiMFVqZWdpeTBReVhzQVFJT0ZMMFdKbm85WTJvbEtnMDVmTWVnSWNZZ01v?= =?utf-8?B?UVlVM2c3YnNBdkFjWHJkMWRGQmNVSU9QOEtVbitBelBnTzBUeURBYnEydmg4?= =?utf-8?B?aVZsWDlPVk55RWJHU2krYzJBK2tGdTlmb2ZJRXdaUG9qaW5RdVF4b2IrZ1hJ?= =?utf-8?B?U1QvNkxVMTJ4YlMraXBFTERienFwVHpmaGR0d1NtQXFEV1RLd25mVkl0d3Mv?= =?utf-8?B?dWFqRWJYZDZuNW1yMWMwSThSa2Q3RmFzcmZZaCtBWUdHY0M3dldjeUoxOTQv?= =?utf-8?B?N2xNRHIraWtzcUw3Tk8zM3ZPQVZaS0JncFZLR0hSNVFvdkthOG8zSndsSWJ6?= =?utf-8?B?UWZiNC9BYitWS1g4bVJqTzF1SXJURDFtdVFPZ3htTk0zVVQzNjNCVzI4TmVF?= =?utf-8?B?L3VyTUZSWmZaRWo1TmVWNWpYNE9RSWNWd1VRSG8xT0dRUGJSUmx6Zkx5ajBF?= =?utf-8?B?U1RyZDluMU9WTWVWaHBpYmlMV3VTWEdqajhiZTNITkpZTnpxRlZSTjRjMUE5?= =?utf-8?Q?Rv4Xpb4Ezaf5CTsKJnJiLDziD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d23288b0-ee3c-4860-b81a-08dc48296f21 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 15:29:57.7680 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k1omYE+UJyI56o8rzdL/PYa68g+KuBdVjgBENdqrqUxYdEcs+D2AAoRqCOyXieZ1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8214 X-BeenThere: ci@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK CI discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ci-bounces@dpdk.org On 3/19/2024 2:51 PM, Ferruh Yigit wrote: > On 3/18/2024 9:21 AM, Shani Peretz wrote: >> In the process of auto completion of a command in testpmd, >> the parser splits the command into tokens, where each token >> represents an argument and defines a parsing function. >> The parsing function of the indirect_list action argument was returning >> before having the opportunity to handle the argument. >> > Hi Shani, > > I can see a few other handles follows the updated logic, but to > understand more, was the problematic part following: > ``` > if (!action) > return -1; > ``` > > If so why 'action' can be NULL and why need to continue for this case, > can you please help me understand? > > Also even if 'action' is NULL, function will return output of > 'parse_int()', is this expected? > I can verify the fix via debugging, it seems missing ".comp = comp_none" cause calling handler (parse_indlst_id2ptr), and 'parse_indlst_id2ptr()' needs to be fixed to parse correctly. I will proceed with patch since it is local to a specific flow command, BUT overall how can we catch issues like this in the feature, we don't have a good way to test testpmd flow commands. @Ori, @Gregory, do you have any idea? cc'ed CI mail list too.