From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC389A04B5; Thu, 10 Sep 2020 09:17:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D6241BEB3; Thu, 10 Sep 2020 09:17:01 +0200 (CEST) Received: from smtpbguseast1.qq.com (smtpbguseast1.qq.com [54.204.34.129]) by dpdk.org (Postfix) with ESMTP id CE481255 for ; Thu, 10 Sep 2020 09:16:58 +0200 (CEST) X-QQ-mid: bizesmtp13t1599722207tl28ldn4 Received: from jiawenwu (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Thu, 10 Sep 2020 15:16:47 +0800 (CST) X-QQ-SSF: 01400000002000C0C000000A0000000 X-QQ-FEAT: b0oIbfUHMAguXHTCHYsHiNYpCvC5W0sIRbIsrnV7oYVpMTkY3EN5EYnfgwg2l 7CclCZzUq6lvvAAXsYxMzLKgmsXtdYoHxBA6psQww6gY6S9N60hhv4dWcPLpaA0ezHrZQPr DP/+aqyu+pPwQozSFf/m38gtRu8pdMcTCx1fczjZaROBRGewPn0xEAsHwpD5zgS0KZb1dK5 XGD4BfnynDhUY6+gD176DliXQAlmhDPWK0W85x7PxX7OS/+QEVibuhLRvmbHFr5ELjYGpKP 503LbWVBWhb+jRPLXOwP5OXXqwDNsVIYATizosPsYV5ZnnJAOeBMUkY0QUsv+LFFF1Ol5Gs Obkb7cYx8pGjFyNMTljsK9+cjYMRQ== X-QQ-GoodBg: 2 From: To: "'Ferruh Yigit'" , References: <20200820030231.1382984-1-jiawenwu@trustnetic.com> <006401d68056$5a761840$0f6248c0$@trustnetic.com> <9bf75003-2e08-43b6-dddc-89d75e054235@intel.com> In-Reply-To: <9bf75003-2e08-43b6-dddc-89d75e054235@intel.com> Date: Thu, 10 Sep 2020 15:16:47 +0800 Message-ID: <000101d68742$58a26f80$09e74e80$@trustnetic.com>+D4711CFB1DDD280C MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEqtWxXPBV0hptEKj6a/MU381+bjAHE40K8AcZeb+QBTs+6R6qSRRNA Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign5 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH] net: add a new network PMD named txgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, I am sorry that the patch work plan was disrupted due to other work = inserted. But I have created another nearly 40 patches as the 2nd set. Should I send this set as a supplement to the previous one(as version v1 = or v2?), or fix and verify the previous one firstly? -----Original Message----- From: Ferruh Yigit =20 Sent: Thursday, September 10, 2020 1:45 AM To: jiawenwu@trustnetic.com; dev@dpdk.org Subject: Re: [PATCH] net: add a new network PMD named txgbe On 9/1/2020 12:52 PM, jiawenwu@trustnetic.com wrote: > Hi Ferruh, >=20 > Since this patch is too large, it needs to be split into so many small = patches, which takes a lot of time. Thanks Jiawen for the work, I am aware it is not easy to arrange the = patches and it takes time. Mostly looks good, I am putting some comments on new set. > Therefore, I first created a part of patches to contribute. And if = there is a review problem with these patches, please let me know as = soon. > And I will complete the remaining patches in the next 3~4 days. Even it can go in multiple sets, first we can merge the initial set, you = can verify and fix whatever exists, later can add more feature as = separate sets. >=20 > Thanks. >=20 > -----Original Message----- > From: jiawenwu@trustnetic.com > Sent: Friday, August 21, 2020 10:22 AM > To: 'Ferruh Yigit' ; 'dev@dpdk.org'=20 > > Cc: 'jianwang@trustnetic.com' ;=20 > 'yuhongzhang@trustnetic.com' > Subject: RE: [PATCH] net: add a new network PMD named txgbe >=20 > Hi Ferruh, >=20 > Thanks for your suggestion. I'll split the patch into a patchset as = soon as possible. >=20 > -----Original Message----- > From: Ferruh Yigit > Sent: Thursday, August 20, 2020 7:49 PM > To: Jiawen Wu ; dev@dpdk.org > Cc: jianwang@trustnetic.com; yuhongzhang@trustnetic.com > Subject: Re: [PATCH] net: add a new network PMD named txgbe >=20 > On 8/20/2020 4:02 AM, Jiawen Wu wrote: >> This is a new network PMD named txgbe provides poll mode driver = support for Wangxun 10Gb Ethernet NICs. >> >> Beijing WangXun Technology Co., Ltd. is a high-tech company = specializing in the design of high-end integrated circuit chips and = providing independent innovation solutions for enterprise network and = storage products. Founded in May 2014, the company is headquartered in = Beijing YuQuanHuiGu Science and Technology Park, with branches in = Hangzhou City. Welcome to reach us on website https://www.net-swift.com. >> >> This patch is created base on the main branch in main repository. Our = goal is to validate and commit txgbe driver into the 20.11 official = release, and then continue the development and maintenance in community. >> >> Waiting for your reviews sincerely. >> >> Signed-off-by: Jiawen Wu >=20 > Hi Jiawen, >=20 > Thanks for the patch. >=20 > Without looking into any detail, a very high level comment is, it is = very hard to review a new PMD (40K+ loc) as a single patch. >=20 > Can you please split the patch into multiple patches, which gradually = build the PMD by adding a feature with each patch, starting from an = empty skeleton. >=20 > Last as few upstreamed PMDs as example: > ionic: > = https://patches.dpdk.org/project/dpdk/list/?series=3D8206&state=3D%2A&arc= h > ive=3Dboth >=20 > pfe: > = https://patches.dpdk.org/project/dpdk/list/?series=3D6777&state=3D%2A&arc= h > ive=3Dboth >=20 > octeontx2 (one of the good samples I suggest checking): > = https://patches.dpdk.org/project/dpdk/list/?series=3D5302&state=3D%2A&arc= h > ive=3Dboth >=20 >=20 > Also you can skip all Makefile build system related changes, since it = will be removed in this release, no need to spend time for it. >=20 > Thanks, > ferruh >=20 >=20 >=20