From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id D153D1B6C2 for ; Wed, 7 Feb 2018 08:46:25 +0100 (CET) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w177iYGp001963 for ; Wed, 7 Feb 2018 02:46:23 -0500 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fyumsbyr1-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 07 Feb 2018 02:46:23 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Feb 2018 07:46:21 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 7 Feb 2018 07:46:19 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w177kJ9163111352; Wed, 7 Feb 2018 07:46:19 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E3AF911C05B; Wed, 7 Feb 2018 07:39:41 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B2AD611C052; Wed, 7 Feb 2018 07:39:40 +0000 (GMT) Received: from ADMINIB2M8Q79C (unknown [9.186.60.73]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 7 Feb 2018 07:39:40 +0000 (GMT) From: "Chao Zhu" To: "'Thomas Monjalon'" Cc: "'Gowrishankar'" , References: <3728847.cnur1V9eyL@xps> <000901d39fe1$fcdfcde0$f69f69a0$@linux.vnet.ibm.com> <7852603.J7xFuoqAEp@xps> In-Reply-To: <7852603.J7xFuoqAEp@xps> Date: Wed, 7 Feb 2018 15:46:18 +0800 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 15.0 Content-Language: zh-cn Thread-Index: AQFZ4MNmibhPJyiHKDukoyQxFKjIdgGIppUVAli6mdYCFnXABKRcTbLw X-TM-AS-GCONF: 00 x-cbid: 18020707-0012-0000-0000-000005AC30E1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18020707-0013-0000-0000-00001927E6EC Message-Id: <000b01d39fe7$be271350$3a7539f0$@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-02-07_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802070099 Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement arch-specific TSC freq query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 07:46:26 -0000 Thomas, I think it's OK to apply this patch now. It's been verified before and = it's important for the correctness of the cycle counting on POWER.=20 Thank you! > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: 2018=E5=B9=B42=E6=9C=887=E6=97=A5 15:26 > To: Chao Zhu > Cc: 'Gowrishankar' ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement = arch-specific TSC > freq query >=20 > 07/02/2018 08:05, Chao Zhu: > > The previous patch has some misunderstanding of the the TSC = frequency > > counting. > > I support this. >=20 > Chao, it is very late in the release cycle. > Do you want to take the risk of applying this patch in 18.02-rc4? > If you discover a bug in this patch next week, it will be too late for = fixing it in > 18.02. >=20 >=20 > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > Sent: 2018=E5=B9=B42=E6=9C=881=E6=97=A5 8:30 > > > To: Gowrishankar ; Chao Zhu > > > > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement > > > arch-specific > > TSC > > > freq query > > > > > > 30/01/2018 09:59, Gowrishankar: > > > > From: Gowrishankar Muthukrishnan > > > > > > > > > > > > This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3 > > > > (eal/ppc64: implement arch-specific TSC freq query). We intended > > > > to derive pkt/sec estimation with cpu clock frequency. As = timebase > > > > register serves the timer purpose, we need to stick with it for > > > > calculating pkt/sec, hence reverting the change. > > > > > > > > Fixes: 15692396fd (eal/ppc64: implement arch-specific TSC freq > > > > query) > > > > > > It is not clear what it is fixing. > > > > > > Chao, please review. > > > > >=20 >=20