From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0058.outbound.protection.outlook.com [157.56.112.58]) by dpdk.org (Postfix) with ESMTP id 946435A88 for ; Thu, 20 Aug 2015 04:14:23 +0200 (CEST) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=zlu@ezchip.com; Received: from zhigangTHINK (124.207.145.166) by VI1PR02MB0815.eurprd02.prod.outlook.com (10.162.14.152) with Microsoft SMTP Server (TLS) id 15.1.243.23; Thu, 20 Aug 2015 02:14:21 +0000 From: Tony Lu To: 'Ravi Kerur' , References: <1440014407-3233-1-git-send-email-rkerur@gmail.com> In-Reply-To: <1440014407-3233-1-git-send-email-rkerur@gmail.com> Date: Thu, 20 Aug 2015 10:14:01 +0800 Message-ID: <000c01d0daed$ec601ad0$c5205070$@com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdDauaqdEJ7ag8WGQUqZmJhz2s4p1gAM8zfg Content-Language: zh-cn X-Originating-IP: [124.207.145.166] X-ClientProxiedBy: CY1PR21CA0117.namprd21.prod.outlook.com (25.164.213.43) To VI1PR02MB0815.eurprd02.prod.outlook.com (25.162.14.152) X-Microsoft-Exchange-Diagnostics: 1; VI1PR02MB0815; 2:AYpAIMYE7qGjwakHVargWk8iTxUWua/DJkbqR70Wjm4OG1Dd6cxZDVxGzaoHUX/CSXW8lFjk+yePBDzL5rghZRl57Do0p/0Q0ZsE5oRLF896enFl9RN8JhuNgFKHSJd/uwONG96dhTL+gW9KB9e5xdUnmxtWrwKcF5uzljToIRY=; 3:ZoCpe5lUmZd78xcfV8/gXL3p6n6pXiE27DOKXDF7hvUcEK31yke5UACAvBszxh3JQWFRmlm47fmtImShVKQRbQKQnW03Jcb2eHHY3Xd13FNmCb+7feQ2+aD3CzPAXOb5K4tX5Sx/1mIX0c7KHbNgtQ==; 25:QecVO7rSEbWXmx6x6qFV0zrmICYdBe1xbAc9bEcB//s3lBZPgkg23JSUYnpRCo7QD+FoM+Hmxme31H4zjkIIwNApw7EosI+Haim+vKXt6vbNRPA/X9EPyvnBnFStNsMqyzBzBkj6blYKQ3fl5ri3IZe0WBhpmhsXd/HqsL5QliXyelta0KS8200jt9hD1na29rHh1+TF6wEi/53Ui//oBy6KxQSEkKJdhEYu0ut+oxWt/YjhjjP+UGVpZVoMG7DswGNXt0xqMLbcoxmZ54L3Yw==; 20:buaacGTWGoBmXxJlNsbwqzcze4XmhQ7DkstM4toLZsfnUGvI7fbsDcO5VyEGmcjoH+OZHC0J8MqjQWpYIVdtSkD7rpRw3/hAcbs8B5tbec1mPOiyY4+PfV2S4OpU0qNDTQwAz20W+rnltFflL6fueawOqMzYFalrGWalfsy8DDI= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB0815; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(8121501046)(5005006)(3002001); SRVR:VI1PR02MB0815; BCL:0; PCL:0; RULEID:; SRVR:VI1PR02MB0815; X-Microsoft-Exchange-Diagnostics: 1; VI1PR02MB0815; 4:yAflZjzlTwpDy6F30e9NMH+0cdNw2vfGj86O4hu8whPD9fTBVZHC14COiSZ5d15z3HkMHlUyiy2skOjLmfuoZZtBW6rTJqT+l/pJHvko8HXAdINpafUIKGIKXtrak7TbRzRlgu4LNLbPrdvUwHibA2Po20p3qI6pJSrIHxrPHC16mURVAfakaju2ByZvIyCPuizCxRFWR2XHPYgxvEiyIhXAsLo5vKvJLSx47nuj+A6WA9+l9TvlyS/tuM98qjLHr8GrvbhsRpqwAMuhDWil94najo8p4X9E7Wxdsf5XkQIKNQc3XNxSMYYoxMZx4qLd X-Forefront-PRVS: 0674DC6DD3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(6009001)(189002)(199003)(377454003)(52604005)(13464003)(14726001)(62966003)(19580405001)(2950100001)(102836002)(19580395003)(77156002)(50466002)(61296003)(77096005)(105586002)(92566002)(46102003)(5007970100001)(68736005)(106356001)(97756001)(23726002)(86362001)(101416001)(2656002)(87976001)(33646002)(47776003)(33716001)(59696002)(96836002)(189998001)(46406003)(107886002)(40100003)(5001960100002)(5001860100001)(81156007)(42186005)(64706001)(97736004)(5001770100001)(5001830100001)(4001540100001)(84116002)(50226001)(76176999)(50986999)(66066001)(122386002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR02MB0815; H:zhigangTHINK; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ezchip.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR02MB0815; 23:kSZIDhG9MVbk/KiWMghS0orWiXsvyKRxAj2rMNXLo?= =?us-ascii?Q?0lsQQKpwB8SR0JQ3OnXtiofNynKkc47Bdzyu+auKVMT8IBPk222yJTTPPti6?= =?us-ascii?Q?Zs/UoG8WkNrVDGbdJzCXwCSbxcf10wpmM8LaUaLxuvnNtdvB0hCygYB/JUKI?= =?us-ascii?Q?kaM/IvvZU3UnhcEhfqnpeP198qSM4KwvPQ79DE07Bn9qQQjC2c+Xev3hJFqW?= =?us-ascii?Q?LGRXVHkn6xuWSbyTU0ssMPvIKXPVaIwW0e8X8+sNQluqtqY/96hYt4vFJTvz?= =?us-ascii?Q?Q4MMnwlBXFIovSja0dvWOEEscMlJG5ePRmSTiXM2uHUdrc/i4/HhwuUyBn5s?= =?us-ascii?Q?dEpyToTonPVDuVMRJdbrLTIYYDiWQyMxQabee5IjELRvHX9Z94sni0wpUfCe?= =?us-ascii?Q?lvpzT3ia7G2yJF7y4Oi9x2b9ZoipEIt22cUsksxmtzbnzx7VpRnhw+bH3zOv?= =?us-ascii?Q?vQz9YfMWm4KjyeA5pOBcDwRJZuu2e1hseclhXErWtMp5BpcPwt2bXfYKKKT4?= =?us-ascii?Q?9A8adopSTPqd9tfApqjM2FSJRj7XRh/srsIyySkuEdM7dq49gxPVcCnRfAsE?= =?us-ascii?Q?p1EpzfYwdy6FWUmFjRXBtJeMVBgA6kTbtawy5ne80wfO41cdlWnCz53+IZOn?= =?us-ascii?Q?vcqG/TPoVyxkJfNdJAUkI+G8JUu7jWSN+zfN4nSvVwRgO05/xA//30ciUqys?= =?us-ascii?Q?75/cf6T98cIupgtWhLAroSk/hBZ+hB0+houC32PrO+7kOOWQYRkY3mjJnlRA?= =?us-ascii?Q?G1l+t3bEEb2X1GDxM+ju9o7m7TDT5EbwGglDFu7zXXGpvvEtQ6WWgRDZvZ18?= =?us-ascii?Q?Z/pqp+yv1U6EY4CLLGzr5haqoUp961d8n3FhxSEuDp7Ni3I6UMKGIRRQmQgW?= =?us-ascii?Q?3vfNsH7fq0/lfuNZoLTgI+9xoeLEGxzdVjZ1uAJ0OFHLrLUZxYiXnT5t8mBJ?= =?us-ascii?Q?4THi6j3ofizFeCDciSsPclnYOzFGv9P4fsowyHOfo3uh7u3QcOlZVbpO/IeY?= =?us-ascii?Q?isS4Ac9+TlEMD/KeRUaj6Fl2P0sKuxYG60qQ0PFXuozaIqcU5I4XMBltsUaq?= =?us-ascii?Q?R+AqVCl3377Fzn+J/KPWF5Ji4KOBzUcaMPOmJMzmM/0+AS/QYUTx5qBmHM1m?= =?us-ascii?Q?CbDcxuN71luCVn8ZIOrIF7+xL5Myjl08qO33c1c+ottfJvuvh7iUYrBRYJt8?= =?us-ascii?Q?u3t+/WHPBG7mKSnJFQ53edTXXwhZzkr3obLDvi++U97ldajzjFbl6eaMW90m?= =?us-ascii?Q?79AN9FzmPhKdjZC+eftntV393IIi/7skRRdg+1nTStJwN/7cLs6ByA0cZRx5?= =?us-ascii?Q?S3UEI35QPFQ1gS5Dz+R7ZTbMaZxQ/W2i79bn+8BLP09tvAFGo/JjIRuKWiUZ?= =?us-ascii?Q?smYZgroz7nhPRv/3EJ9xtYBtceh24iZxDLviXld0sxCfxKYTgRN6BnygWfvA?= =?us-ascii?Q?tUd/TVechCjYenRC2/eSrSfK5vNb58=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR02MB0815; 5:LgZi6aEgrnUMlUIWt4eAH+Zv2JmRQGaxHMj3YcIKQ9YVd2ZEg3iuwMxP5Uwgx7Vm14801W24cjAJ60j9tZbCsttMyABUrnZCZZfv1ig1fTMcTNdUIrV3IIk7mVHJIX1qH3NsyIUDycf+ucB7sD1LJQ==; 24:Yup/MMwtTFymSsNjk91Td2+3q3BQ3BgaZUm3wXPYYS4HlaEKnKcLe6PF11BcecKz5hP1FI1SKTeZRmPK3r7awgZlPoXikv7l+GOOHDj9q6g=; 20:LAfFiZWZQSbCbZIV0T5aaayoqIWaj3h3F4YhImGQSZc0sIjRmaWIFahFviLWtc00RFJwnq/EJUclqUuYw8t47A== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2015 02:14:21.1507 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB0815 Subject: Re: [dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Aug 2015 02:14:23 -0000 >-----Original Message----- >From: Ravi Kerur [mailto:rkerur@gmail.com] >Sent: Thursday, August 20, 2015 4:00 AM >To: dev@dpdk.org >Cc: zlu@ezchip.com; Ravi Kerur >Subject: [PATCH v1] Return ENOMEM during mpipe_devinit failure > >In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate >fails return error which is inline with other drivers. > >Signed-off-by: Ravi Kerur >--- > drivers/net/mpipe/mpipe_tilegx.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/net/mpipe/mpipe_tilegx.c >b/drivers/net/mpipe/mpipe_tilegx.c >index 743feef..6e3e304 100644 >--- a/drivers/net/mpipe/mpipe_tilegx.c >+++ b/drivers/net/mpipe/mpipe_tilegx.c >@@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname, > if (!eth_dev) { > RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n", ifname); > rte_free(priv); >+ return -ENOMEM; > } > > RTE_LOG(INFO, PMD, "%s: Initialized mpipe device" >-- >1.9.1 Thanks for fixing this. Acked-by: Zhigang Lu