From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1A2CA04B7; Fri, 11 Sep 2020 08:46:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B5151B13C; Fri, 11 Sep 2020 08:46:44 +0200 (CEST) Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by dpdk.org (Postfix) with ESMTP id 14B0DDE0 for ; Fri, 11 Sep 2020 08:46:41 +0200 (CEST) X-QQ-mid: bizesmtp24t1599806787t89ouql3 Received: from jiawenwu (unknown [183.129.236.74]) by esmtp10.qq.com (ESMTP) with id ; Fri, 11 Sep 2020 14:46:27 +0800 (CST) X-QQ-SSF: 01400000000000C0C000B00A0000000 X-QQ-FEAT: 8oHFcAoL8WNrTmO/Wuf2nAPEu7nEZsFIwU4XL3uIJ1OnQX6gP+P8MCNR6n3hj vgN2e1/fWe6vWzIYaHTeGp0tv2Vu1OT5uvfP74A8iZYUcSFLVgnBVTlmoMrBmRR3ELozRDo +uJLkdk3iuloFNX9JgBdrATjq2vaWpFlBMtDkBlnyLJgcb2U+VrfNME0RyIkr4gFh3IbH23 8+Q6jVgPfh++4CcTyauluRSJxU3CAKaTtdojSQE/ZfJiPV7UmHkiyiXwG8MCkYxN8OLqp0f Ga17cGjsgSCu4Yam0J58zZhJDkhYJg3Ngrn829HbAM/ajQjTPaI6FzPBHvo0OObNRocUdNm 7ZXIpi/ X-QQ-GoodBg: 2 From: To: "'Ferruh Yigit'" , References: <20200820030231.1382984-1-jiawenwu@trustnetic.com> <006401d68056$5a761840$0f6248c0$@trustnetic.com> <9bf75003-2e08-43b6-dddc-89d75e054235@intel.com> <000101d68742$58a26f80$09e74e80$@trustnetic.com> In-Reply-To: Date: Fri, 11 Sep 2020 14:46:27 +0800 Message-ID: <001301d68807$46442cf0$d2cc86d0$@trustnetic.com>+9B23A864B4E63BFE MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEqtWxXPBV0hptEKj6a/MU381+bjAHE40K8AcZeb+QBTs+6RwIWGsxOAf8uYE2qcyLMAA== Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH] net: add a new network PMD named txgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Should the changes for the first set be sent as an additional = patch(maybe several), or replace the exist patch set? It decides me to = remake the 40+ patches or not. -----Original Message----- From: dev On Behalf Of Ferruh Yigit Sent: Thursday, September 10, 2020 7:23 PM To: jiawenwu@trustnetic.com; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net: add a new network PMD named txgbe On 9/10/2020 8:16 AM, jiawenwu@trustnetic.com wrote: > Hi Ferruh, >=20 > I am sorry that the patch work plan was disrupted due to other work = inserted. > But I have created another nearly 40 patches as the 2nd set. > Should I send this set as a supplement to the previous one(as version = v1 or v2?), or fix and verify the previous one firstly? I think better to fix the first set, this may cause changes in the = second one. >=20 > -----Original Message----- > From: Ferruh Yigit > Sent: Thursday, September 10, 2020 1:45 AM > To: jiawenwu@trustnetic.com; dev@dpdk.org > Subject: Re: [PATCH] net: add a new network PMD named txgbe >=20 > On 9/1/2020 12:52 PM, jiawenwu@trustnetic.com wrote: >> Hi Ferruh, >> >> Since this patch is too large, it needs to be split into so many = small patches, which takes a lot of time. >=20 > Thanks Jiawen for the work, I am aware it is not easy to arrange the = patches and it takes time. > Mostly looks good, I am putting some comments on new set. >=20 >> Therefore, I first created a part of patches to contribute. And if = there is a review problem with these patches, please let me know as = soon. >> And I will complete the remaining patches in the next 3~4 days. >=20 > Even it can go in multiple sets, first we can merge the initial set, = you can verify and fix whatever exists, later can add more feature as = separate sets. >=20 >> >> Thanks. >> >> -----Original Message----- >> From: jiawenwu@trustnetic.com >> Sent: Friday, August 21, 2020 10:22 AM >> To: 'Ferruh Yigit' ; 'dev@dpdk.org'=20 >> >> Cc: 'jianwang@trustnetic.com' ;=20 >> 'yuhongzhang@trustnetic.com' >> Subject: RE: [PATCH] net: add a new network PMD named txgbe >> >> Hi Ferruh, >> >> Thanks for your suggestion. I'll split the patch into a patchset as = soon as possible. >> >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Thursday, August 20, 2020 7:49 PM >> To: Jiawen Wu ; dev@dpdk.org >> Cc: jianwang@trustnetic.com; yuhongzhang@trustnetic.com >> Subject: Re: [PATCH] net: add a new network PMD named txgbe >> >> On 8/20/2020 4:02 AM, Jiawen Wu wrote: >>> This is a new network PMD named txgbe provides poll mode driver = support for Wangxun 10Gb Ethernet NICs. >>> >>> Beijing WangXun Technology Co., Ltd. is a high-tech company = specializing in the design of high-end integrated circuit chips and = providing independent innovation solutions for enterprise network and = storage products. Founded in May 2014, the company is headquartered in = Beijing YuQuanHuiGu Science and Technology Park, with branches in = Hangzhou City. Welcome to reach us on website https://www.net-swift.com. >>> >>> This patch is created base on the main branch in main repository. = Our goal is to validate and commit txgbe driver into the 20.11 official = release, and then continue the development and maintenance in community. >>> >>> Waiting for your reviews sincerely. >>> >>> Signed-off-by: Jiawen Wu >> >> Hi Jiawen, >> >> Thanks for the patch. >> >> Without looking into any detail, a very high level comment is, it is = very hard to review a new PMD (40K+ loc) as a single patch. >> >> Can you please split the patch into multiple patches, which gradually = build the PMD by adding a feature with each patch, starting from an = empty skeleton. >> >> Last as few upstreamed PMDs as example: >> ionic: >> = https://patches.dpdk.org/project/dpdk/list/?series=3D8206&state=3D%2A&arc= >> h >> ive=3Dboth >> >> pfe: >> = https://patches.dpdk.org/project/dpdk/list/?series=3D6777&state=3D%2A&arc= >> h >> ive=3Dboth >> >> octeontx2 (one of the good samples I suggest checking): >> = https://patches.dpdk.org/project/dpdk/list/?series=3D5302&state=3D%2A&arc= >> h >> ive=3Dboth >> >> >> Also you can skip all Makefile build system related changes, since it = will be removed in this release, no need to spend time for it. >> >> Thanks, >> ferruh >> >> >> >=20 >=20 >=20 >=20