From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1B036A04DB;
	Fri, 16 Oct 2020 11:53:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 547971EBD9;
	Fri, 16 Oct 2020 11:52:32 +0200 (CEST)
Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130])
 by dpdk.org (Postfix) with ESMTP id 5DBD81EB7E
 for <dev@dpdk.org>; Fri, 16 Oct 2020 11:52:31 +0200 (CEST)
X-QQ-mid: bizesmtp22t1602841945t18xrmvl
Received: from jiawenwu (unknown [183.129.236.74])
 by esmtp6.qq.com (ESMTP) with 
 id ; Fri, 16 Oct 2020 17:52:25 +0800 (CST)
X-QQ-SSF: 01400000000000C0C000B00A0000000
X-QQ-FEAT: qosAMyI7na+PHtIkjIY4u+rBt2UXkWMBTI4UMINp8TKODEd5UGAdFkOOEbaeL
 1CzrtAjoY5Jz0c1Lxt5s2QL/o6z40Sqa1uu4i+hs1kHAR2OnUlQAz5vJTX/0gAe9NXMKG9S
 MJwcsgJ1G8bIkKVkH6IWRVtUIjqRMZeVrDy2Thc9VzR3K87Jedku0MMVSxPYO0MYbnjNyiO
 7UI7QbcPrMBrHkFF8dPSiR3hg2s/F9m6aEMp5ojPZHTS8XoKoSuLFoPMRJ8798XK3k4yNLd
 yIrjub6r4QBPeeof2pb2oUlWG3+9JbBnW51O/8s9QrPSxutQYdDrMazutkNtB074iyqQ==
X-QQ-GoodBg: 2
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Ferruh Yigit'" <ferruh.yigit@intel.com>,
	<dev@dpdk.org>
References: <20201014055517.1214386-1-jiawenwu@trustnetic.com>
 <20201014055517.1214386-3-jiawenwu@trustnetic.com>
 <dc360cd2-c0eb-2013-a2fc-75c714cb1dad@intel.com>
In-Reply-To: <dc360cd2-c0eb-2013-a2fc-75c714cb1dad@intel.com>
Date: Fri, 16 Oct 2020 17:52:25 +0800
Message-ID: <001d01d6a3a2$0d405e40$27c11ac0$@trustnetic.com>+68D9A742E5E0BD63
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQHuhGGkDf+QBDmLivqCOYPBk14HlAH9nBp8AV64BO+pT1baUA==
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign7
X-QQ-Bgrelay: 1
Subject: Re: [dpdk-dev] [PATCH v3 02/56] net/txgbe: add ethdev probe and
	remove
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/15/2020 8:56 AM Ferruh Yigit wrote:
> On 10/14/2020 6:54 AM, Jiawen Wu wrote:
> > Add basic PCIe ethdev probe and remove.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
>=20
> <...>
>=20
> > +RTE_LOG_REGISTER(txgbe_logtype_init, pmd.net.txgbe.init, NOTICE);
> > +RTE_LOG_REGISTER(txgbe_logtype_driver, pmd.net.txgbe.driver, =
NOTICE);
> > +
> > +#ifdef RTE_LIBRTE_TXGBE_DEBUG_RX
> > +	RTE_LOG_REGISTER(txgbe_logtype_rx, pmd.net.txgbe.rx, DEBUG); =
#endif
> > +#ifdef RTE_LIBRTE_TXGBE_DEBUG_TX
> > +	RTE_LOG_REGISTER(txgbe_logtype_tx, pmd.net.txgbe.tx, DEBUG); =
#endif
> > +
> > +#ifdef RTE_LIBRTE_TXGBE_DEBUG_TX_FREE
> > +	RTE_LOG_REGISTER(txgbe_logtype_tx_free, pmd.net.txgbe.tx_free,
> > +DEBUG); #endif
>=20
> Can you please document available logging types in the driver =
documentation?
> ("pmd.net.txgbe.init", .. etc)

Since there is no config/common_base, which file should I add the =
default values
of these config parameters? (RTE_LIBRTE_TXGBE_DEBUG_RX .. etc)