From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 45301A0C4A;
	Thu,  8 Jul 2021 08:09:18 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 24EB74069C;
	Thu,  8 Jul 2021 08:09:18 +0200 (CEST)
Received: from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105])
 by mails.dpdk.org (Postfix) with ESMTP id C7C3240687
 for <dev@dpdk.org>; Thu,  8 Jul 2021 08:09:15 +0200 (CEST)
X-QQ-mid: bizesmtp43t1625724545ty9lnum7
Received: from jiawenwu (unknown [183.129.236.74])
 by esmtp6.qq.com (ESMTP) with 
 id ; Thu, 08 Jul 2021 14:09:04 +0800 (CST)
X-QQ-SSF: 01400000002000D0E000000A0000000
X-QQ-FEAT: AVJTYzY7fVQeapUAYVRzjeeKZnzJjWMmS0IhWAwbsRQ4teGRNM9sOt4G1vhAi
 o5e3reNHHIXOT5zRvaD5DAm+K40sAB01+Qd0q7dr/XuOv4t3DIsJMjEyVyYJJowa19+PjKn
 R0asEfllDLNMrW6IF6lM8kbnVJGD51llbxhE5vnOavxv/NrGWt5BgF2lx17IJvpZD9D40Gd
 DfEyd55TTn4oF/c/x2bbSJY2VyenC7Fl+g+BQa3xY1Ned6aIqy9PIDhn+ad7/iZZUHYKNim
 WIIKSfc2370C8c23OyMIM7AWEfRiEqeIBzdz9ZufBkLqAsVFoqdflyGWQDHNZ/xwbetmrvn
 wtIZWOnQOnNBa5mHIAkFz5d7czQpQ==
X-QQ-GoodBg: 2
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Andrew Rybchenko'" <andrew.rybchenko@oktetlabs.ru>,
	<dev@dpdk.org>
References: <20210706095545.10776-1-jiawenwu@trustnetic.com>
 <20210706095545.10776-15-jiawenwu@trustnetic.com>
 <95f0f8d2-21f5-42c5-4c22-f811b5526f8d@oktetlabs.ru>
In-Reply-To: <95f0f8d2-21f5-42c5-4c22-f811b5526f8d@oktetlabs.ru>
Date: Thu, 8 Jul 2021 14:09:04 +0800
Message-ID: <001f01d773bf$c175ce70$44616b50$@trustnetic.com>+E6374BA975F9B545
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQLzOIuDxIImuXvqoTQ2pR2VqkNk+AK6t12bAZrmXuKo3mC6QA==
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign1
X-QQ-Bgrelay: 1
Subject: Re: [dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop
 operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On July 7, 2021 10:05 PM, Andrew Rybchenko wrote:
> On 7/6/21 12:55 PM, Jiawen Wu wrote:
> > Setup MSI-X interrupt, complete PHY configuration and set device link
> > speed to start device. Disable interrupt, stop hardware and clear
> > queues to stop device.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> 
> WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see
> Documentation/timers/timers-howto.rst
> #242: FILE: drivers/net/ngbe/base/ngbe_phy_mvl.c:70:
> +                       msleep(1);
> 
> Any comments?
> 

This depends on the design of the hardware.
> 
> 
> CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
> #1102: FILE: drivers/net/ngbe/ngbe_rxtx.c:531:
> +
> +}
> 
> Above must be fixed.
> 
> [snip]