From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6E118A0C49;
	Thu,  8 Jul 2021 09:50:17 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0B61C4069C;
	Thu,  8 Jul 2021 09:50:17 +0200 (CEST)
Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166])
 by mails.dpdk.org (Postfix) with ESMTP id 3E95840687
 for <dev@dpdk.org>; Thu,  8 Jul 2021 09:50:13 +0200 (CEST)
X-QQ-mid: bizesmtp33t1625730607tlsm60nl
Received: from jiawenwu (unknown [183.129.236.74])
 by esmtp6.qq.com (ESMTP) with 
 id ; Thu, 08 Jul 2021 15:50:06 +0800 (CST)
X-QQ-SSF: 01400000002000D0E000000A0000000
X-QQ-FEAT: VvqLbp3JaDNC9MvJOaGlLu+2yEednH+mt01eLxgrOhOYom3Av8hBI2qlWnTt4
 pBUntAsM4hAHPPfarsU20Vu6NHqtSuVnTORoNAlOZZUlHaLKq9EEQL+L8hPpdu3w5BNdqaX
 0IjNYvDcLljwe671ie//mcDdXvzJgpVD3vB5Szx1sy433yIbyVrHkOAb4446g/Gr0o642yX
 lGkkrF0kjg4mJIywkwqP4/wypl7tJEZxh7Olnr1BKsKKf0EgAj7IiPNKfg69vfmSPKa7nKq
 Y6erER8XKVvnlO5JFxbnFqqk5CQI/tgwdUa45dHUJbBYbgoC3HB/AUxTnVvezWK2zTtRHvR
 W+0pBF2WWngwUnQb+UakwQczGCdXBfQayq/hAo1
X-QQ-GoodBg: 2
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Andrew Rybchenko'" <andrew.rybchenko@oktetlabs.ru>,
	<dev@dpdk.org>
References: <20210706095545.10776-1-jiawenwu@trustnetic.com>
 <20210706095545.10776-15-jiawenwu@trustnetic.com>
 <95f0f8d2-21f5-42c5-4c22-f811b5526f8d@oktetlabs.ru>
 <001f01d773bf$c175ce70$44616b50$@trustnetic.com>
 <e0d45353-7a5b-77b6-7fd5-81f63f182d24@oktetlabs.ru>
In-Reply-To: <e0d45353-7a5b-77b6-7fd5-81f63f182d24@oktetlabs.ru>
Date: Thu, 8 Jul 2021 15:50:06 +0800
Message-ID: <002001d773cd$de938a20$9bba9e60$@trustnetic.com>+AB7A973C6B637B9E
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQLzOIuDxIImuXvqoTQ2pR2VqkNk+AK6t12bAZrmXuIBl0cPxQJAipb9qL+9rCA=
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign6
X-QQ-Bgrelay: 1
Subject: Re: [dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop
 operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On July 8, 2021 3:37 PM, Andrew Rybchenko wrote:
> On 7/8/21 9:09 AM, Jiawen Wu wrote:
> > On July 7, 2021 10:05 PM, Andrew Rybchenko wrote:
> >> On 7/6/21 12:55 PM, Jiawen Wu wrote:
> >>> Setup MSI-X interrupt, complete PHY configuration and set device
> >>> link speed to start device. Disable interrupt, stop hardware and
> >>> clear queues to stop device.
> >>>
> >>> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> >>
> >> WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see
> >> Documentation/timers/timers-howto.rst
> >> #242: FILE: drivers/net/ngbe/base/ngbe_phy_mvl.c:70:
> >> +                       msleep(1);
> >>
> >> Any comments?
> >>
> >
> > This depends on the design of the hardware.
>=20
> Isn't is a problem if sleep will be longer in fact?

I thought about replacing it with 'msec_delay', but it is working right =
now.
And 'msleep(1)' is also well used in the kernel driver, so I haven't =
changed it yet.